GNU bug report logs - #31959
[PATCH] bootloader: grub-efi: Support EFI directories relative to MOUNT-POINT.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#31959: closed ([PATCH] bootloader: grub-efi: Support EFI
 directories relative to MOUNT-POINT.)
Date: Tue, 07 Apr 2020 13:37:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 07 Apr 2020 15:36:34 +0200
with message-id <87369fo1st.fsf <at> devup.no>
and subject line Re: [bug#31959] [PATCH] bootloader: grub-efi: Support EFI directories relative to MOUNT-POINT.
has caused the debbugs.gnu.org bug report #31959,
regarding [PATCH] bootloader: grub-efi: Support EFI directories relative to MOUNT-POINT.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
31959: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31959
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] bootloader: grub-efi: Support EFI directories relative to
 MOUNT-POINT.
Date: Sun, 24 Jun 2018 22:11:41 +0200

* gnu/bootloader/grub.scm (install-grub-efi): When MOUNT-POINT/EFI-DIR exists,
install there rather than EFI-DIR directly.
---
 gnu/bootloader/grub.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm
index a131f3b50..8371888fa 100644
--- a/gnu/bootloader/grub.scm
+++ b/gnu/bootloader/grub.scm
@@ -387,12 +387,17 @@ submenu \"GNU system, old configurations...\" {~%")
       ;; Install GRUB onto the EFI partition mounted at EFI-DIR, for the
       ;; system whose root is mounted at MOUNT-POINT.
       (let ((grub-install (string-append bootloader "/sbin/grub-install"))
-            (install-dir (string-append mount-point "/boot")))
+            (install-dir (string-append mount-point "/boot"))
+            ;; When installing GuixSD, it's common to mount EFI-DIR below
+            ;; MOUNT-POINT rather than /boot/efi on the live image.
+            (target-esp (if (file-exists? (string-append mount-point efi-dir))
+                            (string-append mount-point efi-dir)
+                            efi-dir)))
         ;; Tell 'grub-install' that there might be a LUKS-encrypted /boot or
         ;; root partition.
         (setenv "GRUB_ENABLE_CRYPTODISK" "y")
         (unless (zero? (system* grub-install "--boot-directory" install-dir
-                                "--efi-directory" efi-dir))
+                                "--efi-directory" target-esp))
           (error "failed to install GRUB (EFI)")))))
 
 
-- 
2.18.0

[Message part 3 (message/rfc822, inline)]

From: Marius Bakke <mbakke <at> fastmail.com>
To: 31959-done <at> debbugs.gnu.org
Subject: Re: [bug#31959] [PATCH] bootloader: grub-efi: Support EFI directories
 relative to MOUNT-POINT.
Date: Tue, 07 Apr 2020 15:36:34 +0200

[Message part 4 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> * gnu/bootloader/grub.scm (install-grub-efi): When MOUNT-POINT/EFI-DIR exists,
> install there rather than EFI-DIR directly.

Pushed way back in aa5a549c65485ff826267a48795c1564af17f1c9.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.