GNU bug report logs - #31958
[PATCH] gnu: Add python-pyblake2.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31958 in the body.
You can then email your comments to 31958 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add python-pyblake2.
Date: Sun, 24 Jun 2018 13:06:11 -0700

[Message part 1 (text/plain, inline)]

Add new package definition for python-pyblake2, needed to upgrade
python-trezor to recent versions.

live well,
  vagrant

[0001-gnu-Add-python-pyblake2.patch (text/x-diff, inline)]

From 4d44cd29429d876b69f532b38be563cb911b8125 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant <at> debian.org>
Date: Sun, 24 Jun 2018 19:31:19 +0000
Subject: [PATCH] gnu: Add python-pyblake2.

* gnu/packages/libusb.scm (python-pyblake2): New variable.
---
 gnu/packages/python.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 08894239c..bc4b7abcd 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13369,6 +13369,25 @@ working with iterables.")
     (description "Lexer and codec to work with LaTeX code in Python.")
     (license license:expat)))
 
+(define-public python-pyblake2
+  (package
+    (name "python-pyblake2")
+    (version "1.1.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pyblake2" version))
+       (sha256
+        (base32
+         "0gz9hgznv5zw4qjq43xa56y0yikimx30gffvibxzm0nv5sq7xk2w"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/dchest/pyblake2")
+    (synopsis
+     "BLAKE2 hash function extension module")
+    (description
+     "BLAKE2 hash function extension module")
+    (license license:cc0)))
+
 (define-public python-pybtex
   (package
     (name "python-pybtex")
-- 
2.11.0

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 31958 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Vagrant Cascadian <vagrant <at> debian.org>, 31958 <at> debbugs.gnu.org
Subject: Re: [bug#31958] [PATCH] gnu: Add python-pyblake2.
Date: Mon, 25 Jun 2018 21:52:30 +0200

[Message part 1 (text/plain, inline)]

Vagrant Cascadian <vagrant <at> debian.org> writes:

> Add new package definition for python-pyblake2, needed to upgrade
> python-trezor to recent versions.

Thanks!  Some comments:

[...]

> * gnu/packages/libusb.scm (python-pyblake2): New variable.
> ---
>  gnu/packages/python.scm | 19 +++++++++++++++++++
>  1 file changed, 19 insertions(+)

There is a mismatch between the commit message and the code here :-)
Though I think this is better suited in 'python-crypto.scm'.  WDYT?

[...]

> +    (home-page "https://github.com/dchest/pyblake2")
> +    (synopsis
> +     "BLAKE2 hash function extension module")

Superfluous line break.

> +    (description
> +     "BLAKE2 hash function extension module")

Can you try to expand on this a little?

> +    (license license:cc0)))

According to COPYING, this software is actually "octuple-licensed":

* CC0 Universal 1.0 - http://creativecommons.org/publicdomain/zero/1.0
* Unlicense — http://unlicense.org/
* WTFPL Version 2 - http://www.wtfpl.net/
* Apache Public License 2.0 - https://www.apache.org/licenses/LICENSE-2.0
* OpenSSL License - https://www.openssl.org/source/license.html
* MIT License - https://opensource.org/licenses/MIT
* The BSD 3-Clause License - https://opensource.org/licenses/BSD-3-Clause
* ISC License - https://opensource.org/licenses/ISC

Can you add each of these, along with an explaning comment?

Thanks in advance!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 31958 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: Marius Bakke <mbakke <at> fastmail.com>, 31958 <at> debbugs.gnu.org
Subject: Re: [bug#31958] [PATCH] gnu: Add python-pyblake2.
Date: Mon, 25 Jun 2018 14:07:43 -0700

[Message part 1 (text/plain, inline)]

On 2018-06-25, Marius Bakke wrote:
> Vagrant Cascadian <vagrant <at> debian.org> writes:
>
>> Add new package definition for python-pyblake2, needed to upgrade
>> python-trezor to recent versions.
>
> Thanks!  Some comments:
>
> [...]
>
>> * gnu/packages/libusb.scm (python-pyblake2): New variable.
>> ---
>>  gnu/packages/python.scm | 19 +++++++++++++++++++
>>  1 file changed, 19 insertions(+)
>
> There is a mismatch between the commit message and the code here :-)

Oops! obvious cut-and-paste error here...


> Though I think this is better suited in 'python-crypto.scm'.  WDYT?

I'll happily defer to someone who knows their way around guix more. :)


>> +    (home-page "https://github.com/dchest/pyblake2")
>> +    (synopsis
>> +     "BLAKE2 hash function extension module")
>
> Superfluous line break.

Will fix.


>> +    (description
>> +     "BLAKE2 hash function extension module")
>
> Can you try to expand on this a little?

I can try, sure.


>> +    (license license:cc0)))
>
> According to COPYING, this software is actually "octuple-licensed":
>
> * CC0 Universal 1.0 - http://creativecommons.org/publicdomain/zero/1.0
> * Unlicense — http://unlicense.org/
> * WTFPL Version 2 - http://www.wtfpl.net/
> * Apache Public License 2.0 - https://www.apache.org/licenses/LICENSE-2.0
> * OpenSSL License - https://www.openssl.org/source/license.html
> * MIT License - https://opensource.org/licenses/MIT
> * The BSD 3-Clause License - https://opensource.org/licenses/BSD-3-Clause
> * ISC License - https://opensource.org/licenses/ISC
>
> Can you add each of these, along with an explaning comment?

And all of those are merely fallback licenses to the author's intention
of public domain... and in the files themselves (pyblake2module.c,
setup.py), they only reference:

  http://creativecommons.org/publicdomain/zero/1.0

But if it's more appropriate for guix to list all possible licenses,
sure. :)


live well,
  vagrant

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 31958 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Vagrant Cascadian <vagrant <at> debian.org>, 31958 <at> debbugs.gnu.org
Subject: Re: [bug#31958] [PATCH] gnu: Add python-pyblake2.
Date: Mon, 25 Jun 2018 23:20:07 +0200

[Message part 1 (text/plain, inline)]

Vagrant Cascadian <vagrant <at> debian.org> writes:

>>> +    (license license:cc0)))
>>
>> According to COPYING, this software is actually "octuple-licensed":
>>
>> * CC0 Universal 1.0 - http://creativecommons.org/publicdomain/zero/1.0
>> * Unlicense — http://unlicense.org/
>> * WTFPL Version 2 - http://www.wtfpl.net/
>> * Apache Public License 2.0 - https://www.apache.org/licenses/LICENSE-2.0
>> * OpenSSL License - https://www.openssl.org/source/license.html
>> * MIT License - https://opensource.org/licenses/MIT
>> * The BSD 3-Clause License - https://opensource.org/licenses/BSD-3-Clause
>> * ISC License - https://opensource.org/licenses/ISC
>>
>> Can you add each of these, along with an explaning comment?
>
> And all of those are merely fallback licenses to the author's intention
> of public domain... and in the files themselves (pyblake2module.c,
> setup.py), they only reference:
>
>   http://creativecommons.org/publicdomain/zero/1.0
>
> But if it's more appropriate for guix to list all possible licenses,
> sure. :)

Right.  I missed the top comment of the COPYING file[0], which dedicates
the software to the public domain.  But it also says that you are free
to choose any of the others at your discretion.

So I think CC0 is appropriate, but please add a comment explaning the
situation.  Thanks!

[0] https://github.com/dchest/pyblake2/blob/master/COPYING

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 31958 <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: Marius Bakke <mbakke <at> fastmail.com>, 31958 <at> debbugs.gnu.org
Subject: Re: [bug#31958] [PATCH] gnu: Add python-pyblake2.
Date: Mon, 25 Jun 2018 21:37:48 -0700

[Message part 1 (text/plain, inline)]

On 2018-06-25, Marius Bakke wrote:
> Vagrant Cascadian <vagrant <at> debian.org> writes:
>>> According to COPYING, this software is actually "octuple-licensed":
>>>
>>> * CC0 Universal 1.0 - http://creativecommons.org/publicdomain/zero/1.0
>>> * Unlicense — http://unlicense.org/
>>> * WTFPL Version 2 - http://www.wtfpl.net/
>>> * Apache Public License 2.0 - https://www.apache.org/licenses/LICENSE-2.0
>>> * OpenSSL License - https://www.openssl.org/source/license.html
>>> * MIT License - https://opensource.org/licenses/MIT
>>> * The BSD 3-Clause License - https://opensource.org/licenses/BSD-3-Clause
>>> * ISC License - https://opensource.org/licenses/ISC
>>>
>>> Can you add each of these, along with an explaning comment?
>>
>> And all of those are merely fallback licenses to the author's intention
>> of public domain... and in the files themselves (pyblake2module.c,
>> setup.py), they only reference:
>>
>>   http://creativecommons.org/publicdomain/zero/1.0
>>
>> But if it's more appropriate for guix to list all possible licenses,
>> sure. :)
>
> Right.  I missed the top comment of the COPYING file[0], which dedicates
> the software to the public domain.  But it also says that you are free
> to choose any of the others at your discretion.
>
> So I think CC0 is appropriate, but please add a comment explaning the
> situation.  Thanks!
>
> [0] https://github.com/dchest/pyblake2/blob/master/COPYING

Updated patch:
- fixed commit message
- moved to python-crypto.scm
- removed needless linebreak
- updated description
- updated licensing to public-domain/cc0
- clarified additional licensing in comments

Hopefully that covers everything.


live well,
  vagrant

[0001-gnu-Add-python-pyblake2.patch (text/x-diff, inline)]

From d6101ee18f130fb13aa75a0978cfc0da33e6b915 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant <at> debian.org>
Date: Mon, 25 Jun 2018 21:32:06 -0700
Subject: [PATCH] gnu: Add python-pyblake2.

* gnu/packages/python-crypto.scm (python-pyblake2): New variable.
---
 gnu/packages/python-crypto.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/python-crypto.scm b/gnu/packages/python-crypto.scm
index e29eaea80..214671fd3 100644
--- a/gnu/packages/python-crypto.scm
+++ b/gnu/packages/python-crypto.scm
@@ -170,6 +170,34 @@ John the Ripper).")
     ;; the rest is under ISC.
     (license (list license:isc license:bsd-3 license:bsd-4))))
 
+(define-public python-pyblake2
+  (package
+    (name "python-pyblake2")
+    (version "1.1.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pyblake2" version))
+       (sha256
+        (base32
+         "0gz9hgznv5zw4qjq43xa56y0yikimx30gffvibxzm0nv5sq7xk2w"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/dchest/pyblake2")
+    (synopsis "BLAKE2 hash function extension module")
+    (description "Python BLAKE2 hash function extension module. BLAKE2 is
+a cryptographic hash function, which offers stronger security while being as
+fast as MD5 or SHA-1, and comes in two flavors: BLAKE2b, optimized for 64-bit
+platforms and produces digests of any size between 1 and 64 bytes, and
+BLAKE2s, optimized for 8- to 32-bit platforms and produces digests of any size
+between 1 and 32 bytes. BLAKE2 supports keyed mode (a faster and simpler
+replacement for HMAC), salted hashing, personalization, and tree hashing.
+Hash objects from this module follow the API of standard library's hashlib
+objects.")
+    ;; The COPYING file declares it as public domain, with the option to
+    ;; alternately use it under a variety of permissive licenses. cc0 is
+    ;; explicitly mentioned in setup.py and pyblake2module.c
+    (license (list license:public-domain license:cc0))))
+
 (define-public python2-py-bcrypt
   (package-with-python2 python-py-bcrypt))
 
-- 
2.11.0

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 31958-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Vagrant Cascadian <vagrant <at> debian.org>, 31958-done <at> debbugs.gnu.org
Cc: 31957-done <at> debbugs.gnu.org
Subject: Re: [bug#31958] [PATCH] gnu: Add python-pyblake2.
Date: Tue, 26 Jun 2018 23:53:49 +0200

[Message part 1 (text/plain, inline)]

Vagrant Cascadian <vagrant <at> debian.org> writes:

> On 2018-06-25, Marius Bakke wrote:
>> Vagrant Cascadian <vagrant <at> debian.org> writes:
>>>> According to COPYING, this software is actually "octuple-licensed":
>>>>
>>>> * CC0 Universal 1.0 - http://creativecommons.org/publicdomain/zero/1.0
>>>> * Unlicense — http://unlicense.org/
>>>> * WTFPL Version 2 - http://www.wtfpl.net/
>>>> * Apache Public License 2.0 - https://www.apache.org/licenses/LICENSE-2.0
>>>> * OpenSSL License - https://www.openssl.org/source/license.html
>>>> * MIT License - https://opensource.org/licenses/MIT
>>>> * The BSD 3-Clause License - https://opensource.org/licenses/BSD-3-Clause
>>>> * ISC License - https://opensource.org/licenses/ISC
>>>>
>>>> Can you add each of these, along with an explaning comment?
>>>
>>> And all of those are merely fallback licenses to the author's intention
>>> of public domain... and in the files themselves (pyblake2module.c,
>>> setup.py), they only reference:
>>>
>>>   http://creativecommons.org/publicdomain/zero/1.0
>>>
>>> But if it's more appropriate for guix to list all possible licenses,
>>> sure. :)
>>
>> Right.  I missed the top comment of the COPYING file[0], which dedicates
>> the software to the public domain.  But it also says that you are free
>> to choose any of the others at your discretion.
>>
>> So I think CC0 is appropriate, but please add a comment explaning the
>> situation.  Thanks!
>>
>> [0] https://github.com/dchest/pyblake2/blob/master/COPYING
>
> Updated patch:
> - fixed commit message
> - moved to python-crypto.scm
> - removed needless linebreak
> - updated description
> - updated licensing to public-domain/cc0
> - clarified additional licensing in comments
>
> Hopefully that covers everything.

Thank you!

I shortened the description a bit while adding @code{} notations where
appropriate, and also added a copyright statement for you.  Hope that
was okay :-)

I also moved the package so it wasn't squeezed between the Python3 and
Python2 variants of python-py-bcrypt.

(...and closing the previous patch bug while at it...)

Pushed as e64088f0b521145286bfe3f028699e418baf4832!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.