GNU bug report logs - #31958
[PATCH] gnu: Add python-pyblake2.

Previous Next

Package: guix-patches;

Reported by: Vagrant Cascadian <vagrant <at> debian.org>

Date: Sun, 24 Jun 2018 20:07:02 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#31958: closed ([PATCH] gnu: Add python-pyblake2.)
Date: Tue, 26 Jun 2018 21:55:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Tue, 26 Jun 2018 23:53:49 +0200
with message-id <878t71xlhu.fsf <at> fastmail.com>
and subject line Re: [bug#31958] [PATCH] gnu: Add python-pyblake2.
has caused the debbugs.gnu.org bug report #31958,
regarding [PATCH] gnu: Add python-pyblake2.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
31958: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31958
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Vagrant Cascadian <vagrant <at> debian.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add python-pyblake2.
Date: Sun, 24 Jun 2018 13:06:11 -0700
[Message part 3 (text/plain, inline)]
Add new package definition for python-pyblake2, needed to upgrade
python-trezor to recent versions.

live well,
  vagrant

[0001-gnu-Add-python-pyblake2.patch (text/x-diff, inline)]
From 4d44cd29429d876b69f532b38be563cb911b8125 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagrant <at> debian.org>
Date: Sun, 24 Jun 2018 19:31:19 +0000
Subject: [PATCH] gnu: Add python-pyblake2.

* gnu/packages/libusb.scm (python-pyblake2): New variable.
---
 gnu/packages/python.scm | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index 08894239c..bc4b7abcd 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -13369,6 +13369,25 @@ working with iterables.")
     (description "Lexer and codec to work with LaTeX code in Python.")
     (license license:expat)))
 
+(define-public python-pyblake2
+  (package
+    (name "python-pyblake2")
+    (version "1.1.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "pyblake2" version))
+       (sha256
+        (base32
+         "0gz9hgznv5zw4qjq43xa56y0yikimx30gffvibxzm0nv5sq7xk2w"))))
+    (build-system python-build-system)
+    (home-page "https://github.com/dchest/pyblake2")
+    (synopsis
+     "BLAKE2 hash function extension module")
+    (description
+     "BLAKE2 hash function extension module")
+    (license license:cc0)))
+
 (define-public python-pybtex
   (package
     (name "python-pybtex")
-- 
2.11.0

[signature.asc (application/pgp-signature, inline)]
[Message part 6 (message/rfc822, inline)]
From: Marius Bakke <mbakke <at> fastmail.com>
To: Vagrant Cascadian <vagrant <at> debian.org>, 31958-done <at> debbugs.gnu.org
Cc: 31957-done <at> debbugs.gnu.org
Subject: Re: [bug#31958] [PATCH] gnu: Add python-pyblake2.
Date: Tue, 26 Jun 2018 23:53:49 +0200
[Message part 7 (text/plain, inline)]
Vagrant Cascadian <vagrant <at> debian.org> writes:

> On 2018-06-25, Marius Bakke wrote:
>> Vagrant Cascadian <vagrant <at> debian.org> writes:
>>>> According to COPYING, this software is actually "octuple-licensed":
>>>>
>>>> * CC0 Universal 1.0 - http://creativecommons.org/publicdomain/zero/1.0
>>>> * Unlicense — http://unlicense.org/
>>>> * WTFPL Version 2 - http://www.wtfpl.net/
>>>> * Apache Public License 2.0 - https://www.apache.org/licenses/LICENSE-2.0
>>>> * OpenSSL License - https://www.openssl.org/source/license.html
>>>> * MIT License - https://opensource.org/licenses/MIT
>>>> * The BSD 3-Clause License - https://opensource.org/licenses/BSD-3-Clause
>>>> * ISC License - https://opensource.org/licenses/ISC
>>>>
>>>> Can you add each of these, along with an explaning comment?
>>>
>>> And all of those are merely fallback licenses to the author's intention
>>> of public domain... and in the files themselves (pyblake2module.c,
>>> setup.py), they only reference:
>>>
>>>   http://creativecommons.org/publicdomain/zero/1.0
>>>
>>> But if it's more appropriate for guix to list all possible licenses,
>>> sure. :)
>>
>> Right.  I missed the top comment of the COPYING file[0], which dedicates
>> the software to the public domain.  But it also says that you are free
>> to choose any of the others at your discretion.
>>
>> So I think CC0 is appropriate, but please add a comment explaning the
>> situation.  Thanks!
>>
>> [0] https://github.com/dchest/pyblake2/blob/master/COPYING
>
> Updated patch:
> - fixed commit message
> - moved to python-crypto.scm
> - removed needless linebreak
> - updated description
> - updated licensing to public-domain/cc0
> - clarified additional licensing in comments
>
> Hopefully that covers everything.

Thank you!

I shortened the description a bit while adding @code{} notations where
appropriate, and also added a copyright statement for you.  Hope that
was okay :-)

I also moved the package so it wasn't squeezed between the Python3 and
Python2 variants of python-py-bcrypt.

(...and closing the previous patch bug while at it...)

Pushed as e64088f0b521145286bfe3f028699e418baf4832!
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 6 years and 327 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.