GNU bug report logs - #31855
27.0.50; Async shell command finished message not visible any more

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31855 in the body.
You can then email your comments to 31855 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.0.50; Async shell command finished message not visible any more
Date: Sat, 16 Jun 2018 07:12:50 +0200

Hi,

I'm not sure if this issue has any other relation to `shell-command'
than it's where the problem occurs to me - anyway:

In emacs25 -Q, I type, for example, M-! t r u e SPC & <return>, and the
echo area displays "true: finished".

In master emacs -Q, doing the same gives you no visible feedback any
more.  A message is logged in *Messages*, but it seems to be dismissed
immediately.


TIA;

Michael.


In GNU Emacs 27.0.50 (build 13, x86_64-pc-linux-gnu, GTK+ Version 3.22.29)
 of 2018-06-16 built on drachen
Repository revision: aa0f4760996d82610ea0010919436729f08b2883
Windowing system distributor 'The X.Org Foundation', version 11.0.11906000
System Description: Debian GNU/Linux buster/sid

Message #8 received at 31855 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: "Daniel Colascione" <dancol <at> dancol.org>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, 31855 <at> debbugs.gnu.org
Subject: Re: bug#31855: 27.0.50;
 Async shell command finished message not visible any more
Date: Sat, 16 Jun 2018 11:48:56 +0300

> From: Michael Heerdegen <michael_heerdegen <at> web.de>
> Date: Sat, 16 Jun 2018 07:12:50 +0200
> 
> In emacs25 -Q, I type, for example, M-! t r u e SPC & <return>, and the
> echo area displays "true: finished".
> 
> In master emacs -Q, doing the same gives you no visible feedback any
> more.  A message is logged in *Messages*, but it seems to be dismissed
> immediately.

Daniel, this seems to be due to your recent changes in keyboard.c.  If
I make the change below, which reverts a small part of your changes,
the problem is gone:

diff --git a/src/keyboard.c b/src/keyboard.c
index 5409918..76097e8 100644
--- a/src/keyboard.c
+++ b/src/keyboard.c
@@ -8999,7 +8999,7 @@ read_key_sequence (Lisp_Object *keybuf, Lisp_Object prompt,
   /* These are no-ops the first time through, but if we restart, they
      revert the echo area and this_command_keys to their original state.  */
   this_command_key_count = keys_start;
-  if (INTERACTIVE && is_replay)
+  if (INTERACTIVE && t < mock_input)
     echo_truncate (echo_start);
   is_replay = true;
 

Message #11 received at 31855 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Colascione <dancol <at> dancol.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Michael Heerdegen <michael_heerdegen <at> web.de>, 31855 <at> debbugs.gnu.org
Subject: Re: bug#31855: 27.0.50; Async shell command finished message not
 visible any more
Date: Sat, 16 Jun 2018 14:17:22 -0700

On 06/16/2018 01:48 AM, Eli Zaretskii wrote:
>> From: Michael Heerdegen <michael_heerdegen <at> web.de>
>> Date: Sat, 16 Jun 2018 07:12:50 +0200
>>
>> In emacs25 -Q, I type, for example, M-! t r u e SPC & <return>, and the
>> echo area displays "true: finished".
>>
>> In master emacs -Q, doing the same gives you no visible feedback any
>> more.  A message is logged in *Messages*, but it seems to be dismissed
>> immediately.
> 
> Daniel, this seems to be due to your recent changes in keyboard.c.  If
> I make the change below, which reverts a small part of your changes,
> the problem is gone:
> 
> diff --git a/src/keyboard.c b/src/keyboard.c
> index 5409918..76097e8 100644
> --- a/src/keyboard.c
> +++ b/src/keyboard.c
> @@ -8999,7 +8999,7 @@ read_key_sequence (Lisp_Object *keybuf, Lisp_Object prompt,
>     /* These are no-ops the first time through, but if we restart, they
>        revert the echo area and this_command_keys to their original state.  */
>     this_command_key_count = keys_start;
> -  if (INTERACTIVE && is_replay)
> +  if (INTERACTIVE && t < mock_input)
>       echo_truncate (echo_start);
>     is_replay = true;

Yep. You're right. I'll bring us back to the old logic here.

I just worry that the "t < mock_input" condition is wrong in the case 
where we use a function key map to rewrite an input to nothing, but 
maybe the improved last_nonmenu_event tracking will fix that class of 
problem by itself.

Message #16 received at 31855 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Daniel Colascione <dancol <at> dancol.org>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 31855 <at> debbugs.gnu.org
Subject: Re: bug#31855: 27.0.50;
 Async shell command finished message not visible any more
Date: Sun, 17 Jun 2018 06:48:27 +0200

Daniel Colascione <dancol <at> dancol.org> writes:

> > Daniel, this seems to be due to your recent changes in keyboard.c.
> > If I make the change below, which reverts a small part of your
> > changes, the problem is gone: [...]

> Yep. You're right. I'll bring us back to the old logic here.

Works for me, thanks.


Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.