GNU bug report logs - #31854
[PATCH 1/8] gnu: Add perl-x11-protocol-other.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Kei Kebreau <kkebreau <at> posteo.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#31854: closed ([PATCH 1/8] gnu: Add perl-x11-protocol-other.)
Date: Sun, 17 Jun 2018 00:55:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 16 Jun 2018 20:54:22 -0400
with message-id <87602i2pxd.fsf <at> posteo.net>
and subject line Re: [bug#31854] [PATCH 1/8] gnu: Add perl-x11-protocol-other.
has caused the debbugs.gnu.org bug report #31854,
regarding [PATCH 1/8] gnu: Add perl-x11-protocol-other.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
31854: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31854
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Kei Kebreau <kkebreau <at> posteo.net>
To: guix-patches <at> gnu.org
Cc: Kei Kebreau <kkebreau <at> posteo.net>
Subject: [PATCH 1/8] gnu: Add perl-x11-protocol-other.
Date: Fri, 15 Jun 2018 22:24:07 -0400

* gnu/packages/xorg.scm (perl-x11-protocol-other): New variable.
---
 gnu/packages/xorg.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm
index 54001187d..5e930fe0d 100644
--- a/gnu/packages/xorg.scm
+++ b/gnu/packages/xorg.scm
@@ -15,6 +15,7 @@
 ;;; Copyright © 2017, 2018 Rutger Helling <rhelling <at> mykolab.com>
 ;;; Copyright © 2017 Arun Isaac <arunisaac <at> systemreboot.net>
 ;;; Copyright © 2018 Tobias Geerinckx-Rice <me <at> tobias.gr>
+;;; Copyright © 2018 Kei Kebreau <kkebreau <at> posteo.net>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5855,6 +5856,32 @@ perl programs to display windows and graphics on X11 servers.")
     ;; for details)."
     (license license:perl-license)))
 
+(define-public perl-x11-protocol-other
+  (package
+    (name "perl-x11-protocol-other")
+    (version "30")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/K/KR/KRYDE/X11-Protocol-Other-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "1mambi57cdkj82wiw1l8y2f70a60qsamdas0165hlj10drryfgrj"))))
+    (build-system perl-build-system)
+    (native-inputs
+     `(("perl-encode-hanextra" ,perl-encode-hanextra)
+       ("perl-module-util" ,perl-module-util)))
+    (propagated-inputs
+     `(("perl-x11-protocol" ,perl-x11-protocol)))
+    (home-page "http://search.cpan.org/dist/X11-Protocol-Other/")
+    (synopsis "Miscellaneous helpers for X11::Protocol connections")
+    (description
+     "X11::Protocol::Other contains window manager related functions for use by
+client programs, as per the ICCCM and some of the EWMH.")
+    (license license:gpl3+)))
+
 (define-public xcompmgr
   (package
     (name "xcompmgr")
-- 
2.17.1

[Message part 3 (message/rfc822, inline)]

From: Kei Kebreau <kkebreau <at> posteo.net>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 31854-done <at> debbugs.gnu.org
Subject: Re: [bug#31854] [PATCH 1/8] gnu: Add perl-x11-protocol-other.
Date: Sat, 16 Jun 2018 20:54:22 -0400

[Message part 4 (text/plain, inline)]

ludo <at> gnu.org (Ludovic Courtès) writes:

> Hello Kei,
>
> I quickly looked at the whole series and it looks good to me.  A couple
> of points: make sure to use ‘perl-license’ and not ‘(package-license perl)’
> (there are a few occurrences of the latter), and perhaps some more @code
> or @file in synopses/descriptions would help in some places (when
> referring to Perl modules for instance.)
>
> Feel free to push when it’s ready!
>
> Thanks,
> Ludo’.

Cleaned up and pushed to master. As always, thanks for the review!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.