GNU bug report logs - #31598
Check for initrd-modules fails to detect when loaded module and on-disk module filename differ

Previous Next

Package: guix;

Reported by: Vagrant Cascadian <vagrant <at> debian.org>

Date: Fri, 25 May 2018 21:15:02 UTC

Severity: normal

Merged with 31714

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31598 in the body.
You can then email your comments to 31598 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-guix <at> gnu.org:
bug#31598; Package guix. (Fri, 25 May 2018 21:15:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Vagrant Cascadian <vagrant <at> debian.org>:
New bug report received and forwarded. Copy sent to bug-guix <at> gnu.org. (Fri, 25 May 2018 21:15:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Vagrant Cascadian <vagrant <at> debian.org>
To: bug-guix <at> gnu.org
Subject: Check for initrd-modules fails to detect when loaded module and
 on-disk module filename differ
Date: Fri, 25 May 2018 14:14:15 -0700
[Message part 1 (text/plain, inline)]
The check for initrd-modules does not appear to handle when loaded
modules use underscores (e.g. "sdhci_of_arasan") but the on-disk modules
use dashes (e.g. "sdhci-of-arasan"). Some modules even use a mix of
underscores and dashes, just to keep it interesting.

The workaround is to use --skip-checks, but this may skip other
important checks.

Putting the "sdhci_of_arasan" in my system config, it fails because it
cannot find the kernel module on-disk by that name.

Ideally, it would find some way of mapping the loaded module names to
the on-disk module filenames, and detect appropriately, ideally
allowing either the on-disk filename or the loaded module name in the
config.


In my config:

  (initrd-modules (append (list ... "sdhci-of-arasan" ... ) %base-initrd-modules))


When I run:

  $ sudo -E guix system reconfigure /etc/config.scm

  <unknown location>: error: you may need these modules in the initrd for /dev/mmcblk1p1: sdhci_of_arasan
  hint: Try adding them to the `initrd-modules' field of your `operating-system' declaration, along these
  lines:

        (operating-system
          ;; ...
          (initrd-modules (append (list "sdhci_of_arasan")
                                  %base-initrd-modules)))

Since the on-disk module name uses "-" instead of underscores:

  $ find /gnu/store/*linux-libre* -name '*'arasan.ko
  /gnu/store/nilzipm6fpicvlzfv1w8yj1j8mm1xlan-linux-libre-4.16.11/lib/modules/4.16.11-gnu/kernel/drivers/mmc/host/sdhci-of-arasan.ko


But the loaded module uses "_" in the name:

  $ lsmod | grep arasan
  sdhci_of_arasan        20480  1
  cqhci                  24576  1 sdhci_of_arasan
  sdhci_pltfm            16384  1 sdhci_of_arasan
  sdhci                  61440  2 sdhci_pltfm,sdhci_of_arasan


live well,
  vagrant
[signature.asc (application/pgp-signature, inline)]

Merged 31598 31714. Request was from ludo <at> gnu.org (Ludovic Courtès) to control <at> debbugs.gnu.org. (Thu, 07 Jun 2018 16:12:02 GMT) Full text and rfc822 format available.

Reply sent to ludo <at> gnu.org (Ludovic Courtès):
You have taken responsibility. (Thu, 14 Jun 2018 21:39:02 GMT) Full text and rfc822 format available.

Notification sent to Vagrant Cascadian <vagrant <at> debian.org>:
bug acknowledged by developer. (Thu, 14 Jun 2018 21:39:02 GMT) Full text and rfc822 format available.

Message #12 received at 31598-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Vagrant Cascadian <vagrant <at> debian.org>, <pelzflorian <at> pelzflorian.de>
Cc: 31598-done <at> debbugs.gnu.org
Subject: Re: bug#31598: Check for initrd-modules fails to detect when loaded
 module and on-disk module filename differ
Date: Thu, 14 Jun 2018 23:38:14 +0200
Hello Vagrant & Florian,

Vagrant Cascadian <vagrant <at> debian.org> skribis:

> In my config:
>
>   (initrd-modules (append (list ... "sdhci-of-arasan" ... ) %base-initrd-modules))
>
>
> When I run:
>
>   $ sudo -E guix system reconfigure /etc/config.scm
>
>   <unknown location>: error: you may need these modules in the initrd for /dev/mmcblk1p1: sdhci_of_arasan
>   hint: Try adding them to the `initrd-modules' field of your `operating-system' declaration, along these
>   lines:
>
>         (operating-system
>           ;; ...
>           (initrd-modules (append (list "sdhci_of_arasan")
>                                   %base-initrd-modules)))
>
> Since the on-disk module name uses "-" instead of underscores:
>
>   $ find /gnu/store/*linux-libre* -name '*'arasan.ko
>   /gnu/store/nilzipm6fpicvlzfv1w8yj1j8mm1xlan-linux-libre-4.16.11/lib/modules/4.16.11-gnu/kernel/drivers/mmc/host/sdhci-of-arasan.ko
>
>
> But the loaded module uses "_" in the name:
>
>   $ lsmod | grep arasan
>   sdhci_of_arasan        20480  1
>   cqhci                  24576  1 sdhci_of_arasan
>   sdhci_pltfm            16384  1 sdhci_of_arasan
>   sdhci                  61440  2 sdhci_pltfm,sdhci_of_arasan

I believe this is fixed by 411959bef30b488928ab2418a064c8a9b0347c41.
Let me know if it’s not!

Thanks,
Ludo’.




Reply sent to ludo <at> gnu.org (Ludovic Courtès):
You have taken responsibility. (Thu, 14 Jun 2018 21:39:03 GMT) Full text and rfc822 format available.

Notification sent to "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>:
bug acknowledged by developer. (Thu, 14 Jun 2018 21:39:03 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 27 Aug 2018 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 6 years and 349 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.