GNU bug report logs - #31522
[PATCH] guix-install.sh: Fix chk_require exiting without warning.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Subject: bug#31522: closed (Re: [bug#31522] [PATCH] guix-install.sh: Fix
 chk_require exiting without warning.)
Date: Sat, 19 May 2018 20:48:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#31522: [PATCH] guix-install.sh: Fix chk_require exiting without warning.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 31522 <at> debbugs.gnu.org.

-- 
31522: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31522
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 31522-done <at> debbugs.gnu.org
Subject: Re: [bug#31522] [PATCH] guix-install.sh: Fix chk_require exiting
 without warning.
Date: Sat, 19 May 2018 22:47:18 +0200

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> From 726d05a99529823d94c3fff1fa8619953e384b44 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Fri, 18 May 2018 10:51:29 -0400
> Subject: [PATCH] guix-install.sh: Fix chk_require exiting without warning.
>
> * etc/guix-install.sh (chk_require): Because of the set -e option, Bash was
> exiting when the command `command -v "$c" &>/dev/null' was running on its
> own. Instead, we now test the command and accumulate warning messages in a
> single statement by chaining the command with a logical OR.

Applied, thanks!  :-)

Ludo'.

[Message part 3 (message/rfc822, inline)]

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] guix-install.sh: Fix chk_require exiting without warning.
Date: Fri, 18 May 2018 17:29:19 -0400

[Message part 4 (text/plain, inline)]

Attached is a patch to fix a problem in the detection of missing
programs in the guix-install.sh Bash script.

Maxim

[0001-guix-install.sh-Fix-chk_require-exiting-without-warn.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.