GNU bug report logs - #31522
[PATCH] guix-install.sh: Fix chk_require exiting without warning.

Previous Next

Package: guix-patches;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Fri, 18 May 2018 21:30:02 UTC

Severity: normal

Tags: patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31522 in the body.
You can then email your comments to 31522 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to guix-patches <at> gnu.org:
bug#31522; Package guix-patches. (Fri, 18 May 2018 21:30:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 18 May 2018 21:30:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] guix-install.sh: Fix chk_require exiting without warning.
Date: Fri, 18 May 2018 17:29:19 -0400

[Message part 1 (text/plain, inline)]
Attached is a patch to fix a problem in the detection of missing
programs in the guix-install.sh Bash script.

Maxim

[0001-guix-install.sh-Fix-chk_require-exiting-without-warn.patch (text/x-patch, attachment)]
Reply sent to ludo <at> gnu.org (Ludovic Courtès):
You have taken responsibility. (Sat, 19 May 2018 20:48:02 GMT) Full text and rfc822 format available.
Notification sent to Maxim Cournoyer <maxim.cournoyer <at> gmail.com>:
bug acknowledged by developer. (Sat, 19 May 2018 20:48:02 GMT) Full text and rfc822 format available.

Message #10 received at 31522-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 31522-done <at> debbugs.gnu.org
Subject: Re: [bug#31522] [PATCH] guix-install.sh: Fix chk_require exiting
 without warning.
Date: Sat, 19 May 2018 22:47:18 +0200

Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> From 726d05a99529823d94c3fff1fa8619953e384b44 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Fri, 18 May 2018 10:51:29 -0400
> Subject: [PATCH] guix-install.sh: Fix chk_require exiting without warning.
>
> * etc/guix-install.sh (chk_require): Because of the set -e option, Bash was
> exiting when the command `command -v "$c" &>/dev/null' was running on its
> own. Instead, we now test the command and accumulate warning messages in a
> single statement by chaining the command with a logical OR.

Applied, thanks!  :-)

Ludo'.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 17 Jun 2018 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 7 years and 96 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.