GNU bug report logs - #31522
[PATCH] guix-install.sh: Fix chk_require exiting without warning.

Previous Next

Package: guix-patches;

Reported by: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Date: Fri, 18 May 2018 21:30:02 UTC

Severity: normal

Tags: patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

Full log


Message #10 received at 31522-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 31522-done <at> debbugs.gnu.org
Subject: Re: [bug#31522] [PATCH] guix-install.sh: Fix chk_require exiting
 without warning.
Date: Sat, 19 May 2018 22:47:18 +0200
Maxim Cournoyer <maxim.cournoyer <at> gmail.com> skribis:

> From 726d05a99529823d94c3fff1fa8619953e384b44 Mon Sep 17 00:00:00 2001
> From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> Date: Fri, 18 May 2018 10:51:29 -0400
> Subject: [PATCH] guix-install.sh: Fix chk_require exiting without warning.
>
> * etc/guix-install.sh (chk_require): Because of the set -e option, Bash was
> exiting when the command `command -v "$c" &>/dev/null' was running on its
> own. Instead, we now test the command and accumulate warning messages in a
> single statement by chaining the command with a logical OR.

Applied, thanks!  :-)

Ludo'.




This bug report was last modified 7 years and 96 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.