GNU bug report logs - #31514
[PATCH 09/21] gnu: emacs-gif-screencast: New variable.

Previous Next

Full log

View this message in rfc822 format

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31514 <at> debbugs.gnu.org
Subject: [bug#31514] [PATCH 09/21] gnu: Add emacs-gif-screencast.
Date: Sat, 02 Jun 2018 18:53:24 +0200

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Pierre Neidhardt <ambrevar <at> gmail.com> skribis:
>
>> * gnu/packages/emacs.scm (emacs-gif-screencast): New variable.
>
> [...]
>
>> +  (package
>> +    (name "emacs-gif-screencast")
>> +    (version "20180309")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://github.com/Ambrevar/emacs-gif-screencast/archive/"
>> +             "825e606950ec842304bf75cf85baef707b853b03"
>> +             ".tar.gz"))
>
> Could you use the usual scheme for version numbers of Git snapshots
> (info "(guix) Version Numbers")?

I followed the form of emacs-zotxt that was just packaged.
emacs-gif-screencast, like many other Emacs packages, has no version
number.
Do you suggest something like

--8<---------------cut here---------------start------------->8---
(let ((commit ...))
  ; ...
	(gitversion "20180309" "1" commit)
--8<---------------cut here---------------end--------------->8---

?

>> +    (propagated-inputs
>> +     `(("scrot" ,scrot)
>> +       ("imagemagick" ,imagemagick)
>> +       ("gifsicle" ,gifsicle)))
>
> Instead of propagating these, which could “pollute” the user’s profile,
> could you hardcode the absolute file names of these programs in the .el
> files?  See how this is done for EMMS, for instance.

Ack.

-- 
Pierre Neidhardt

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.