GNU bug report logs - #31514
[PATCH 09/21] gnu: emacs-gif-screencast: New variable.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31514 in the body.
You can then email your comments to 31514 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 09/21] gnu: emacs-gif-screencast: New variable.
Date: Fri, 18 May 2018 20:49:05 +0200

* gnu/packages/emacs.scm (emacs-gif-screencast): New variable.
---
 gnu/packages/emacs.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 82f250f34..6fb11a0a3 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -10684,3 +10684,33 @@ The package @code{emacs-bash-completion} is an optional dependency: if available
 @code{fish-completion-complete} can be configured to fall back on bash to further
 try completing.  See @code{fish-completion-fallback-on-bash-p}.")
     (license license:gpl3+)))
+
+(define-public emacs-gif-screencast
+  (package
+    (name "emacs-gif-screencast")
+    (version "20180309.242")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://melpa.org/packages/gif-screencast-"
+             version
+             ".el"))
+       (sha256
+        (base32
+         "1xva240kx0w4x0x6cd42lyj87gi2i2s0fhpj3ca9klw9z5ffb55f"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("scrot" ,scrot)
+       ("imagemagick" ,imagemagick)
+       ;; ("gifsicle" ,gifsicle) ; TODO: Add gifsicle.
+       ))
+    (home-page
+     "https://github.com/ambrevar/emacs-gif-screencast")
+    (synopsis "One-frame-per-action GIF recording")
+    (description
+     "Call @code{gif-screencast} to start a recording.
+A screenshot is taken for every user action.  Call
+@code{gif-screencast-stop} (<f9> by default) to finish recording and create
+the GIF result.")
+    (license license:gpl3+)))
-- 
2.17.0

Message #8 received at 31514 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: 31514 <at> debbugs.gnu.org
Subject: [PATCH 09/21] gnu: Add emacs-gif-screencast.
Date: Fri,  1 Jun 2018 09:50:51 +0200

* gnu/packages/emacs.scm (emacs-gif-screencast): New variable.
---
 gnu/packages/emacs.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 303d0dcab..8484a31fe 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -10776,3 +10776,32 @@ The package @code{emacs-bash-completion} is an optional dependency: if available
 @code{fish-completion-complete} can be configured to fall back on bash to further
 try completing.  See @code{fish-completion-fallback-on-bash-p}.")
     (license license:gpl3+)))
+
+(define-public emacs-gif-screencast
+  (package
+    (name "emacs-gif-screencast")
+    (version "20180309")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/Ambrevar/emacs-gif-screencast/archive/"
+             "825e606950ec842304bf75cf85baef707b853b03"
+             ".tar.gz"))
+       (sha256
+        (base32
+         "1f83sdx4qj4g6byvbdq7aayissbcy5lqm43djp8h0lq455nf7jkc"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("scrot" ,scrot)
+       ("imagemagick" ,imagemagick)
+       ("gifsicle" ,gifsicle)))
+    (home-page
+     "https://github.com/Ambrevar/emacs-gif-screencast")
+    (synopsis "One-frame-per-action GIF recording")
+    (description
+     "Call @code{gif-screencast} to start a recording.
+A screenshot is taken for every user action.  Call
+@code{gif-screencast-stop} (<f9> by default) to finish recording and create
+the GIF result.")
+    (license license:gpl3+)))
-- 
2.17.0

Message #11 received at 31514 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31514 <at> debbugs.gnu.org
Subject: Re: [bug#31514] [PATCH 09/21] gnu: Add emacs-gif-screencast.
Date: Sat, 02 Jun 2018 16:02:21 +0200

Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> * gnu/packages/emacs.scm (emacs-gif-screencast): New variable.

[...]

> +  (package
> +    (name "emacs-gif-screencast")
> +    (version "20180309")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/Ambrevar/emacs-gif-screencast/archive/"
> +             "825e606950ec842304bf75cf85baef707b853b03"
> +             ".tar.gz"))

Could you use the usual scheme for version numbers of Git snapshots
(info "(guix) Version Numbers")?

> +    (propagated-inputs
> +     `(("scrot" ,scrot)
> +       ("imagemagick" ,imagemagick)
> +       ("gifsicle" ,gifsicle)))

Instead of propagating these, which could “pollute” the user’s profile,
could you hardcode the absolute file names of these programs in the .el
files?  See how this is done for EMMS, for instance.

> +    (home-page
> +     "https://github.com/Ambrevar/emacs-gif-screencast")
> +    (synopsis "One-frame-per-action GIF recording")

This looks very useful!

TIA!

Ludo’.

Message #14 received at 31514 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31514 <at> debbugs.gnu.org
Subject: Re: [bug#31514] [PATCH 09/21] gnu: Add emacs-gif-screencast.
Date: Sat, 02 Jun 2018 18:53:24 +0200

[Message part 1 (text/plain, inline)]

Ludovic Courtès <ludo <at> gnu.org> writes:

> Pierre Neidhardt <ambrevar <at> gmail.com> skribis:
>
>> * gnu/packages/emacs.scm (emacs-gif-screencast): New variable.
>
> [...]
>
>> +  (package
>> +    (name "emacs-gif-screencast")
>> +    (version "20180309")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://github.com/Ambrevar/emacs-gif-screencast/archive/"
>> +             "825e606950ec842304bf75cf85baef707b853b03"
>> +             ".tar.gz"))
>
> Could you use the usual scheme for version numbers of Git snapshots
> (info "(guix) Version Numbers")?

I followed the form of emacs-zotxt that was just packaged.
emacs-gif-screencast, like many other Emacs packages, has no version
number.
Do you suggest something like

--8<---------------cut here---------------start------------->8---
(let ((commit ...))
  ; ...
	(gitversion "20180309" "1" commit)
--8<---------------cut here---------------end--------------->8---

?

>> +    (propagated-inputs
>> +     `(("scrot" ,scrot)
>> +       ("imagemagick" ,imagemagick)
>> +       ("gifsicle" ,gifsicle)))
>
> Instead of propagating these, which could “pollute” the user’s profile,
> could you hardcode the absolute file names of these programs in the .el
> files?  See how this is done for EMMS, for instance.

Ack.

-- 
Pierre Neidhardt

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 31514 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31514 <at> debbugs.gnu.org
Subject: Re: [bug#31514] [PATCH 09/21] gnu: Add emacs-gif-screencast.
Date: Sat, 02 Jun 2018 22:41:25 +0200

Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>
>> Pierre Neidhardt <ambrevar <at> gmail.com> skribis:
>>
>>> * gnu/packages/emacs.scm (emacs-gif-screencast): New variable.
>>
>> [...]
>>
>>> +  (package
>>> +    (name "emacs-gif-screencast")
>>> +    (version "20180309")
>>> +    (source
>>> +     (origin
>>> +       (method url-fetch)
>>> +       (uri (string-append
>>> +             "https://github.com/Ambrevar/emacs-gif-screencast/archive/"
>>> +             "825e606950ec842304bf75cf85baef707b853b03"
>>> +             ".tar.gz"))
>>
>> Could you use the usual scheme for version numbers of Git snapshots
>> (info "(guix) Version Numbers")?
>
> I followed the form of emacs-zotxt that was just packaged.
> emacs-gif-screencast, like many other Emacs packages, has no version
> number.
> Do you suggest something like
>
> (let ((commit ...))
>   ; ...
> 	(gitversion "20180309" "1" commit)
>
> ?

Yes.  I think it’s useful to have the shortened commit ID in the version
string.

Thanks,
Ludo’.

Message #20 received at 31514 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: 31514 <at> debbugs.gnu.org
Subject: [PATCH 09/21] gnu: Add emacs-gif-screencast.
Date: Wed,  6 Jun 2018 11:38:42 +0200

* gnu/packages/emacs.scm (emacs-gif-screencast): New variable.
---
 gnu/packages/emacs.scm | 50 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 50 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 303d0dcab..601805a8e 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -10776,3 +10776,53 @@ The package @code{emacs-bash-completion} is an optional dependency: if available
 @code{fish-completion-complete} can be configured to fall back on bash to further
 try completing.  See @code{fish-completion-fallback-on-bash-p}.")
     (license license:gpl3+)))
+
+(define-public emacs-gif-screencast
+  (let ((commit "825e606950ec842304bf75cf85baef707b853b03"))
+    (package
+      (name "emacs-gif-screencast")
+      (version (git-version "20180309" "1" commit))
+      (source
+       (origin
+         (method url-fetch)
+         (uri (string-append
+               "https://github.com/Ambrevar/emacs-gif-screencast/archive/"
+               commit
+               ".tar.gz"))
+         (sha256
+          (base32
+           "1f83sdx4qj4g6byvbdq7aayissbcy5lqm43djp8h0lq455nf7jkc"))))
+      (build-system emacs-build-system)
+      (inputs
+       `(("scrot" ,scrot)
+         ("imagemagick" ,imagemagick)
+         ("gifsicle" ,gifsicle)))
+     (arguments
+      `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'configure
+           (lambda* (#:key inputs outputs #:allow-other-keys)
+             (let ((scrot (assoc-ref inputs "scrot"))
+                   (imagemagick (assoc-ref inputs "imagemagick"))
+                   (gifsicle (assoc-ref inputs "gifsicle")))
+               ;; Specify the absolute file names of the various
+               ;; programs so that everything works out-of-the-box.
+               (emacs-substitute-variables
+                   "gif-screencast.el"
+                 ("gif-screencast-program"
+                  (string-append scrot "/bin/scrot"))
+                 ("gif-screencast-convert-program"
+                  (string-append imagemagick "/bin/convert"))
+                 ("gif-screencast-cropping-program"
+                  (string-append imagemagick "/bin/mogrify"))
+                 ("gif-screencast-optimize-program"
+                  (string-append imagemagick "/bin/gifsicle")))))))))
+      (home-page
+       "https://github.com/Ambrevar/emacs-gif-screencast")
+      (synopsis "One-frame-per-action GIF recording")
+      (description
+       "Call @code{gif-screencast} to start a recording.
+A screenshot is taken for every user action.  Call
+@code{gif-screencast-stop} (<f9> by default) to finish recording and create
+the GIF result.")
+      (license license:gpl3+))))
-- 
2.17.0

Message #23 received at 31514 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 31514 <at> debbugs.gnu.org
Subject: Re: [bug#31514] [PATCH 09/21] gnu: Add emacs-gif-screencast.
Date: Wed, 06 Jun 2018 11:46:35 +0200

[Message part 1 (text/plain, inline)]

I've applied the changes to gif-screencast, helm-pass, helm-exwm, and
helm-mu.  Let me know if there is anything else.

--
Pierre Neidhardt

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 31514-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31514-done <at> debbugs.gnu.org
Subject: Re: [bug#31514] [PATCH 09/21] gnu: Add emacs-gif-screencast.
Date: Fri, 08 Jun 2018 16:40:40 +0200

Pierre Neidhardt <ambrevar <at> gmail.com> skribis:

> * gnu/packages/emacs.scm (emacs-gif-screencast): New variable.

Perfect.  Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.