GNU bug report logs - #31499
[PATCH 01/21] gnu: emacs-daemons: New variable.

Previous Next

Full log

Message #11 received at 31499 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 31499 <at> debbugs.gnu.org
Subject: Re: [bug#31499] [PATCH 01/21] gnu: emacs-daemons: New variable.
Date: Tue, 22 May 2018 10:19:33 +0200

[Message part 1 (text/plain, inline)]

Ricardo Wurmus <rekado <at> elephly.net> writes:

>> +       (uri (string-append "https://github.com/cbowdon/daemons.el/archive/"
>> +                           version ".tar.gz"))
>
> Please do not use these auto-generated tarballs from GitHub, as they are
> generated upon demand.  This means that at some point in the future the
> hash may change.

OK, but I have a few question:

- Why would the hash change?  If the version tag is not changed (and
it's not meant to) the archive remains the same, doesn't it?  Besides
many Emacs packages use the "/archive" URLs, such as
`emacs-emms-player-mpv`.

- Do you know the difference between "/archive and "/releases/download"?
For instance, Magit uses "https://github.com/magit/magit/releases/download/".

That said, I have no issue with using git-fetch instead.  I'll submit a
patch just now.

--
Pierre Neidhardt

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.