GNU bug report logs - #31499
[PATCH 01/21] gnu: emacs-daemons: New variable.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31499 in the body.
You can then email your comments to 31499 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 01/21] gnu: emacs-daemons: New variable.
Date: Fri, 18 May 2018 20:48:51 +0200

* gnu/packages/emacs.scm (emacs-daemons): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index f3d08e810..10bf4c355 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -10464,3 +10464,26 @@ Dumb Jump performs best with The Silver Searcher @command{ag} or ripgrep
        "This package provides an Emacs minor mode for highlighting
 device tree files.")
       (license license:gpl3+))))
+
+(define-public emacs-daemons
+  (package
+    (name "emacs-daemons")
+    (version "1.2.0")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/cbowdon/daemons.el/archive/"
+                           version ".tar.gz"))
+       (file-name (string-append name "-" version "-checkout"))
+       (sha256
+        (base32
+         "14ivawzxiy8q8x2ccpw05ng83zqd70cdkn287yrc2c9nm1ix98bf"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/cbowdon/daemons.el")
+    (synopsis "Emacs UI for managing init system services")
+    (description
+     "This is an Emacs mode to give you a UI for managing init system
+daemons (services) for those getting tired of typing out @code{sudo service
+my_thing reload} all the time.  It's offers a consistent UI over different
+init systems.")
+    (license license:gpl3+)))
-- 
2.17.0

Message #8 received at 31499 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31499 <at> debbugs.gnu.org
Subject: Re: [bug#31499] [PATCH 01/21] gnu: emacs-daemons: New variable.
Date: Mon, 21 May 2018 22:18:26 +0200

Hi Pierre,

> * gnu/packages/emacs.scm (emacs-daemons): New variable.
> ---
>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index f3d08e810..10bf4c355 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -10464,3 +10464,26 @@ Dumb Jump performs best with The Silver Searcher @command{ag} or ripgrep
>         "This package provides an Emacs minor mode for highlighting
>  device tree files.")
>        (license license:gpl3+))))
> +
> +(define-public emacs-daemons
> +  (package
> +    (name "emacs-daemons")
> +    (version "1.2.0")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/cbowdon/daemons.el/archive/"
> +                           version ".tar.gz"))

Please do not use these auto-generated tarballs from GitHub, as they are
generated upon demand.  This means that at some point in the future the
hash may change.  Use “git-fetch” instead.

> +       (file-name (string-append name "-" version "-checkout"))

If you’re using a tarball, then the name should not end on “-checkout”.

Thanks!

-- 
Ricardo

Message #11 received at 31499 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 31499 <at> debbugs.gnu.org
Subject: Re: [bug#31499] [PATCH 01/21] gnu: emacs-daemons: New variable.
Date: Tue, 22 May 2018 10:19:33 +0200

[Message part 1 (text/plain, inline)]

Ricardo Wurmus <rekado <at> elephly.net> writes:

>> +       (uri (string-append "https://github.com/cbowdon/daemons.el/archive/"
>> +                           version ".tar.gz"))
>
> Please do not use these auto-generated tarballs from GitHub, as they are
> generated upon demand.  This means that at some point in the future the
> hash may change.

OK, but I have a few question:

- Why would the hash change?  If the version tag is not changed (and
it's not meant to) the archive remains the same, doesn't it?  Besides
many Emacs packages use the "/archive" URLs, such as
`emacs-emms-player-mpv`.

- Do you know the difference between "/archive and "/releases/download"?
For instance, Magit uses "https://github.com/magit/magit/releases/download/".

That said, I have no issue with using git-fetch instead.  I'll submit a
patch just now.

--
Pierre Neidhardt

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 31499 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 31499 <at> debbugs.gnu.org
Subject: Re: [bug#31499] [PATCH 01/21] gnu: emacs-daemons: New variable.
Date: Tue, 22 May 2018 10:37:54 +0200

[Message part 1 (text/plain, inline)]

* gnu/packages/emacs.scm (emacs-daemons): New variable.
---
 gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index f3d08e810..24ab1ba6f 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -34,6 +34,7 @@
 ;;; Copyright © 2017, 2018 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2018 Sohom Bhattacharjee <soham.bhattacharjee15 <at> gmail.com>
 ;;; Copyright © 2018 Mathieu Lirzin <mthl <at> gnu.org>
+;;; Copyright © 2018 Pierre Neidhardt <ambrevar <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -10464,3 +10465,27 @@ Dumb Jump performs best with The Silver Searcher @command{ag} or ripgrep
        "This package provides an Emacs minor mode for highlighting
 device tree files.")
       (license license:gpl3+))))
+
+(define-public emacs-daemons
+  (package
+    (name "emacs-daemons")
+    (version "1.2.0")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/cbowdon/daemons.el")
+             (commit version)))
+       (file-name (string-append name "-" version "-checkout"))
+       (sha256
+        (base32
+         "00ijgm22ck76gw0x79krl05yy0m8a502yfakazfy5xhpn1zi6ab7"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/cbowdon/daemons.el")
+    (synopsis "Emacs UI for managing init system services")
+    (description
+     "This is an Emacs mode to give you a UI for managing init system
+daemons (services) for those getting tired of typing out @code{sudo service
+my_thing reload} all the time.  It's offers a consistent UI over different
+init systems.")
+    (license license:gpl3+)))
-- 
2.17.0

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 31499 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31499 <at> debbugs.gnu.org
Subject: Re: [bug#31499] [PATCH 01/21] gnu: emacs-daemons: New variable.
Date: Tue, 22 May 2018 11:17:49 +0200

Hi Pierre,

> Ricardo Wurmus <rekado <at> elephly.net> writes:
>
>>> +       (uri (string-append "https://github.com/cbowdon/daemons.el/archive/"
>>> +                           version ".tar.gz"))
>>
>> Please do not use these auto-generated tarballs from GitHub, as they are
>> generated upon demand.  This means that at some point in the future the
>> hash may change.
>
> OK, but I have a few question:
>
> - Why would the hash change?  If the version tag is not changed (and
> it's not meant to) the archive remains the same, doesn't it?  Besides
> many Emacs packages use the "/archive" URLs, such as
> `emacs-emms-player-mpv`.

Unfortunately, the archive does not remain the same.  These archives are
created on demand and cached for months.  Once they expire they are
recreated.  Since the archives contain timestamps the hash will change.

We still have many packages that use the /archive URLs, which should be
changed eventually.  I have been changing some of these URLs whenever I
updated one of the affected packages, but there are many more that
remain.

> - Do you know the difference between "/archive and "/releases/download"?
> For instance, Magit uses "https://github.com/magit/magit/releases/download/".

Releases are *uploaded* tarballs, not automatically generated tarballs.
Tarballs that have been uploaded to Github won’t change over time.

--
Ricardo

Message #20 received at 31499 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31499 <at> debbugs.gnu.org
Subject: Re: [bug#31499] [PATCH 01/21] gnu: emacs-daemons: New variable.
Date: Tue, 22 May 2018 12:10:35 +0200

Hi Pierre,

In your commit messages, could you replace

    gnu: something: New variable.

with

    gnu: Add something.

Please?

Thank you!
Clément

Message #23 received at 31499 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: 31499 <at> debbugs.gnu.org
Subject: Re: [bug#31499] [PATCH 01/21] gnu: emacs-daemons: New variable.
Date: Tue, 22 May 2018 12:18:39 +0200

[Message part 1 (text/plain, inline)]

Sure, I don't know why I started using this format... Did I see that in
a former commit?

Anyways, is it possible with `git send-email` to update all patches at
once by re-using their thread?

--
Pierre Neidhardt

[signature.asc (application/pgp-signature, inline)]

Message #28 received at 31499-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31499-done <at> debbugs.gnu.org
Subject: Re: [bug#31499] [PATCH 01/21] gnu: emacs-daemons: New variable.
Date: Tue, 22 May 2018 12:17:52 +0200

Hi Pierre,

> * gnu/packages/emacs.scm (emacs-daemons): New variable.

thanks for the updated patch.  I pushed it with commit
d0aedb5b1ff2087c92e9a189d2bb30541710871f after minor changes:

* Fixed a typo in the description.
* Changed the git commit summary to “gnu: Add emacs-daemons.”

Thanks!

-- 
Ricardo

Message #31 received at 31499 <at> debbugs.gnu.org (full text, mbox):

From: Pierre Neidhardt <ambrevar <at> gmail.com>
To: Clément Lassieur <clement <at> lassieur.org>
Cc: 31499 <at> debbugs.gnu.org
Subject: Re: [bug#31499] [PATCH 01/21] gnu: emacs-daemons: New variable.
Date: Tue, 22 May 2018 12:44:35 +0200

[Message part 1 (text/plain, inline)]

Pierre Neidhardt <ambrevar <at> gmail.com> writes:

> Sure, I don't know why I started using this format... Did I see that in
> a former commit?
>
> Anyways, is it possible with `git send-email` to update all patches at
> once by re-using their thread?

OK, I've figure it out:

> git send-email --in-reply-to "<20180518184910.9987-1-ambrevar <at> gmail.com>" 0001...

-- 
Pierre Neidhardt

[signature.asc (application/pgp-signature, inline)]

Message #34 received at 31499 <at> debbugs.gnu.org (full text, mbox):

From: Clément Lassieur <clement <at> lassieur.org>
To: Pierre Neidhardt <ambrevar <at> gmail.com>
Cc: 31499 <at> debbugs.gnu.org
Subject: Re: [bug#31499] [PATCH 01/21] gnu: emacs-daemons: New variable.
Date: Tue, 22 May 2018 14:58:32 +0200

Pierre Neidhardt <ambrevar <at> gmail.com> writes:

> Pierre Neidhardt <ambrevar <at> gmail.com> writes:
>
>> Sure, I don't know why I started using this format... Did I see that in
>> a former commit?

I think it's because you mixed up the first and second lines :-)

>> Anyways, is it possible with `git send-email` to update all patches at
>> once by re-using their thread?
>
> OK, I've figure it out:
>
>> git send-email --in-reply-to "<20180518184910.9987-1-ambrevar <at> gmail.com>" 0001...

Cool thank you!

Message #37 received at 31499 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: 31499 <at> debbugs.gnu.org, Pierre Neidhardt <ambrevar <at> gmail.com>
Subject: Re: [bug#31499] [PATCH 01/21] gnu: emacs-daemons: New variable.
Date: Thu, 24 May 2018 12:27:05 -0400

[Message part 1 (text/plain, inline)]

On Tue, May 22, 2018 at 11:17:49AM +0200, Ricardo Wurmus wrote:
> Unfortunately, the archive does not remain the same.  These archives are
> created on demand and cached for months.  Once they expire they are
> recreated.  Since the archives contain timestamps the hash will change.

They may also change when the tools used to create the archives by
GitHub are changed. This happened in autumn 2017 and broke many
downloads for many downstream projects. For now, GitHub doesn't
guarantee these snapshot archives are bit-reproducible and recommend
that we don't rely on them to be stable over time. They know that, in
practice, it's an issue.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.