GNU bug report logs - #31498
[PATCH] Notify systemd in daemon-initialized

Previous Next

Package: emacs;

Reported by: Lucas Werkmeister <mail <at> lucaswerkmeister.de>

Date: Fri, 18 May 2018 17:46:02 UTC

Severity: wishlist

Tags: fixed, patch

Merged with 31521

Fixed in version 27.1

Done: Noam Postavsky <npostavs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #37 received at 31498 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Lucas Werkmeister <mail <at> lucaswerkmeister.de>
Cc: 31498 <at> debbugs.gnu.org
Subject: Re: bug#31498: [PATCH] Notify systemd in daemon-initialized and
 kill-emacs
Date: Sat, 09 Jun 2018 08:36:02 -0400
Noam Postavsky <npostavs <at> gmail.com> writes:

> Lucas Werkmeister <mail <at> lucaswerkmeister.de> writes:
>
>> * etc/emacs.service: Update Type.
>> * src/emacs.c (daemon-initialized): Call sd_notify().
>> * src/emacs.c (kill-emacs): Call sd_notify().

Oops, hit send too early.  I wanted to add, that you don't need to
repeat the same message for the last two ChangeLog entries, and you
should use the "Conditional Changes" syntax [1], like so:

* src/emacs.c (daemon-initialized) [HAVE_LIBSYSTEMD]:
* src/emacs.c (kill-emacs) [HAVE_LIBSYSTEMD]: Call sd_notify().

[1]: https://www.gnu.org/prep/standards/html_node/Conditional-Changes.html

PS I was wrong about 'git send-email' being just as good as replying
with attachment.  The bug tracker adds a "bug#xxxxx:" prefix, so I end
up getting duplicate emails.  Next time someone asks I'll know what to
answer :)





This bug report was last modified 7 years and 29 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.