GNU bug report logs - #31333
[PATCH] Add groovy

Previous Next

Full log

Message #146 received at 31333 <at> debbugs.gnu.org (full text, mbox):

From: Björn Höfling <bjoern.hoefling <at> bjoernhoefling.de>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 31333 <at> debbugs.gnu.org
Subject: Re: [bug#31333] [PATCH 01/22] gnu: Add groovy-java-bootstrap.
Date: Mon, 7 May 2018 21:25:03 +0200

[Message part 1 (text/plain, inline)]

On Tue,  1 May 2018 17:44:28 +0200
Julien Lepiller <julien <at> lepiller.eu> wrote:

[..]

> diff --git a/gnu/packages/groovy.scm b/gnu/packages/groovy.scm new
> file mode 100644 index 000000000..ee2894e30
> --- /dev/null
> +++ b/gnu/packages/groovy.scm

[..]

> +(define groovy-java-bootstrap
> +  (package
> +    (name "groovy-java-bootstrap")

I would suggest "java-groovy-bootstrap", because it is the
groovy-bootstrap, written in Java. Convention for programs in language
x is to prefix the name with "x-".


> +    (version "2.4.15")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> "https://github.com/apache/groovy/archive/GROOVY_"
> +                                  (string-map (lambda (x) (if (eq? x
> #\.) #\_ x)) version)
> +                                  ".tar.gz"))

Snippet missing:

              (snippet
               '(begin
                  (delete-file-recursively
              "gradle/wrapper/gradle-wrapper.jar") #t))

I tried it out, it still builds the whole series until groovy.


Otherwise, LGTM.

Björn

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.