GNU bug report logs - #31334
[PATCH] gnome: add ghex

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31334 in the body.
You can then email your comments to 31334 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "Jovany Leandro G.C" <bit4bit <at> riseup.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnome: add ghex
Date: Tue, 1 May 2018 09:53:55 -0500

From 476080edc1a77de4380b3c08d3d82b6d06b5107b Mon Sep 17 00:00:00 2001
From: "Jovany Leandro G.C" <bit4bit <at> riseup.net>
Date: Tue, 1 May 2018 09:50:57 -0500
Subject: [PATCH] gnome: add ghex

---
 gnu/packages/gnome.scm | 44 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm
index beaf9aa8f..83cb23b46 100644
--- a/gnu/packages/gnome.scm
+++ b/gnu/packages/gnome.scm
@@ -7259,3 +7259,47 @@ mp3, Ogg Vorbis and FLAC")
  you to take micro-pauses, rest breaks and restricts you to your daily limit")
       (home-page "http://www.workrave.org")
       (license gpl3+))))
+
+(define-public ghex
+  (let ((commit "6615481532da7d378ef79b0f498ecc43dd0e1d40"))
+    (package
+      (name "ghex")
+      (version "3.18.3")
+      (source (origin
+                (method git-fetch)
+                (uri (git-reference
+                      (url "git://git.gnome.org/ghex")
+                      (commit commit)))
+                (file-name (git-file-name name version))
+                (sha256
+                 (base32
+                  "1j0sp9wsrx9d4qfisqzjsgvsfhc3q0zp6211kjx7y2kiv9vi8s2v"))))
+      (build-system glib-or-gtk-build-system)
+      (arguments
+       `(#:phases (modify-phases %standard-phases
+                    (add-after 'unpack 'autogen
+                      (lambda _
+                        (setenv "NOCONFIGURE" "1")
+                        (zero? (system* "sh" "autogen.sh"))))
+                    (replace 'check
+                      (lambda _ #t)))))
+      (native-inputs
+       `(("pkg-config" ,pkg-config)
+         ("gnome-common" ,gnome-common)
+         ("which" ,which)
+         ("automake" ,automake)
+         ("libtool" ,libtool)
+         ("autoconf" ,autoconf-wrapper)
+         ("intltool" ,intltool)
+         ("yelp-tools" ,yelp-tools)
+         ("gettext" ,gettext-minimal)
+         ("file" ,file)))
+      (inputs
+       `(("atk" ,atk)
+         ("gtk" ,gtk+)))
+      (synopsis "GNOME Hex editor for files")
+      (description "GNOME Hex editor for files
+ The GHex program can view and edit files in two ways, hex or ascii.  Good
+ for editing saved game files.")
+      (home-page "https://wiki.gnome.org/Apps/Ghex")
+      (license license:gpl2))))
-- 
2.17.0

Message #10 received at 31334-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: "Jovany Leandro G.C" <bit4bit <at> riseup.net>
Cc: 31334-done <at> debbugs.gnu.org
Subject: Re: [bug#31334] [PATCH] gnome: add ghex
Date: Sat, 05 May 2018 22:54:40 +0200

Hi Jovany,

"Jovany Leandro G.C" <bit4bit <at> riseup.net> skribis:

> From 476080edc1a77de4380b3c08d3d82b6d06b5107b Mon Sep 17 00:00:00 2001
> From: "Jovany Leandro G.C" <bit4bit <at> riseup.net>
> Date: Tue, 1 May 2018 09:50:57 -0500
> Subject: [PATCH] gnome: add ghex
>
> ---
>  gnu/packages/gnome.scm | 44 ++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 44 insertions(+)

I ended up modifying the package definition more than I was hoping for
;-) and I just pushed it:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=312afa7d563302da41ca7be862c7ce2e00acc7b5

Essentially I changed it to use a tarball from gnome.org instead of a
Git commit, which in turn meant we could remove the dependency on
Autoconf & co., added a missing input that allows “make check” to pass,
an adjusted the synopsis/description.

Thank you,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.