GNU bug report logs - #31244
[PATCH] ffmpeg 4.0 update patch series

Previous Next

Full log

Message #8 received at 31244 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Rutger Helling <rhelling <at> mykolab.com>
Cc: 31244 <at> debbugs.gnu.org
Subject: Re: [bug#31244] [PATCH] ffmpeg 4.0 update patch series
Date: Mon, 23 Apr 2018 15:08:23 +0200

Hello Rutger,

Rutger Helling <rhelling <at> mykolab.com> skribis:

> this patch series updates ffmpeg to 4.0. Since I found that a few
> packages fail to build with ffmpeg 4.0 I've also added ffmpeg <at> 3.4 for
> compatibility.
>
> Furthermore I've removed ffmpeg-git and changed mpv to build with
> ffmpeg 4.0 instead.

This all looks good to me, but I have one request: could you squash all
the changes, except perhaps the one removing ‘ffmpeg-git’?

The rationale is that each commit should leave the repo in a “good”
state, which would not be the case if we first install the patch that
upgrades ffmpeg and only then apply the ffmpeg → ffmpeg-3.4 changes.

I hope that’s fine with you.

Thanks for working on it!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.