GNU bug report logs - #31244
[PATCH] ffmpeg 4.0 update patch series

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31244 in the body.
You can then email your comments to 31244 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rutger Helling <rhelling <at> mykolab.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] ffmpeg 4.0 update patch series
Date: Mon, 23 Apr 2018 09:28:12 +0200

[Message part 1 (text/plain, inline)]

Hey Guix,

this patch series updates ffmpeg to 4.0. Since I found that a few
packages fail to build with ffmpeg 4.0 I've also added ffmpeg <at> 3.4 for
compatibility.

Furthermore I've removed ffmpeg-git and changed mpv to build with
ffmpeg 4.0 instead.

[0001-gnu-ffmpeg-Update-to-4.0.patch (text/x-patch, attachment)]

[0002-gnu-Add-ffmpeg-3.4.patch (text/x-patch, attachment)]

[0003-gnu-Remove-ffmpeg-git.patch (text/x-patch, attachment)]

[0004-gnu-mpv-Build-with-ffmpeg-instead-of-ffmpeg-git.patch (text/x-patch, attachment)]

[0005-gnu-gst-libav-Build-with-ffmpeg-3.4.patch (text/x-patch, attachment)]

[0006-gnu-qtox-Build-with-ffmpeg-3.4.patch (text/x-patch, attachment)]

[0007-gnu-dolphin-emu-Build-with-ffmpeg-3.4.patch (text/x-patch, attachment)]

[0008-gnu-libextractor-Build-with-ffmpeg-3.4.patch (text/x-patch, attachment)]

[Message part 10 (application/pgp-signature, inline)]

Message #8 received at 31244 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Rutger Helling <rhelling <at> mykolab.com>
Cc: 31244 <at> debbugs.gnu.org
Subject: Re: [bug#31244] [PATCH] ffmpeg 4.0 update patch series
Date: Mon, 23 Apr 2018 15:08:23 +0200

Hello Rutger,

Rutger Helling <rhelling <at> mykolab.com> skribis:

> this patch series updates ffmpeg to 4.0. Since I found that a few
> packages fail to build with ffmpeg 4.0 I've also added ffmpeg <at> 3.4 for
> compatibility.
>
> Furthermore I've removed ffmpeg-git and changed mpv to build with
> ffmpeg 4.0 instead.

This all looks good to me, but I have one request: could you squash all
the changes, except perhaps the one removing ‘ffmpeg-git’?

The rationale is that each commit should leave the repo in a “good”
state, which would not be the case if we first install the patch that
upgrades ffmpeg and only then apply the ffmpeg → ffmpeg-3.4 changes.

I hope that’s fine with you.

Thanks for working on it!

Ludo’.

Message #13 received at 31244-done <at> debbugs.gnu.org (full text, mbox):

From: Rutger Helling <rhelling <at> mykolab.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: 31244-done <at> debbugs.gnu.org
Subject: Re: [bug#31244] [PATCH] ffmpeg 4.0 update patch series
Date: Mon, 23 Apr 2018 15:54:01 +0200

[Message part 1 (text/plain, inline)]

Thanks for the review and explanation! I've squashed the commits and
pushed.

On Mon, 23 Apr 2018 15:08:23 +0200
ludo <at> gnu.org (Ludovic Courtès) wrote:

> Hello Rutger,
> 
> Rutger Helling <rhelling <at> mykolab.com> skribis:
> 
> > this patch series updates ffmpeg to 4.0. Since I found that a few
> > packages fail to build with ffmpeg 4.0 I've also added ffmpeg <at> 3.4
> > for compatibility.
> >
> > Furthermore I've removed ffmpeg-git and changed mpv to build with
> > ffmpeg 4.0 instead.  
> 
> This all looks good to me, but I have one request: could you squash
> all the changes, except perhaps the one removing ‘ffmpeg-git’?
> 
> The rationale is that each commit should leave the repo in a “good”
> state, which would not be the case if we first install the patch that
> upgrades ffmpeg and only then apply the ffmpeg → ffmpeg-3.4 changes.
> 
> I hope that’s fine with you.
> 
> Thanks for working on it!
> 
> Ludo’.

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.