GNU bug report logs - #31223
25.3; New menus are empty with GTK3

Previous Next

Full log

Message #73 received at 31223 <at> debbugs.gnu.org (full text, mbox):

From: Robert Pluim <rpluim <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 31223 <at> debbugs.gnu.org, tbading <at> web.de
Subject: Re: bug#31223: [PATCH] Fix empty/incorrect GTK menus on HiDPI
 monitors with window scaling factor > 1
Date: Tue, 07 Jan 2020 17:31:19 +0100

>>>>> On Tue, 07 Jan 2020 18:22:22 +0200, Eli Zaretskii <eliz <at> gnu.org> said:

    >> From: Robert Pluim <rpluim <at> gmail.com>
    >> Cc: 31223 <at> debbugs.gnu.org,  tbading <at> web.de
    >> Date: Tue, 07 Jan 2020 17:15:04 +0100
    >> 
    >> >>>>> On Tue, 17 Dec 2019 15:43:50 +0100, Robert Pluim <rpluim <at> gmail.com> said:
    Robert> diff --git a/src/xfns.c b/src/xfns.c
    Robert> index 47aa19607f..51a46bd6db 100644
    Robert> --- a/src/xfns.c
    Robert> +++ b/src/xfns.c
    Robert> @@ -5091,6 +5091,8 @@ DEFUN ("x-display-monitor-attributes-list", Fx_display_monitor_attributes_list,
    Robert> #elif defined HAVE_GTK3
    Robert> scale = gdk_screen_get_monitor_scale_factor (gscreen, i);
    Robert> #endif
    Robert> +      rec.x *= scale;
    Robert> +      rec.y *= scale;
    Robert> rec.width *= scale;
    Robert> rec.height *= scale;
    Robert> work.x *= scale;
    >> 
    >> Eli, is this OK for emacs-27? It will only affect
    >> display-monitor-attributes-list for people using GTK on multiple
    >> monitors where one is HiDPI.

    Eli> Yes, please push to emacs-27, and thanks.

Done. Closing.

Robert

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.