GNU bug report logs - #31173
[PATCH] gnu: Add python-onetimepass.

Previous Next

Full log

Message #8 received at 31173 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Tomáš Čech <sleep_walker <at> gnu.org>,
 31173 <at> debbugs.gnu.org
Subject: Re: [bug#31173] [PATCH] gnu: Add python-onetimepass.
Date: Tue, 17 Apr 2018 00:47:59 +0200

[Message part 1 (text/plain, inline)]

Tomáš Čech <sleep_walker <at> gnu.org> writes:

> * gnu/packages/python.scm (python-onetimepass): New variable.

[...]

> +(define-public python-onetimepass
> +  (package
> +    (name "python-onetimepass")

Please check the indentation of this package.  Use
'./etc/indent-code.el' if you're not an emacs user.

> +    (version "1.0.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "onetimepass" version))
> +       (sha256
> +        (base32
> +         "09vagxgbq78wvq4xbikmn2hpqqsa2i96kqsmphf7dqynfv0dlsd5"))))
> +    (build-system python-build-system)
> +    (inputs
> +       `(("python-six" ,python-six)))

Should this not be a propagated input?

> +    (home-page "https://github.com/tadeck/onetimepass/")
> +    (synopsis "Python one-time password library")

Maybe s/Python// even.

> +    (description "Pyhton one-time password library for HMAC-based (HOTP) and
                      ^^^ typo (importo?)
> +time-based (TOTP) passwords.")

Please also turn this into a complete sentence.  "@code{onetimepass} is
a Python library for...".  Bonus points if you can mention use-cases and
in general expand on it :-)

> +    (license license:x11)))

I believe this is "expat".

Otherwise LGTM.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.