GNU bug report logs - #31173
[PATCH] gnu: Add python-onetimepass.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31173 in the body.
You can then email your comments to 31173 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Tomáš Čech <sleep_walker <at> gnu.org>
Subject: [PATCH] gnu: Add python-onetimepass.
Date: Mon, 16 Apr 2018 11:05:52 +0200

* gnu/packages/python.scm (python-onetimepass): New variable.
---
 gnu/packages/python.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index e5b74a57f..aedd30566 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2018 Vijayalakshmi Vedantham <vijimay12 <at> gmail.com>
 ;;; Copyright © 2018 Mathieu Lirzin <mthl <at> gnu.org>
 ;;; Copyright © 2018 Adam Massmann <massmannak <at> gmail.com>
+;;; Copyright © 2016, 2018 Tomáš Čech <sleep_walker <at> gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -13127,3 +13128,23 @@ file system events on Linux.")
     (description "Pybtex is a BibTeX-compatible bibliography processor written
 in Python.  You can simply type pybtex instead of bibtex.")
     (license license:expat)))
+
+(define-public python-onetimepass
+  (package
+    (name "python-onetimepass")
+    (version "1.0.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "onetimepass" version))
+       (sha256
+        (base32
+         "09vagxgbq78wvq4xbikmn2hpqqsa2i96kqsmphf7dqynfv0dlsd5"))))
+    (build-system python-build-system)
+    (inputs
+       `(("python-six" ,python-six)))
+    (home-page "https://github.com/tadeck/onetimepass/")
+    (synopsis "Python one-time password library")
+    (description "Pyhton one-time password library for HMAC-based (HOTP) and
+time-based (TOTP) passwords.")
+    (license license:x11)))
-- 
2.16.3

Message #8 received at 31173 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Tomáš Čech <sleep_walker <at> gnu.org>,
 31173 <at> debbugs.gnu.org
Subject: Re: [bug#31173] [PATCH] gnu: Add python-onetimepass.
Date: Tue, 17 Apr 2018 00:47:59 +0200

[Message part 1 (text/plain, inline)]

Tomáš Čech <sleep_walker <at> gnu.org> writes:

> * gnu/packages/python.scm (python-onetimepass): New variable.

[...]

> +(define-public python-onetimepass
> +  (package
> +    (name "python-onetimepass")

Please check the indentation of this package.  Use
'./etc/indent-code.el' if you're not an emacs user.

> +    (version "1.0.1")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (pypi-uri "onetimepass" version))
> +       (sha256
> +        (base32
> +         "09vagxgbq78wvq4xbikmn2hpqqsa2i96kqsmphf7dqynfv0dlsd5"))))
> +    (build-system python-build-system)
> +    (inputs
> +       `(("python-six" ,python-six)))

Should this not be a propagated input?

> +    (home-page "https://github.com/tadeck/onetimepass/")
> +    (synopsis "Python one-time password library")

Maybe s/Python// even.

> +    (description "Pyhton one-time password library for HMAC-based (HOTP) and
                      ^^^ typo (importo?)
> +time-based (TOTP) passwords.")

Please also turn this into a complete sentence.  "@code{onetimepass} is
a Python library for...".  Bonus points if you can mention use-cases and
in general expand on it :-)

> +    (license license:x11)))

I believe this is "expat".

Otherwise LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 31173-done <at> debbugs.gnu.org (full text, mbox):

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 31173-done <at> debbugs.gnu.org
Subject: Re: [bug#31173] [PATCH] gnu: Add python-onetimepass.
Date: Sat, 21 Apr 2018 08:36:20 +0200

[Message part 1 (text/plain, inline)]

On Tue, Apr 17, 2018 at 12:47:59AM +0200, Marius Bakke wrote:
>Tomáš Čech <sleep_walker <at> gnu.org> writes:
>
>> * gnu/packages/python.scm (python-onetimepass): New variable.
>
>[...]
>
>> +(define-public python-onetimepass
>> +  (package
>> +    (name "python-onetimepass")
>
>Please check the indentation of this package.  Use
>'./etc/indent-code.el' if you're not an emacs user.

as with other patches I sent - I run it through and result is
unchanged. But I'll be careful about that, thanks!

>> +    (version "1.0.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "onetimepass" version))
>> +       (sha256
>> +        (base32
>> +         "09vagxgbq78wvq4xbikmn2hpqqsa2i96kqsmphf7dqynfv0dlsd5"))))
>> +    (build-system python-build-system)
>> +    (inputs
>> +       `(("python-six" ,python-six)))
>
>Should this not be a propagated input?

It didn't seem so.

>> +    (home-page "https://github.com/tadeck/onetimepass/")
>> +    (synopsis "Python one-time password library")
>
>Maybe s/Python// even.

Fixed.

>> +    (description "Pyhton one-time password library for HMAC-based (HOTP) and
>                      ^^^ typo (importo?)

Fixed.

>> +time-based (TOTP) passwords.")
>
>Please also turn this into a complete sentence.  "@code{onetimepass} is
>a Python library for...".  Bonus points if you can mention use-cases and
>in general expand on it :-)
>
>> +    (license license:x11)))
>
>I believe this is "expat".

Fixed.

>Otherwise LGTM.

Pushed.

Thank you for your review!

Best regards,

S_W

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 31173 <at> debbugs.gnu.org (full text, mbox):

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 31173 <at> debbugs.gnu.org
Subject: Re: [bug#31173] [PATCH] gnu: Add python-onetimepass.
Date: Sat, 21 Apr 2018 16:26:56 +0200

[Message part 1 (text/plain, inline)]

On Tue, Apr 17, 2018 at 12:47:59AM +0200, Marius Bakke wrote:
>Tomáš Čech <sleep_walker <at> gnu.org> writes:
>
>> * gnu/packages/python.scm (python-onetimepass): New variable.
>
>[...]
>
>> +(define-public python-onetimepass
>> +  (package
>> +    (name "python-onetimepass")
>
>Please check the indentation of this package.  Use
>'./etc/indent-code.el' if you're not an emacs user.
>
>> +    (version "1.0.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "onetimepass" version))
>> +       (sha256
>> +        (base32
>> +         "09vagxgbq78wvq4xbikmn2hpqqsa2i96kqsmphf7dqynfv0dlsd5"))))
>> +    (build-system python-build-system)
>> +    (inputs
>> +       `(("python-six" ,python-six)))
>
>Should this not be a propagated input?

After pushing and installing I got error on this - you were right in
the end. It seems that my testing environment wasn't isolated or
something.

I'll push fix for that.

Best regards,

S_W

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.