GNU bug report logs - #31173
[PATCH] gnu: Add python-onetimepass.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Tomáš Čech <sleep_walker <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#31173: closed ([PATCH] gnu: Add python-onetimepass.)
Date: Sat, 21 Apr 2018 06:37:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 21 Apr 2018 08:36:20 +0200
with message-id <20180421063620.GA1534 <at> doom>
and subject line Re: [bug#31173] [PATCH] gnu: Add python-onetimepass.
has caused the debbugs.gnu.org bug report #31173,
regarding [PATCH] gnu: Add python-onetimepass.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
31173: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=31173
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: guix-patches <at> gnu.org
Cc: Tomáš Čech <sleep_walker <at> gnu.org>
Subject: [PATCH] gnu: Add python-onetimepass.
Date: Mon, 16 Apr 2018 11:05:52 +0200

* gnu/packages/python.scm (python-onetimepass): New variable.
---
 gnu/packages/python.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index e5b74a57f..aedd30566 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -50,6 +50,7 @@
 ;;; Copyright © 2018 Vijayalakshmi Vedantham <vijimay12 <at> gmail.com>
 ;;; Copyright © 2018 Mathieu Lirzin <mthl <at> gnu.org>
 ;;; Copyright © 2018 Adam Massmann <massmannak <at> gmail.com>
+;;; Copyright © 2016, 2018 Tomáš Čech <sleep_walker <at> gnu.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -13127,3 +13128,23 @@ file system events on Linux.")
     (description "Pybtex is a BibTeX-compatible bibliography processor written
 in Python.  You can simply type pybtex instead of bibtex.")
     (license license:expat)))
+
+(define-public python-onetimepass
+  (package
+    (name "python-onetimepass")
+    (version "1.0.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (pypi-uri "onetimepass" version))
+       (sha256
+        (base32
+         "09vagxgbq78wvq4xbikmn2hpqqsa2i96kqsmphf7dqynfv0dlsd5"))))
+    (build-system python-build-system)
+    (inputs
+       `(("python-six" ,python-six)))
+    (home-page "https://github.com/tadeck/onetimepass/")
+    (synopsis "Python one-time password library")
+    (description "Pyhton one-time password library for HMAC-based (HOTP) and
+time-based (TOTP) passwords.")
+    (license license:x11)))
-- 
2.16.3

[Message part 3 (message/rfc822, inline)]

From: Tomáš Čech <sleep_walker <at> gnu.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 31173-done <at> debbugs.gnu.org
Subject: Re: [bug#31173] [PATCH] gnu: Add python-onetimepass.
Date: Sat, 21 Apr 2018 08:36:20 +0200

[Message part 4 (text/plain, inline)]

On Tue, Apr 17, 2018 at 12:47:59AM +0200, Marius Bakke wrote:
>Tomáš Čech <sleep_walker <at> gnu.org> writes:
>
>> * gnu/packages/python.scm (python-onetimepass): New variable.
>
>[...]
>
>> +(define-public python-onetimepass
>> +  (package
>> +    (name "python-onetimepass")
>
>Please check the indentation of this package.  Use
>'./etc/indent-code.el' if you're not an emacs user.

as with other patches I sent - I run it through and result is
unchanged. But I'll be careful about that, thanks!

>> +    (version "1.0.1")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (pypi-uri "onetimepass" version))
>> +       (sha256
>> +        (base32
>> +         "09vagxgbq78wvq4xbikmn2hpqqsa2i96kqsmphf7dqynfv0dlsd5"))))
>> +    (build-system python-build-system)
>> +    (inputs
>> +       `(("python-six" ,python-six)))
>
>Should this not be a propagated input?

It didn't seem so.

>> +    (home-page "https://github.com/tadeck/onetimepass/")
>> +    (synopsis "Python one-time password library")
>
>Maybe s/Python// even.

Fixed.

>> +    (description "Pyhton one-time password library for HMAC-based (HOTP) and
>                      ^^^ typo (importo?)

Fixed.

>> +time-based (TOTP) passwords.")
>
>Please also turn this into a complete sentence.  "@code{onetimepass} is
>a Python library for...".  Bonus points if you can mention use-cases and
>in general expand on it :-)
>
>> +    (license license:x11)))
>
>I believe this is "expat".

Fixed.

>Otherwise LGTM.

Pushed.

Thank you for your review!

Best regards,

S_W

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.