GNU bug report logs - #31153
[PATCH] gnu: nestopia-ue: Update to 1.48.

Previous Next

Full log

Message #11 received at 31153 <at> debbugs.gnu.org (full text, mbox):

From: Kei Kebreau <kkebreau <at> posteo.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 31153 <at> debbugs.gnu.org
Subject: Re: [bug#31153] [PATCH] gnu: nestopia-ue: Update to 1.48.
Date: Mon, 16 Apr 2018 23:32:23 -0400

[Message part 1 (text/plain, inline)]

Marius Bakke <mbakke <at> fastmail.com> writes:

> Kei Kebreau <kkebreau <at> posteo.net> writes:
>
>> * gnu/packages/emulators.scm (nestopia-ue): Update to 1.48.
>> [source]: Simplify snippet.
>> [build-system]: Switch to cmake-build-system.
>> [inputs]: Remove glu and mesa. Add libepoxy.
>> [arguments]: Remove modified phases.
>
> [...]
>
>>                (modules '((guix build utils)))
>>                (snippet
>>                 '(begin
>>                    ;; We don't need libretro for the GNU/Linux build.
>> -                  (delete-file-recursively "libretro")
>> -                  ;; Use system zlib.
>> -                  (delete-file-recursively "source/zlib")
>> -                  (substitute* "source/core/NstZlib.cpp"
>> -                    (("#include \"../zlib/zlib.h\"") "#include <zlib.h>"))))))
>> -    (build-system gnu-build-system)
>> +                  (delete-file-recursively "libretro")))))
>> +    (build-system cmake-build-system)
>
> The commit message says 'simplify snippet', but the actual change is to
> not delete the zlib subfolder.  Is zlib no longer bundled?  If so,
> please mention that in the commit message.
>
> Apart from that LGTM.

Thank you for reviewing this!

I've attached a revised patch with some other small but necessary
changes that I overlooked the first time around. If the patch below
looks good, then I will push it to master.

[0001-gnu-nestopia-ue-Update-to-1.48.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.