GNU bug report logs - #31152
[PATCH 0/4] Bootstrap java-jarjar.

Previous Next

Package: guix-patches;

Reported by: Gábor Boskovits <boskovits <at> gmail.com>

Date: Sat, 14 Apr 2018 13:52:01 UTC

Severity: normal

Tags: patch

Done: Julien Lepiller <julien <at> lepiller.eu>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31152 in the body.
You can then email your comments to 31152 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#31152; Package guix-patches. (Sat, 14 Apr 2018 13:52:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Gábor Boskovits <boskovits <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 14 Apr 2018 13:52:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Gábor Boskovits <boskovits <at> gmail.com>
Subject: [PATCH 0/4] Bootstrap java-jarjar.
Date: Sat, 14 Apr 2018 15:50:39 +0200
*** BLURB HERE ***

This patch series introduces the packages required to remove the
bundled asm from jarjar. This is encouraged by current policy
and needed by switching to java8, as the bundled asm version
is too old.

Gábor Boskovits (4):
  gnu: Add java-slfj4-api-bootstrap.
  gnu: Add java-aqute-libg-bootstrap.
  gnu: Add java-aqute-bndlib-bootstrap.
  gnu: Add java-asm-bootstrap.

 gnu/packages/java.scm | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)

-- 
2.16.2





Information forwarded to guix-patches <at> gnu.org:
bug#31152; Package guix-patches. (Sat, 14 Apr 2018 19:06:01 GMT) Full text and rfc822 format available.

Message #8 received at 31152 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: 31152 <at> debbugs.gnu.org
Cc: Gábor Boskovits <boskovits <at> gmail.com>
Subject: [PATCH 1/4] gnu: Add java-slfj4-api-bootstrap.
Date: Sat, 14 Apr 2018 21:04:29 +0200
    * gnu/packages/java.scm (java-slf4j-api-bootstrap): New variable.
---
 gnu/packages/java.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index be252cd2a..de9313c36 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -5640,6 +5640,15 @@ allowing the end user to plug in the desired logging framework at deployment
 time.")
     (license license:expat)))
 
+(define-public java-slf4j-api-bootstrap
+  (package
+    (inherit java-slf4j-api)
+    (name "java-slf4j-api-bootstrap")
+    (inputs `())
+    (arguments
+     (substitute-keyword-arguments (package-arguments java-slf4j-api)
+       ((#:tests? _ #f) #f)))))
+
 (define-public java-slf4j-simple
   (package
     (name "java-slf4j-simple")
-- 
2.16.2





Information forwarded to guix-patches <at> gnu.org:
bug#31152; Package guix-patches. (Sat, 14 Apr 2018 20:35:02 GMT) Full text and rfc822 format available.

Message #11 received at 31152 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: 31152 <at> debbugs.gnu.org
Cc: Gábor Boskovits <boskovits <at> gmail.com>
Subject: [PATCH 2/4] gnu: Add java-aqute-libg-bootstrap.
Date: Sat, 14 Apr 2018 22:33:31 +0200
* gnu/packages/java.scm (java-aqute-libg-bootstrap): New variable.
---
 gnu/packages/java.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index de9313c36..f9174b87a 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -6890,6 +6890,15 @@ it manages project dependencies, gives diffs jars, and much more.")
        ("java-osgi-cmpn" ,java-osgi-cmpn)
        ("osgi" ,java-osgi-core)))))
 
+(define-public java-aqute-libg-bootstrap
+  (package
+    (inherit java-aqute-libg)
+    (name "java-aqute-libg-bootstrap")
+    (inputs
+     `(("slf4j-bootstrap" ,java-slf4j-api-bootstrap)
+       ,@(delete `("slf4j" ,java-slf4j-api)
+                 (package-inputs java-aqute-libg))))))
+
 (define-public java-aqute-bndlib
   (package
     (inherit java-aqute-bnd-annotation)
-- 
2.16.2





Information forwarded to guix-patches <at> gnu.org:
bug#31152; Package guix-patches. (Sat, 14 Apr 2018 20:35:02 GMT) Full text and rfc822 format available.

Message #14 received at 31152 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: 31152 <at> debbugs.gnu.org
Cc: Gábor Boskovits <boskovits <at> gmail.com>
Subject: [PATCH 3/4] gnu: Add java-aqute-bndlib-bootstrap.
Date: Sat, 14 Apr 2018 22:33:32 +0200
* gnu/packages/java.scm (java-aqute-bndlib-bootstrap): New variable.
---
 gnu/packages/java.scm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index f9174b87a..95a1dc0f2 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -6922,6 +6922,17 @@ it manages project dependencies, gives diffs jars, and much more.")
        ("promise" ,java-osgi-util-promise)
        ("osgi" ,java-osgi-core)))))
 
+(define-public java-aqute-bndlib-bootstrap
+  (package
+    (inherit java-aqute-bndlib)
+    (name "java-aqute-bndlib-bootstrap")
+    (inputs
+     `(("slf4j-bootstrap" ,java-slf4j-api-bootstrap)
+       ("java-aqute-libg-bootstrap" ,java-aqute-libg-bootstrap)
+       ,@(delete `("slf4j" ,java-slf4j-api)
+                 (delete `("java-aqute-libg" ,java-aqute-libg)
+                         (package-inputs java-aqute-bndlib)))))))
+
 (define-public java-ops4j-pax-tinybundles
   (package
     (name "java-ops4j-pax-tinybundles")
-- 
2.16.2





Information forwarded to guix-patches <at> gnu.org:
bug#31152; Package guix-patches. (Sat, 14 Apr 2018 20:35:03 GMT) Full text and rfc822 format available.

Message #17 received at 31152 <at> debbugs.gnu.org (full text, mbox):

From: Gábor Boskovits <boskovits <at> gmail.com>
To: 31152 <at> debbugs.gnu.org
Cc: Gábor Boskovits <boskovits <at> gmail.com>
Subject: [PATCH 4/4] gnu: Add java-asm-bootstrap.
Date: Sat, 14 Apr 2018 22:33:33 +0200
* gnu/packages/java.scm (java-asm-bootstrap): New variable.
---
 gnu/packages/java.scm | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm
index 95a1dc0f2..ee6a07af4 100644
--- a/gnu/packages/java.scm
+++ b/gnu/packages/java.scm
@@ -3526,6 +3526,21 @@ transformations and analysis algorithms allow to easily assemble custom
 complex transformations and code analysis tools.")
     (license license:bsd-3)))
 
+(define-public java-asm-bootstrap
+  (package
+    (inherit java-asm)
+    (name "java-asm-bootstrap")
+    (arguments
+     (substitute-keyword-arguments (package-arguments java-asm)
+       ((#:tests? _) #f)))
+    (native-inputs `())
+    (propagated-inputs
+     `(("java-aqute-bndlib" ,java-aqute-bndlib-bootstrap)
+       ("java-aqute-libg" ,java-aqute-libg-bootstrap)
+       ,@(delete `("java-aqute-bndlib" ,java-aqute-bndlib)
+                 (delete `("java-aqute-libg", java-aqute-libg)
+                         (package-inputs java-asm)))))))
+
 (define-public java-cglib
   (package
     (name "java-cglib")
-- 
2.16.2





Information forwarded to guix-patches <at> gnu.org:
bug#31152; Package guix-patches. (Sun, 15 Apr 2018 08:04:01 GMT) Full text and rfc822 format available.

Message #20 received at 31152 <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 31152 <at> debbugs.gnu.org
Subject: Re: [bug#31152] [PATCH 0/4] Bootstrap java-jarjar.
Date: Sun, 15 Apr 2018 10:02:54 +0200
Le Sat, 14 Apr 2018 15:50:39 +0200,
Gábor Boskovits <boskovits <at> gmail.com> a écrit :

> *** BLURB HERE ***
> 
> This patch series introduces the packages required to remove the
> bundled asm from jarjar. This is encouraged by current policy
> and needed by switching to java8, as the bundled asm version
> is too old.
> 
> Gábor Boskovits (4):
>   gnu: Add java-slfj4-api-bootstrap.
>   gnu: Add java-aqute-libg-bootstrap.
>   gnu: Add java-aqute-bndlib-bootstrap.
>   gnu: Add java-asm-bootstrap.
> 
>  gnu/packages/java.scm | 44
> ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44
> insertions(+)
> 

Hi Gábor,

I haven't tested these patches yet, but do you really need to define
them public? Otherwise LGTM.




Reply sent to Julien Lepiller <julien <at> lepiller.eu>:
You have taken responsibility. (Tue, 17 Apr 2018 11:00:02 GMT) Full text and rfc822 format available.

Notification sent to Gábor Boskovits <boskovits <at> gmail.com>:
bug acknowledged by developer. (Tue, 17 Apr 2018 11:00:03 GMT) Full text and rfc822 format available.

Message #25 received at 31152-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: 31152-done <at> debbugs.gnu.org
Subject: Re: [bug#31152] [PATCH 0/4] Bootstrap java-jarjar.
Date: Tue, 17 Apr 2018 12:59:43 +0200
Le Sat, 14 Apr 2018 15:50:39 +0200,
Gábor Boskovits <boskovits <at> gmail.com> a écrit :

> *** BLURB HERE ***
> 
> This patch series introduces the packages required to remove the
> bundled asm from jarjar. This is encouraged by current policy
> and needed by switching to java8, as the bundled asm version
> is too old.
> 
> Gábor Boskovits (4):
>   gnu: Add java-slfj4-api-bootstrap.
>   gnu: Add java-aqute-libg-bootstrap.
>   gnu: Add java-aqute-bndlib-bootstrap.
>   gnu: Add java-asm-bootstrap.
> 
>  gnu/packages/java.scm | 44
> ++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 44
> insertions(+)
> 

Pushed as bfb4004d3463a6857ff0aaeb9513a55c262970f0 with suggested
modifications (define-public -> define).




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 15 May 2018 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 7 years and 33 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.