GNU bug report logs - #31081
[PATCH] gnu: Add emacs-anzu-evil

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31081 in the body.
You can then email your comments to 31081 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sohom Bhattacharjee <soham.bhattacharjee15 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: Sohom Bhattacharjee <soham.bhattacharjee15 <at> gmail.com>
Subject: [PATCH] gnu: Add emacs-anzu-evil
Date: Sat,  7 Apr 2018 00:50:21 +0530

* gnu/packages/emacs.scm (emacs-anzu-evil): New variable.
---
test

 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index fd0b8acd0..2463d0dab 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7494,3 +7494,26 @@ used with SGML-like languages: XML, HTML, XHTML, XSL, etc.")
 standard Unix password manager\").")
     (license license:gpl2+)))
 
+(define-public emacs-evil-anzu
+ (package
+  (name "emacs-evil-anzu")
+  (version "0.03")
+  (source
+   (origin
+     (method url-fetch)
+     (uri (string-append "https://github.com/syohex/emacs-evil-anzu/archive/"
+                         version ".tar.gz"))
+     (file-name (string-append name "-" version ".tar.gz"))
+     (sha256
+      (base32 "032hh2946z529cizqsg8pm6cpn5qdj8lfk3qskmx6xv3g2ra56ns"))))
+  (build-system emacs-build-system)
+  (propagated-inputs
+    `(("emacs-evil" ,emacs-evil)
+      ("emacs-anzu" ,emacs-anzu)))
+  (home-page
+    "https://github.com/syohex/emacs-evil-anzu")
+  (synopsis "anzu for evil-mode")
+  (description "Anzu provides a minor mode that displays the current match and
+total match information in the mode-line in various search modes.")
+  (license license:gpl3+)))
+
-- 
2.16.2

Message #8 received at 31081 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Sohom Bhattacharjee <soham.bhattacharjee15 <at> gmail.com>
Cc: 31081 <at> debbugs.gnu.org
Subject: Re: [bug#31081] [PATCH] gnu: Add emacs-anzu-evil
Date: Sat, 07 Apr 2018 19:25:22 +0300

[Message part 1 (text/plain, inline)]

Hello Soham,

Sohom Bhattacharjee <soham.bhattacharjee15 <at> gmail.com> writes:

> * gnu/packages/emacs.scm (emacs-anzu-evil): New variable.
> ---
> test
>
>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index fd0b8acd0..2463d0dab 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7494,3 +7494,26 @@ used with SGML-like languages: XML, HTML, XHTML, XSL, etc.")
>  standard Unix password manager\").")
>      (license license:gpl2+)))
>  
> +(define-public emacs-evil-anzu
> + (package
> +  (name "emacs-evil-anzu")
> +  (version "0.03")
> +  (source
> +   (origin
> +     (method url-fetch)
> +     (uri (string-append "https://github.com/syohex/emacs-evil-anzu/archive/"
> +                         version ".tar.gz"))
> +     (file-name (string-append name "-" version ".tar.gz"))
> +     (sha256
> +      (base32 "032hh2946z529cizqsg8pm6cpn5qdj8lfk3qskmx6xv3g2ra56ns"))))
> +  (build-system emacs-build-system)
> +  (propagated-inputs
> +    `(("emacs-evil" ,emacs-evil)
> +      ("emacs-anzu" ,emacs-anzu)))
> +  (home-page
> +    "https://github.com/syohex/emacs-evil-anzu")
       ^
       This string could be on the previous line (‘M-^’ will do it).

> +  (synopsis "anzu for evil-mode")

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix lint emacs-evil-anzu

gnu/packages/emacs.scm:7515:12: emacs-evil-anzu <at> 0.03: synopsis should start with an upper-case letter or digit
--8<---------------cut here---------------end--------------->8---

I think ‘@code{anzu}’ will be appropriate.

> +  (description "Anzu provides a minor mode that displays the current match and
> +total match information in the mode-line in various search modes.")
> +  (license license:gpl3+)))
> +

The whole ‘(define-public emacs-evil-anzu …)’ should be indented.  I'm
not an ‘evil-mode’ user, but in pure Emacs you could do it with ‘M-h’
and ‘TAB’.  Also it will probably require to fill some strings with
‘M-q’.  Alternatively you use ‘etc/indent-code.el’.  See
https://www.gnu.org/software/guix/manual/html_node/Formatting-Code.html

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 31081 <at> debbugs.gnu.org (full text, mbox):

From: Sohom Bhattacharjee <soham.bhattacharjee15 <at> gmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>
Cc: 31081 <at> debbugs.gnu.org
Subject: Re: [bug#31081] [PATCH] gnu: Add emacs-anzu-evil
Date: Sat, 7 Apr 2018 23:47:10 +0530

[Message part 1 (text/plain, inline)]

I have made the suggested changes and attached the new patch. 

Thank You :-)


On Sat, Apr 07, 2018 at 07:25:22PM +0300, Oleg Pykhalov wrote:
> Hello Soham,
> 
> Sohom Bhattacharjee <soham.bhattacharjee15 <at> gmail.com> writes:
> 
> > * gnu/packages/emacs.scm (emacs-anzu-evil): New variable.
> > ---
> > test
> >
> >  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
> >  1 file changed, 23 insertions(+)
> >
> > diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> > index fd0b8acd0..2463d0dab 100644
> > --- a/gnu/packages/emacs.scm
> > +++ b/gnu/packages/emacs.scm
> > @@ -7494,3 +7494,26 @@ used with SGML-like languages: XML, HTML, XHTML, XSL, etc.")
> >  standard Unix password manager\").")
> >      (license license:gpl2+)))
> >  
> > +(define-public emacs-evil-anzu
> > + (package
> > +  (name "emacs-evil-anzu")
> > +  (version "0.03")
> > +  (source
> > +   (origin
> > +     (method url-fetch)
> > +     (uri (string-append "https://github.com/syohex/emacs-evil-anzu/archive/"
> > +                         version ".tar.gz"))
> > +     (file-name (string-append name "-" version ".tar.gz"))
> > +     (sha256
> > +      (base32 "032hh2946z529cizqsg8pm6cpn5qdj8lfk3qskmx6xv3g2ra56ns"))))
> > +  (build-system emacs-build-system)
> > +  (propagated-inputs
> > +    `(("emacs-evil" ,emacs-evil)
> > +      ("emacs-anzu" ,emacs-anzu)))
> > +  (home-page
> > +    "https://github.com/syohex/emacs-evil-anzu")
>        ^
>        This string could be on the previous line (‘M-^’ will do it).
> 
> > +  (synopsis "anzu for evil-mode")
> 
> --8<---------------cut here---------------start------------->8---
> $ ./pre-inst-env guix lint emacs-evil-anzu
> 
> gnu/packages/emacs.scm:7515:12: emacs-evil-anzu <at> 0.03: synopsis should start with an upper-case letter or digit
> --8<---------------cut here---------------end--------------->8---
> 
> I think ‘@code{anzu}’ will be appropriate.
> 
> > +  (description "Anzu provides a minor mode that displays the current match and
> > +total match information in the mode-line in various search modes.")
> > +  (license license:gpl3+)))
> > +
> 
> The whole ‘(define-public emacs-evil-anzu …)’ should be indented.  I'm
> not an ‘evil-mode’ user, but in pure Emacs you could do it with ‘M-h’
> and ‘TAB’.  Also it will probably require to fill some strings with
> ‘M-q’.  Alternatively you use ‘etc/indent-code.el’.  See
> https://www.gnu.org/software/guix/manual/html_node/Formatting-Code.html
> 
> Thanks,
> Oleg.

[0001-gnu-Add-emacs-evil-anzu.patch (text/plain, attachment)]

Message #14 received at 31081 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: Sohom Bhattacharjee <soham.bhattacharjee15 <at> gmail.com>
Cc: 31081-done <at> debbugs.gnu.org, 31081 <at> debbugs.gnu.org
Subject: Re: [bug#31081] [PATCH] gnu: Add emacs-anzu-evil
Date: Sat, 07 Apr 2018 21:38:43 +0300

[Message part 1 (text/plain, inline)]

Sohom Bhattacharjee <soham.bhattacharjee15 <at> gmail.com> writes:

> I have made the suggested changes and attached the new patch. 
>
> Thank You :-)

[…]

> From baa056f96e1bb5a2fba0276a729237762d697cd2 Mon Sep 17 00:00:00 2001
> From: Sohom Bhattacharjee <soham.bhattacharjee15 <at> gmail.com>
> Date: Sat, 7 Apr 2018 23:36:31 +0530
> Subject: [PATCH] gnu: Add emacs-evil-anzu.
>
> * gnu/packages/emacs.scm (emacs-evil-anzu): New variable.
> ---
>  gnu/packages/emacs.scm | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index fd0b8acd0..0ff712117 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7494,3 +7494,25 @@ used with SGML-like languages: XML, HTML, XHTML, XSL, etc.")
>  standard Unix password manager\").")
>      (license license:gpl2+)))
>  
> +
  ^
  Only 1 empty line between definitions.

> +(define-public emacs-evil-anzu
> +  (package
> +    (name "emacs-evil-anzu")
> +    (version "0.03")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/syohex/emacs-evil-anzu/archive/"

This line is longer than 78.

> +                           version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32 "032hh2946z529cizqsg8pm6cpn5qdj8lfk3qskmx6xv3g2ra56ns"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-evil" ,emacs-evil)
> +       ("emacs-anzu" ,emacs-anzu)))
> +    (home-page "https://github.com/syohex/emacs-evil-anzu")
> +    (synopsis "Anzu for evil-mode")
> +    (description "@code{anzu} provides a minor mode that displays the current match

The description is longer than 78.

> +and total match information in the mode-line in various search modes.")
> +    (license license:gpl3+)))

Pushed as d4bb4551356c6601a952e89ad8e1b56a3bf2244d with changes above.

Thanks,
Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.