GNU bug report logs - #31080
[PATCH 0/2] Add launchmon and spindle

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 31080 in the body.
You can then email your comments to 31080 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
To: guix-patches <at> gnu.org
Cc: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Subject: [PATCH 0/2] Add launchmon and spindle
Date: Fri,  6 Apr 2018 18:02:35 +0200

This patch add package for launchmon and spindle, they compile and install
without any error. But not sure they binary works nice. If someone familiar
with spindle and launchmon could have a look ?

(note: the headers specify the lgpl2.1 only)

Rouby Pierre-Antoine (2):
  gnu: Add launchmon.
  gnu: Add spindle.

 gnu/packages/admin.scm | 63 +++++++++++++++++++++++++++++++++++++++++++++++++-
 1 file changed, 62 insertions(+), 1 deletion(-)

-- 
2.16.1

Message #8 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
To: 31080 <at> debbugs.gnu.org
Cc: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Subject: [PATCH 1/2] gnu: Add launchmon.
Date: Mon,  9 Apr 2018 08:58:57 +0200

* gnu/packages/admin.scm (launchmon): New variable.
---
 gnu/packages/admin.scm | 34 +++++++++++++++++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 6a7bed389..4403f2a3b 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -90,7 +90,10 @@
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages kerberos)
   #:use-module (gnu packages gtk)
-  #:use-module (gnu packages xml))
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages boost)
+  #:use-module (gnu packages elf)
+  #:use-module (gnu packages mpi))
 
 (define-public aide
   (package
@@ -2505,3 +2508,32 @@ printed instead of after the entire file has been read, which is often too
 late.")
     (home-page "https://jwilk.net/software/hungrycat")
     (license license:expat)))
+
+(define-public launchmon
+  (package
+    (name "launchmon")
+    (version "1.0.2")
+    (source (origin
+              (file-name (git-file-name name version))
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/LLNL/LaunchMON/releases/download/v"
+                    version "/" name "-v" version ".tar.gz"))
+              (sha256
+               (base32
+                "0fm3nd9mydm9v2bf7bh01dbgrfnpwkapxa3dsvy3x1z0rz61qc0x"))))
+    (build-system gnu-build-system)
+    (inputs `(("munge" ,munge)
+              ("boost" ,boost)
+              ("libelf" ,libelf)
+              ("openmpi" ,openmpi)
+              ("libgcrypt" ,libgcrypt)
+              ("libgpg-error" ,libgpg-error)))
+    (synopsis "Software infrastructure for HPC environments")
+    (description
+     "LaunchMON is a software infrastructure that enables HPC
+(High-Performance Computing) run-time tools to co-locate tool daemons with a
+parallel job.  Its API allows a tool to identify all the remote processes of a
+job and to scalably launch daemons into the relevant nodes.")
+    (home-page "https://github.com/LLNL/LaunchMON")
+    (license license:lgpl2.1)))
-- 
2.16.1

Message #11 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
To: 31080 <at> debbugs.gnu.org
Cc: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Subject: [PATCH 2/2] gnu: Add spindle.
Date: Mon,  9 Apr 2018 08:59:49 +0200

* gnu/packages/admin.scm (spindle): New variable.
---
 gnu/packages/admin.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 4403f2a3b..c89662fc9 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2537,3 +2537,32 @@ parallel job.  Its API allows a tool to identify all the remote processes of a
 job and to scalably launch daemons into the relevant nodes.")
     (home-page "https://github.com/LLNL/LaunchMON")
     (license license:lgpl2.1)))
+
+(define-public spindle
+  (package
+    (name "spindle")
+    (version "0.10")
+    (source (origin
+              (file-name (git-file-name name version))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/hpc/Spindle.git")
+                    (commit "ff922c1df167c28ab312d02217ed7be65ec0e831")))
+              (sha256
+               (base32
+                "15n3ay0qq81r5v7fif61q1vdjcq44pp2nynkh3fvbzc9fj3c39wd"))))
+    (build-system gnu-build-system)
+    (arguments '(#:configure-flags '("--enable-sec-launchmon"
+                                     "--enable-sec-munge"
+                                     "--enable-sec-none")))
+    (inputs `(("munge" ,munge)
+              ("openmpi" ,openmpi)
+              ("launchmon" ,launchmon)
+              ("libgcrypt" ,libgcrypt)))
+    (synopsis "Scalable dynamic library and Python loading in HPC
+environments")
+    (description
+     "Spindle is a tool for improving the performance of dynamic library and
+Python loading in HPC environments.")
+    (home-page "https://github.com/hpc/Spindle")
+    (license license:lgpl2.1)))
-- 
2.16.1

Message #14 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: ludovic.courtes <at> inria.fr (Ludovic Courtès)
To: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Cc: Eric Bavier <bavier <at> cray.com>, 31080 <at> debbugs.gnu.org
Subject: Re: [bug#31080] [PATCH 0/2] Add launchmon and spindle
Date: Mon, 09 Apr 2018 15:50:34 +0200

Hi there!

I should say that this is Pierre-Antoine’s first week as an intern here
at Inria to work on Guix for HPC.  So welcome, Pierre-Antoine!  :-)

The patches look good to me, but as Pierre-Antoine wrote, we’d like to
get feedback from someone more familiar with the tools.  Eric maybe?

Thanks,
Ludo’.

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: guix-patches <at> gnu.org
Subject: Re: [bug#31080] [PATCH 2/2] gnu: Add spindle.
Date: Mon, 9 Apr 2018 16:06:48 +0200

On 09/04/18 08:59, Rouby Pierre-Antoine wrote:
> * gnu/packages/admin.scm (spindle): New variable.
> ---
>  gnu/packages/admin.scm | 29 +++++++++++++++++++++++++++++
>  1 file changed, 29 insertions(+)
> 
> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
> index 4403f2a3b..c89662fc9 100644
> --- a/gnu/packages/admin.scm
> +++ b/gnu/packages/admin.scm

Welcome Pierre-Antoine! Please also include your name in the license
section at the top of "admin.scm".

~Jonathan

Message #20 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
Cc: 31080 <at> debbugs.gnu.org
Subject: Re: [bug#31080] [PATCH 2/2] gnu: Add spindle.
Date: Mon, 09 Apr 2018 22:34:01 +0200

Jonathan Brielmaier <jonathan.brielmaier <at> web.de> skribis:

> On 09/04/18 08:59, Rouby Pierre-Antoine wrote:
>> * gnu/packages/admin.scm (spindle): New variable.
>> ---
>>  gnu/packages/admin.scm | 29 +++++++++++++++++++++++++++++
>>  1 file changed, 29 insertions(+)
>> 
>> diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
>> index 4403f2a3b..c89662fc9 100644
>> --- a/gnu/packages/admin.scm
>> +++ b/gnu/packages/admin.scm
>
> Welcome Pierre-Antoine! Please also include your name in the license
> section at the top of "admin.scm".

Oops, indeed.

Ludo’.

Message #23 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
To: 31080 <at> debbugs.gnu.org
Cc: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Subject: [PATCH 1/2] gnu: Add launchmon.
Date: Tue, 10 Apr 2018 12:03:50 +0200

* gnu/packages/admin.scm (launchmon): New variable.
---
 gnu/packages/admin.scm | 35 ++++++++++++++++++++++++++++++++++-
 1 file changed, 34 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 6a7bed389..bf50a51f4 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2017 Christopher Allan Webber <cwebber <at> dustycloud.org>
 ;;; Copyright © 2017 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2018 Arun Isaac <arunisaac <at> systemreboot.net>
+;;; Copyright © 2018 Pierre-Antoine Rouby <pierre-antoine.rouby <at> inria.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -90,7 +91,10 @@
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages kerberos)
   #:use-module (gnu packages gtk)
-  #:use-module (gnu packages xml))
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages boost)
+  #:use-module (gnu packages elf)
+  #:use-module (gnu packages mpi))
 
 (define-public aide
   (package
@@ -2505,3 +2509,32 @@ printed instead of after the entire file has been read, which is often too
 late.")
     (home-page "https://jwilk.net/software/hungrycat")
     (license license:expat)))
+
+(define-public launchmon
+  (package
+    (name "launchmon")
+    (version "1.0.2")
+    (source (origin
+              (file-name (git-file-name name version))
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/LLNL/LaunchMON/releases/download/v"
+                    version "/" name "-v" version ".tar.gz"))
+              (sha256
+               (base32
+                "0fm3nd9mydm9v2bf7bh01dbgrfnpwkapxa3dsvy3x1z0rz61qc0x"))))
+    (build-system gnu-build-system)
+    (inputs `(("munge" ,munge)
+              ("boost" ,boost)
+              ("libelf" ,libelf)
+              ("openmpi" ,openmpi)
+              ("libgcrypt" ,libgcrypt)
+              ("libgpg-error" ,libgpg-error)))
+    (synopsis "Software infrastructure for HPC environments")
+    (description
+     "LaunchMON is a software infrastructure that enables HPC
+(High-Performance Computing) run-time tools to co-locate tool daemons with a
+parallel job.  Its API allows a tool to identify all the remote processes of a
+job and to scalably launch daemons into the relevant nodes.")
+    (home-page "https://github.com/LLNL/LaunchMON")
+    (license license:lgpl2.1)))
-- 
2.16.1

Message #26 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
To: 31080 <at> debbugs.gnu.org
Cc: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Subject: [PATCH 2/2] gnu: Add spindle.
Date: Tue, 10 Apr 2018 12:03:51 +0200

* gnu/packages/admin.scm (spindle): New variable.
---
 gnu/packages/admin.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index bf50a51f4..512dcf59c 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2538,3 +2538,32 @@ parallel job.  Its API allows a tool to identify all the remote processes of a
 job and to scalably launch daemons into the relevant nodes.")
     (home-page "https://github.com/LLNL/LaunchMON")
     (license license:lgpl2.1)))
+
+(define-public spindle
+  (package
+    (name "spindle")
+    (version "0.10")
+    (source (origin
+              (file-name (git-file-name name version))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/hpc/Spindle.git")
+                    (commit "ff922c1df167c28ab312d02217ed7be65ec0e831")))
+              (sha256
+               (base32
+                "15n3ay0qq81r5v7fif61q1vdjcq44pp2nynkh3fvbzc9fj3c39wd"))))
+    (build-system gnu-build-system)
+    (arguments '(#:configure-flags '("--enable-sec-launchmon"
+                                     "--enable-sec-munge"
+                                     "--enable-sec-none")))
+    (inputs `(("munge" ,munge)
+              ("openmpi" ,openmpi)
+              ("launchmon" ,launchmon)
+              ("libgcrypt" ,libgcrypt)))
+    (synopsis "Scalable dynamic library and Python loading in HPC
+environments")
+    (description
+     "Spindle is a tool for improving the performance of dynamic library and
+Python loading in HPC environments.")
+    (home-page "https://github.com/hpc/Spindle")
+    (license license:lgpl2.1)))
-- 
2.16.1

Message #29 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <bavier <at> cray.com>
To: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Cc: Ludovic Courtès <ludovic.courtes <at> inria.fr>,
 31080 <at> debbugs.gnu.org
Subject: Re: [bug#31080] [PATCH 0/2] Add launchmon and spindle
Date: Tue, 10 Apr 2018 10:20:40 -0500

On Mon, Apr 09, 2018 at 03:50:34PM +0200, Ludovic Courtès wrote:
> I should say that this is Pierre-Antoine’s first week as an intern here
> at Inria to work on Guix for HPC.  So welcome, Pierre-Antoine!  :-)

Exciting, welcome Pierre-Antoine!  It will be nice to have another
person on Guix for HPC.

> The patches look good to me, but as Pierre-Antoine wrote, we’d like to
> get feedback from someone more familiar with the tools.  Eric maybe?

I have not used these tools much before, but I'll see if I can give
them a test run.  It will be a good excuse for me to finally get Guix
installed on one of our x86 systems. :)

Just a few comments/nitpicks on the patches:

> +
> +(define-public launchmon
> +  (package
> +    (name "launchmon")
> +    (version "1.0.2")
> +    (source (origin
> +              (file-name (git-file-name name version))
                  ^
Leave this field out, since the tarball file-name is already fine.

> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/LLNL/LaunchMON/releases/download/v"
> +                    version "/" name "-v" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0fm3nd9mydm9v2bf7bh01dbgrfnpwkapxa3dsvy3x1z0rz61qc0x"))))
> +    (build-system gnu-build-system)
> +    (inputs `(("munge" ,munge)
               ^
Please indent the inputs list like the other packages in this file.

> +              ("boost" ,boost)
> +              ("libelf" ,libelf)
> +              ("openmpi" ,openmpi)

IDK if this would be meaningful for these tools, but some other MPI
packages have used the convention of of naming this input just "mpi".
IIRC Ludovic suggested this in a paper.

> +              ("libgcrypt" ,libgcrypt)
> +              ("libgpg-error" ,libgpg-error)))
> +    (synopsis "Software infrastructure for HPC environments")

Maybe: "Launch tools into HPC environments" so as not to confuse it
with a general piece of "software infrastructure"

> +    (description
> +     "LaunchMON is a software infrastructure that enables HPC
> +(High-Performance Computing) run-time tools to co-locate tool daemons with a
> +parallel job.  Its API allows a tool to identify all the remote processes of a
> +job and to scalably launch daemons into the relevant nodes.")
> +    (home-page "https://github.com/LLNL/LaunchMON")
> +    (license license:lgpl2.1)))

We should also include a "supported-systems" field here:

   (supported-systems '("i686-linux" "x86_64-linux"))

Since only x86 and powerpc architectures are supported, as noted
above. :(

+
+(define-public spindle
+  (package
+    (name "spindle")
+    (version "0.10")
+    (source (origin
+              (file-name (git-file-name name version))
+              (method git-fetch)

Maybe just note in a comment that we're using a git checkout to avoid
auto-generated github tarballs.

+              (uri (git-reference
+                    (url "https://github.com/hpc/Spindle.git")
+                    (commit "ff922c1df167c28ab312d02217ed7be65ec0e831")))
                              ^
Could we reference the 'v0.10' tag instead?

+              (sha256
+               (base32
+                "15n3ay0qq81r5v7fif61q1vdjcq44pp2nynkh3fvbzc9fj3c39wd"))))
+    (build-system gnu-build-system)
+    (arguments '(#:configure-flags '("--enable-sec-launchmon"
+                                     "--enable-sec-munge"
+                                     "--enable-sec-none")))
+    (inputs `(("munge" ,munge)
             ^
nit: indentation

+              ("openmpi" ,openmpi)
+              ("launchmon" ,launchmon)
+              ("libgcrypt" ,libgcrypt)))
+    (synopsis "Scalable dynamic library and Python loading in HPC
+environments")

Maybe: "Scalable library loading in HPC environments"

+    (description
+     "Spindle is a tool for improving the performance of dynamic library and
+Python loading in HPC environments.")
+    (home-page "https://github.com/hpc/Spindle")
+    (license license:lgpl2.1)))


Otherwise LGTM.  I'll see if I can give them a try soon.

-- 
Eric Bavier, Scientific Libraries, Cray Inc.

Message #32 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
To: 31080 <at> debbugs.gnu.org
Cc: bavier <at> cray.com, ludovic.courtes <at> inria.fr,
 Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Subject: [PATCH 1/2] gnu: Add launchmon.
Date: Wed, 11 Apr 2018 14:58:09 +0200

* gnu/packages/admin.scm (launchmon): New variable.
---
 gnu/packages/admin.scm | 36 +++++++++++++++++++++++++++++++++++-
 1 file changed, 35 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 6a7bed389..71899d98c 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2017 Christopher Allan Webber <cwebber <at> dustycloud.org>
 ;;; Copyright © 2017 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2018 Arun Isaac <arunisaac <at> systemreboot.net>
+;;; Copyright © 2018 Pierre-Antoine Rouby <pierre-antoine.rouby <at> inria.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -90,7 +91,10 @@
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages kerberos)
   #:use-module (gnu packages gtk)
-  #:use-module (gnu packages xml))
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages boost)
+  #:use-module (gnu packages elf)
+  #:use-module (gnu packages mpi))
 
 (define-public aide
   (package
@@ -2505,3 +2509,33 @@ printed instead of after the entire file has been read, which is often too
 late.")
     (home-page "https://jwilk.net/software/hungrycat")
     (license license:expat)))
+
+(define-public launchmon
+  (package
+    (name "launchmon")
+    (version "1.0.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/LLNL/LaunchMON/releases/download/v"
+                    version "/" name "-v" version ".tar.gz"))
+              (sha256
+               (base32
+                "0fm3nd9mydm9v2bf7bh01dbgrfnpwkapxa3dsvy3x1z0rz61qc0x"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("mpi" ,openmpi)
+       ("munge" ,munge)
+       ("boost" ,boost)
+       ("libelf" ,libelf)
+       ("libgcrypt" ,libgcrypt)
+       ("libgpg-error" ,libgpg-error)))
+    (synopsis "An infrastructue for large scale tool daemon launching")
+    (description
+     "LaunchMON is a software infrastructure that enables HPC run-time
+tools to co-locate tool daemons with a parallel job.  Its API allows a
+tool to identify all the remote processes of a job and to scalably
+launch daemons into the relevant nodes.")
+    (home-page "https://github.com/LLNL/LaunchMON")
+    (supported-systems '("i686-linux" "x86_64-linux"))
+    (license license:lgpl2.1)))
-- 
2.16.1

Message #35 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
To: 31080 <at> debbugs.gnu.org
Cc: bavier <at> cray.com, ludovic.courtes <at> inria.fr,
 Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Subject: [PATCH 2/2] gnu: Add spindle.
Date: Wed, 11 Apr 2018 14:58:10 +0200

* gnu/packages/admin.scm (spindle): New variable.
---
 gnu/packages/admin.scm | 29 +++++++++++++++++++++++++++++
 1 file changed, 29 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 71899d98c..a277a0a75 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2539,3 +2539,32 @@ launch daemons into the relevant nodes.")
     (home-page "https://github.com/LLNL/LaunchMON")
     (supported-systems '("i686-linux" "x86_64-linux"))
     (license license:lgpl2.1)))
+
+(define-public spindle
+  (package
+    (name "spindle")
+    (version "0.10")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/hpc/Spindle/archive/v"
+                    version ".tar.gz"))
+              (file-name (string-append name "-" version ".tar.gz"))
+              (sha256
+               (base32
+                "10hl1d5nvjbx8yah4zhbxhijjigqsvrld057ljv01cvqkqycsx39"))))
+    (build-system gnu-build-system)
+    (arguments '(#:configure-flags '("--enable-sec-launchmon"
+                                     "--enable-sec-munge"
+                                     "--enable-sec-none")))
+    (inputs
+     `(("mpi" ,openmpi)
+       ("munge" ,munge)
+       ("launchmon" ,launchmon)
+       ("libgcrypt" ,libgcrypt)))
+    (synopsis "Scalable library loading in HPC environments")
+    (description
+     "Spindle is a tool for improving the performance of dynamic library and
+Python loading in HPC environments.")
+    (home-page "https://github.com/hpc/Spindle")
+    (license license:lgpl2.1)))
-- 
2.16.1

Message #38 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <bavier <at> cray.com>
To: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Cc: ludovic.courtes <at> inria.fr, 31080 <at> debbugs.gnu.org
Subject: Re: [PATCH 1/2] gnu: Add launchmon.
Date: Wed, 11 Apr 2018 10:28:23 -0500

On Wed, Apr 11, 2018 at 02:58:09PM +0200, Rouby Pierre-Antoine wrote:
> @@ -2505,3 +2509,33 @@ printed instead of after the entire file has been read, which is often too
>  late.")
>      (home-page "https://jwilk.net/software/hungrycat")
>      (license license:expat)))
> +
> +(define-public launchmon
> +  (package
> +    (name "launchmon")
> +    (version "1.0.2")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/LLNL/LaunchMON/releases/download/v"
> +                    version "/" name "-v" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0fm3nd9mydm9v2bf7bh01dbgrfnpwkapxa3dsvy3x1z0rz61qc0x"))))
> +    (build-system gnu-build-system)
> +    (inputs
> +     `(("mpi" ,openmpi)
> +       ("munge" ,munge)
> +       ("boost" ,boost)
> +       ("libelf" ,libelf)
> +       ("libgcrypt" ,libgcrypt)
> +       ("libgpg-error" ,libgpg-error)))
> +    (synopsis "An infrastructue for large scale tool daemon launching")
                  ^
No "An" at the beginning.  See the "Synopses and Descrtiptions"
section in the manual.

Otherwise LGTM!  Thanks!

-- 
Eric Bavier, Scientific Libraries, Cray Inc.

Message #41 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <bavier <at> cray.com>
To: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Cc: ludovic.courtes <at> inria.fr, 31080 <at> debbugs.gnu.org
Subject: Re: [PATCH 2/2] gnu: Add spindle.
Date: Wed, 11 Apr 2018 10:31:05 -0500

On Wed, Apr 11, 2018 at 02:58:10PM +0200, Rouby Pierre-Antoine wrote:
> +(define-public spindle
> +  (package
> +    (name "spindle")
> +    (version "0.10")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/hpc/Spindle/archive/v"
> +                    version ".tar.gz"))

No no, the git checkout used before was good.  These autogenerated
tarballs (as opposed to e.g. the maintainer-uploaded tarball that
launchmon has) can change at any time, so we'd rather not use them.
Sorry for any confusion my comment caused.

Otherwise looks good.

-- 
Eric Bavier, Scientific Libraries, Cray Inc.

Message #44 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
To: 31080 <at> debbugs.gnu.org
Cc: bavier <at> cray.com, ludovic.courtes <at> inria.fr,
 Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Subject: [PATCH 2/2] gnu: Add spindle.
Date: Thu, 12 Apr 2018 10:43:11 +0200

* gnu/packages/admin.scm (spindle): New variable.
---
 gnu/packages/admin.scm | 30 ++++++++++++++++++++++++++++++
 1 file changed, 30 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index c9fea40b1..8ea46b7e2 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -2539,3 +2539,33 @@ launch daemons into the relevant nodes.")
     (home-page "https://github.com/LLNL/LaunchMON")
     (supported-systems '("i686-linux" "x86_64-linux"))
     (license license:lgpl2.1)))
+
+(define-public spindle
+  (package
+    (name "spindle")
+    (version "0.10")
+    (source (origin
+              ;; We use git checkout to avoid github auto-generated tarballs
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/hpc/Spindle.git")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "15n3ay0qq81r5v7fif61q1vdjcq44pp2nynkh3fvbzc9fj3c39wd"))))
+    (build-system gnu-build-system)
+    (arguments '(#:configure-flags '("--enable-sec-launchmon"
+                                     "--enable-sec-munge"
+                                     "--enable-sec-none")))
+    (inputs
+     `(("mpi" ,openmpi)
+       ("munge" ,munge)
+       ("launchmon" ,launchmon)
+       ("libgcrypt" ,libgcrypt)))
+    (synopsis "Scalable library loading in HPC environments")
+    (description
+     "Spindle is a tool for improving the performance of dynamic library and
+Python loading in HPC environments.")
+    (home-page "https://github.com/hpc/Spindle")
+    (license license:lgpl2.1)))
-- 
2.16.1

Message #47 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
To: 31080 <at> debbugs.gnu.org
Cc: bavier <at> cray.com, ludovic.courtes <at> inria.fr,
 Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Subject: [PATCH 1/2] gnu: Add launchmon.
Date: Thu, 12 Apr 2018 10:43:10 +0200

* gnu/packages/admin.scm (launchmon): New variable.
---
 gnu/packages/admin.scm | 36 +++++++++++++++++++++++++++++++++++-
 1 file changed, 35 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 6a7bed389..c9fea40b1 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -20,6 +20,7 @@
 ;;; Copyright © 2017 Christopher Allan Webber <cwebber <at> dustycloud.org>
 ;;; Copyright © 2017 Marius Bakke <mbakke <at> fastmail.com>
 ;;; Copyright © 2018 Arun Isaac <arunisaac <at> systemreboot.net>
+;;; Copyright © 2018 Pierre-Antoine Rouby <pierre-antoine.rouby <at> inria.fr>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -90,7 +91,10 @@
   #:use-module (gnu packages gnome)
   #:use-module (gnu packages kerberos)
   #:use-module (gnu packages gtk)
-  #:use-module (gnu packages xml))
+  #:use-module (gnu packages xml)
+  #:use-module (gnu packages boost)
+  #:use-module (gnu packages elf)
+  #:use-module (gnu packages mpi))
 
 (define-public aide
   (package
@@ -2505,3 +2509,33 @@ printed instead of after the entire file has been read, which is often too
 late.")
     (home-page "https://jwilk.net/software/hungrycat")
     (license license:expat)))
+
+(define-public launchmon
+  (package
+    (name "launchmon")
+    (version "1.0.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://github.com/LLNL/LaunchMON/releases/download/v"
+                    version "/" name "-v" version ".tar.gz"))
+              (sha256
+               (base32
+                "0fm3nd9mydm9v2bf7bh01dbgrfnpwkapxa3dsvy3x1z0rz61qc0x"))))
+    (build-system gnu-build-system)
+    (inputs
+     `(("mpi" ,openmpi)
+       ("munge" ,munge)
+       ("boost" ,boost)
+       ("libelf" ,libelf)
+       ("libgcrypt" ,libgcrypt)
+       ("libgpg-error" ,libgpg-error)))
+    (synopsis "Infrastructue for large scale tool daemon launching")
+    (description
+     "LaunchMON is a software infrastructure that enables HPC run-time
+tools to co-locate tool daemons with a parallel job.  Its API allows a
+tool to identify all the remote processes of a job and to scalably
+launch daemons into the relevant nodes.")
+    (home-page "https://github.com/LLNL/LaunchMON")
+    (supported-systems '("i686-linux" "x86_64-linux"))
+    (license license:lgpl2.1)))
-- 
2.16.1

Message #50 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: Eric Bavier <bavier <at> cray.com>
To: Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Cc: ludovic.courtes <at> inria.fr, 31080 <at> debbugs.gnu.org
Subject: Re: [PATCH 2/2] gnu: Add spindle.
Date: Wed, 18 Apr 2018 10:07:11 -0500

On Thu, Apr 12, 2018 at 10:43:11AM +0200, Rouby Pierre-Antoine wrote:
> * gnu/packages/admin.scm (spindle): New variable.
> ---
>  gnu/packages/admin.scm | 30 ++++++++++++++++++++++++++++++
>  1 file changed, 30 insertions(+)
> 

These look good to me now.  IMO they can be pushed now, and we can fix
any bugs with actual usage once those tests are done.

-- 
Eric Bavier, Scientific Libraries, Cray Inc.

Message #53 received at 31080 <at> debbugs.gnu.org (full text, mbox):

From: Pierre-Antoine Rouby <pierre-antoine.rouby <at> inria.fr>
To: 31080 <at> debbugs.gnu.org
Cc: Eric Bavier <bavier <at> cray.com>
Subject: Re: [PATCH 2/2] gnu: Add spindle.
Date: Wed, 18 Apr 2018 17:21:57 +0200 (CEST)

> These look good to me now.  IMO they can be pushed now, and we can fix
> any bugs with actual usage once those tests are done.

Ok, thanks you for reviewing my code.

Pierre-Antoine Rouby

Message #58 received at 31080-done <at> debbugs.gnu.org (full text, mbox):

From: ludovic.courtes <at> inria.fr (Ludovic Courtès)
To: Eric Bavier <bavier <at> cray.com>
Cc: 31080-done <at> debbugs.gnu.org,
 Rouby Pierre-Antoine <pierre-antoine.rouby <at> inria.fr>
Subject: Re: [PATCH 2/2] gnu: Add spindle.
Date: Thu, 19 Apr 2018 11:22:59 +0200

Hello,

Eric Bavier <bavier <at> cray.com> skribis:

> On Thu, Apr 12, 2018 at 10:43:11AM +0200, Rouby Pierre-Antoine wrote:
>> * gnu/packages/admin.scm (spindle): New variable.
>> ---
>>  gnu/packages/admin.scm | 30 ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>> 
>
> These look good to me now.  IMO they can be pushed now, and we can fix
> any bugs with actual usage once those tests are done.

Alright, applied.  Thanks for reviewing Eric, and thanks for these first
patches P-A!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.