GNU bug report logs - #30972
[PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline

Previous Next

Full log

Message #11 received at 30972 <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 30972 <at> debbugs.gnu.org
Subject: Re: [bug#30972] [PATCH] gnu: virtuoso-ose: Unbundle zlib and build
 with readline
Date: Thu, 29 Mar 2018 00:29:21 +0200

Marius Bakke <mbakke <at> fastmail.com> writes:

> Roel Janssen <roel <at> gnu.org> writes:
>
>> From 80b26cfcc3d64588738e5fecc92f3eabc214ed4c Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel <at> gnu.org>
>> Date: Wed, 28 Mar 2018 18:13:23 +0200
>> Subject: [PATCH] gnu: virtuoso-ose: Unbundle zlib and build with readline
>>  support.
>>
>> * gnu/packages/databases.scm (virtuoso-ose): Unbundle zlib and build with
>>   readline support.
>
> Please mention the changes to [inputs] and [arguments] here.  Also,
> assuming there is an internal copy of zlib, can you remove it with a
> source 'snippet'?

Thanks for the quick response!

Then I'll need to rerun “autogen.sh” to make sure
“libsrc/zlib/Makefile.in” isn't included in the configure phase.  That
in turns needs the following packages added to native-inputs: autoconf,
automake, bison, flex, gettext, gperf, libtool, perl, and pkg-config.

Does that justify removing the zlib source directory?  If so, I'll send
the updated patch.  Otherwise, I'll just update the commit message.
Would this be a proper commit message:

gnu: virtuoso-ose: Unbundle zlib and build with readline support.

* gnu/packages/databases.scm (virtuoso-ose):
  [inputs]: Add zlib, and readline;
  [arguments]: Add --without-internal-zlib, and --with-readline.


Thanks for your time.

Kind regards,
Roel Janssen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.