GNU bug report logs - #30971
Add package definition for fpm2

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30971 in the body.
You can then email your comments to 30971 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ton <tonton <at> riseup.net>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: Add package definition for fpm2
Date: Wed, 28 Mar 2018 16:09:32 +0200

[Message part 1 (text/plain, inline)]

Here is the package definition for figaros password manager, or fpm2. It is a
simple password manager. Development has seized and the package should be
considered dead. I had use for it personally and thought I'd share it. There
is a warning in the description.

Built and tested on GuixSD Linux merlin 4.15.8-gnu #1 SMP 1 x86_64 GNU/Linux.

It passes guix lint without errors.

It builds 5 times deterministicly.

Guix size says "total: 486.5 MiB"

[0001-Add-package-definition-screen-message.patch (text/x-patch, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #8 received at 30971 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ton <tonton <at> riseup.net>, 30971 <at> debbugs.gnu.org
Subject: Re: [bug#30971] Add package definition for fpm2
Date: Wed, 28 Mar 2018 22:03:49 +0200

[Message part 1 (text/plain, inline)]

Ton <tonton <at> riseup.net> writes:

> Here is the package definition for figaros password manager, or fpm2. It is a
> simple password manager. Development has seized and the package should be
> considered dead. I had use for it personally and thought I'd share it. There
> is a warning in the description.

Thanks!  I'm a bit vary about adding obsolete software to Guix.  Any
opinions from other contributors?  If no one responds, I'll assume it's
okay.

[...]

> From d2efd598855759ce8377569b9e8279a5f774a22a Mon Sep 17 00:00:00 2001
> From: Tonton <tonton <at> riseup.net>
> Date: Wed, 28 Mar 2018 16:08:52 +0200
> Subject: [PATCH] Add package definition screen message
>
> Built and tested on GuixSD Linux merlin 4.15.8-gnu #1 SMP 1 x86_64 GNU/Linux.
>
> It passes guix lint without errors.
>
> It builds 5 times deterministicly.
>
> Guix size says "total: 486.5 MiB"

Again, see "git log" for the usual conventions.

> ---
>  gnu/packages/fpm2.scm | 64 +++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 64 insertions(+)
>  create mode 100644 gnu/packages/fpm2.scm

I think this can go to 'password-utils.scm' along with other password
managers.

[...]

> +(define-public fpm2
> +  (package
> +    (name "fpm2")
> +    (version "0.79")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://als.regnet.cz/fpm2/download/fpm2-"
> +                                  version ".tar.bz2"))
> +              (sha256
> +               (base32
> +                "19sdy1lygfhkg5nxi2w9a4d9kwvw24nxp0ix0p0lz91qpvk9qpnm"))))
> +    (build-system gnu-build-system)
> +    (inputs `(("gtk2" ,gtk+-2)
> +              ("gnupg" ,gnupg)
> +              ("libxml2" ,libxml2)))
> +    (native-inputs `(("pkgconfig" ,pkg-config)
> +                     ("intltool" ,intltool)))
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before
> +             'configure 'pre-configure
> +           (lambda _
> +               (let* ((poinc (open-output-file "po/POTFILES.in")))
> +                 (begin
> +                   (newline poinc)
> +                   (display "data/fpm2.desktop.in" poinc)
> +                   (newline poinc)
> +                   (display "data/fpm2.desktop.in.in" poinc)
> +                   (newline poinc)
> +                   (display "fpm2.glade" poinc)
> +                   (newline poinc)
> +                   (display "src/callbacks.c" poinc)
> +                   (newline poinc)
> +                   (display "src/fpm.c" poinc)
> +                   (newline poinc)
> +                   (display "src/fpm_file.c" poinc)
> +                   (newline poinc)
> +                   (display "src/interface.c" poinc)
> +                   (newline poinc)
> +                   (display "src/support.c" poinc)
> +                   (newline poinc)
> +                   (display "fpm2.glade" poinc)
> +                   (newline poinc)
> +                   (close-port poinc))))))))

I admit I don't understand what's going on here.  AFAICT this overwrites
POTFILES.in with custom text.  Can you add a comment about why this is
necessary?  Also, I think it's clearer to write it like this:

(call-with-output-file "po/POTFILES.in"
  (lambda (port)
    (format port "data/fpm2.desktop.in
data/fpm2.desktop.in.in
[...]")))

> +    (synopsis "Manages, generates and stores passwords encrypted")

Please use infinitive verbs in synopses, i.e. avoid the present tense:
"Manage, generate and store passwords encrypted".

Apart from this LGTM.  Can you send an updated patch?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 30971 <at> debbugs.gnu.org (full text, mbox):

From: Ton <tonton <at> riseup.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 30971 <at> debbugs.gnu.org
Subject: Re: [bug#30971] Add package definition for fpm2
Date: Thu, 29 Mar 2018 12:13:25 +0200

[Message part 1 (text/plain, inline)]

Here is new patch changed as requested for fpm2.

[0001-gnu-packages-password-utils.scm-fpm2-New-variable.patch (text/x-patch, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #16 received at 30971-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ton <tonton <at> riseup.net>
Cc: 30971-done <at> debbugs.gnu.org
Subject: Re: [bug#30971] Add package definition for fpm2
Date: Thu, 29 Mar 2018 18:44:38 +0200

[Message part 1 (text/plain, inline)]

Ton <tonton <at> riseup.net> writes:

> Here is new patch changed as requested for fpm2.
> From 02298195711674089ce5904c3aae71f7f74f1ccd Mon Sep 17 00:00:00 2001
> From: Tonton <tonton <at> riseup.net>
> Date: Thu, 29 Mar 2018 12:11:31 +0200
> Subject: [PATCH] * gnu/packages/password-utils.scm (fpm2): New variable

Thank you!  Applied with the cosmetic changes below.

[fpm2.diff (text/x-patch, inline)]

diff --git a/gnu/packages/password-utils.scm b/gnu/packages/password-utils.scm
index 54369851b..eb2c276b3 100644
--- a/gnu/packages/password-utils.scm
+++ b/gnu/packages/password-utils.scm
@@ -664,14 +664,13 @@ by GnuPG's symmetrical encryption.")
     (arguments
      `(#:phases
        (modify-phases %standard-phases
-         (add-before
-             'configure 'pre-configure
+         (add-before 'configure 'pre-configure
            ;; The file po/POTFILES.in ends up missing for some reason in
            ;; both nix and guix builds. Adding the file with contents
            ;; found during troubleshooting.
            (lambda _
-             (let* ((port (open-output-file "po/POTFILES.in")))
-               (begin
+             (call-with-output-file "po/POTFILES.in"
+               (lambda (port)
                  (format port "data/fpm2.desktop.in
 data/fpm2.desktop.in.in
 fpm2.glade
@@ -681,13 +680,13 @@ src/fpm_file.c
 src/interface.c
 src/support.c
 fpm2.glade
-")
-                 (close-port port))))))))
+")))
+             #t)))))
     (synopsis "Manage, generate and store passwords encrypted")
     (description "FPM2 is GTK2 port from Figaro's Password Manager
 originally developed by John Conneely, with some new enhancements.
 
 Upstream development seems to have stopped.  It is therefore recommended
-to use a different password manager.  ")
+to use a different password manager.")
     (home-page "https://als.regnet.cz/fpm2/")
-     (license license:gpl2)))
+     (license license:gpl2+)))

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.