GNU bug report logs - #30970
Add package definition for screen message

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30970 in the body.
You can then email your comments to 30970 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ton <tonton <at> riseup.net>
To: guix-patches <at> gnu.org
Subject: Add package definition for screen message
Date: Wed, 28 Mar 2018 15:46:19 +0200

[Message part 1 (text/plain, inline)]

Here is the package definition for screen message. A simple program to fill
your screen with text input either as an argument to the program or input
during execution.

Built and tested on GuixSD Linux merlin 4.15.8-gnu #1 SMP 1 x86_64 GNU/Linux.

It passes guix lint without errors.

It builds 5 times deterministicly.

Guix size says "total: 568.0 MiB"

[0001-Add-package-definition-screen-message.patch (text/x-patch, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #8 received at 30970 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ton <tonton <at> riseup.net>, 30970 <at> debbugs.gnu.org
Subject: Re: [bug#30970] Add package definition for screen message
Date: Wed, 28 Mar 2018 21:46:07 +0200

[Message part 1 (text/plain, inline)]

Ton <tonton <at> riseup.net> writes:

> Here is the package definition for screen message. A simple program to fill
> your screen with text input either as an argument to the program or input
> during execution.
>
> Built and tested on GuixSD Linux merlin 4.15.8-gnu #1 SMP 1 x86_64 GNU/Linux.
>
> It passes guix lint without errors.
>
> It builds 5 times deterministicly.
>
> Guix size says "total: 568.0 MiB"

Thank you for this patch, and for testing reproducibility and linting!
I think it can go to 'xdisorg.scm' instead of a separate module.  Can
you also add a copyright line for yourself?  Pseudonyms are fine.

Overall the patch LGTM, some nitpicks:

> From c6ddc41853ff22acb3923b221b8530a057875253 Mon Sep 17 00:00:00 2001
> From: Tonton <tonton <at> riseup.net>
> Date: Wed, 28 Mar 2018 15:45:07 +0200
> Subject: [PATCH] Add package definition screen message
>
> Built and tested on GuixSD Linux merlin 4.15.8-gnu #1 SMP 1 x86_64 GNU/Linux.
>
> It passes guix lint without errors.
>
> It builds 5 times deterministicly.
>
> Guix size says "total: 568.0 MiB"

Please see 'git log' for commit message conventions.

[...]

> +(define-public screen-message
> +  (package
> +    (name "screen-message")
> +    (version "0.25")
> +    (source (origin
> +              (method url-fetch)
> +              (uri
> +               (string-append
> +                "http://www.joachim-breitner.de/archive/screen-message/screen-message-"
> +                                  version ".tar.gz"))

Use HTTPS here, and on the home page.

> +              (sha256
> +               (base32
> +                "1lw955qq5pq010lzmaf32ylj2iprgsri9ih4hx672c3f794ilab0"))))
> +    (build-system gnu-build-system)
> +    (inputs `(("gtk3" ,gtk+)
> +              ("gdk" ,gdk-pixbuf)
> +              ("pango" ,pango)))
> +    (native-inputs `(("pkgconfig" ,pkg-config)))
                            ^^^
                         "pkg-config"

> +    (arguments
> +     `(#:make-flags (list (string-append "execgamesdir=" %output "/bin"))))
> +    (synopsis "Prints messages on your screen")

s/Prints/Print/

> +    (description "If you just want to disply a word or a short, possilby
                                                                        ^^^
Typo:

> +multi-line, text as large and as quickly as possible on your screen,
> +then “screen-message” is the right tool for you.")

Use @code{screen-message} instead of quotes.

However I would rewrite this to something along the lines of
"@code{screen-message} is a tool for displaying text on your screen.  It
will make the text as large as possible and display it with black color
on a white background."

This was shamelessly adapted from Debians description, feel free to
expand on it: <https://packages.debian.org/sid/sm>.

Can you send an updated patch please?  Thanks in advance!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 30970 <at> debbugs.gnu.org (full text, mbox):

From: Ton <tonton <at> riseup.net>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 30970 <at> debbugs.gnu.org
Subject: Re: [bug#30970] Add package definition for screen message
Date: Thu, 29 Mar 2018 12:01:18 +0200

[Message part 1 (text/plain, inline)]

Here is a new patch with the requested changes.

[0001-gnu-packages-xdisorg.scm-screen-message-New-variable.patch (text/x-patch, attachment)]

[Message part 3 (application/pgp-signature, inline)]

Message #16 received at 30970-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Ton <tonton <at> riseup.net>
Cc: 30970-done <at> debbugs.gnu.org
Subject: Re: [bug#30970] Add package definition for screen message
Date: Thu, 29 Mar 2018 18:36:29 +0200

[Message part 1 (text/plain, inline)]

Ton <tonton <at> riseup.net> writes:

> Here is a new patch with the requested changes.
> From b993e9eb9ed2d7c1d8ca80a33d046c7ccf54be32 Mon Sep 17 00:00:00 2001
> From: Tonton <tonton <at> riseup.net>
> Date: Thu, 29 Mar 2018 11:38:11 +0200
> Subject: [PATCH] * gnu/packages/xdisorg.scm (screen-message): New variable

Excellent, applied with a full commit message.  Thank you!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.