GNU bug report logs - #30905
Add tests for buffer-base-buffer function

Previous Next

Full log

Message #13 received at control <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Shanavas <snavas <at> disroot.org>
Cc: 30905 <at> debbugs.gnu.org
Subject: Re: bug#30905: Add tests for buffer-base-buffer function
Date: Sun, 25 Mar 2018 07:42:04 -0400

severity 30905 wishlist
quit

Shanavas <snavas <at> disroot.org> writes:
>
> This is my first contribution to emacs. Is this patch ready to go or Am I missing something??

A couple of things.

Have assigned copyright for Emacs? (the change is small enough to
install regardless, but note that we only accept up to 15 lines worth of
unassigned code per person).

> Subject: [PATCH] Add tests for buffer-base-buffer function
>
> ---

You should add a ChangeLog style entry to the commit message, as
described in CONTRIBUTE.
  
> +(ert-deftest test-buffer-base-buffer-indirect ()
> +  (let* ((base (get-buffer-create "base")

You should rather use with-temp-buffer, so that the test will not
interfere with anything else (same for the second test).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.