GNU bug report logs - #30905
Add tests for buffer-base-buffer function

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30905 in the body.
You can then email your comments to 30905 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Shanavas M <snavas <at> disroot.org>
To: bug-gnu-emacs <at> gnu.org
Subject: Add tests for buffer-base-buffer function
Date: Thu, 22 Mar 2018 12:28:39 +0300

[Message part 1 (text/plain, inline)]

This patch adds two tests for buffer-base-buffer function


--

Shanavas M

[Add-tests-for-buffer-base-buffer-function.patch (text/x-patch, attachment)]

Message #8 received at 30905 <at> debbugs.gnu.org (full text, mbox):

From: Shanavas <snavas <at> disroot.org>
To: 30905 <at> debbugs.gnu.org
Subject: Re: bug#30905: Add tests for buffer-base-buffer function
Date: Sun, 25 Mar 2018 14:22:25 +0300

On March 22, 2018 12:28:39 PM GMT+03:00, Shanavas M <snavas <at> disroot.org> wrote:
>This patch adds two tests for buffer-base-buffer function
>
>
>--
>
>Shanavas M

This is my first contribution to emacs. Is this patch ready to go or Am I missing something??
-- 
Shanavas M

Message #11 received at 30905 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Shanavas <snavas <at> disroot.org>
Cc: 30905 <at> debbugs.gnu.org
Subject: Re: bug#30905: Add tests for buffer-base-buffer function
Date: Sun, 25 Mar 2018 07:42:04 -0400

severity 30905 wishlist
quit

Shanavas <snavas <at> disroot.org> writes:
>
> This is my first contribution to emacs. Is this patch ready to go or Am I missing something??

A couple of things.

Have assigned copyright for Emacs? (the change is small enough to
install regardless, but note that we only accept up to 15 lines worth of
unassigned code per person).

> Subject: [PATCH] Add tests for buffer-base-buffer function
>
> ---

You should add a ChangeLog style entry to the commit message, as
described in CONTRIBUTE.
  
> +(ert-deftest test-buffer-base-buffer-indirect ()
> +  (let* ((base (get-buffer-create "base")

You should rather use with-temp-buffer, so that the test will not
interfere with anything else (same for the second test).

Message #16 received at 30905 <at> debbugs.gnu.org (full text, mbox):

From: Shanavas M <shanavas <at> disroot.org>
To: 30905 <at> debbugs.gnu.org
Subject: Re: bug#30905: Add tests for buffer-base-buffer function
Date: Wed, 28 Mar 2018 12:41:40 +0300

[Message part 1 (text/plain, inline)]

On Sunday 25 March 2018 02:42 PM, Noam Postavsky wrote:

> A couple of things.
>
> Have assigned copyright for Emacs? (the change is small enough to
> install regardless, but note that we only accept up to 15 lines worth of
> unassigned code per person).
I have send the request. Waiting for reply.
> You should add a ChangeLog style entry to the commit message, as
> described in CONTRIBUTE.
Updated
>    
>> +(ert-deftest test-buffer-base-buffer-indirect ()
>> +  (let* ((base (get-buffer-create "base")
> You should rather use with-temp-buffer, so that the test will not
> interfere with anything else (same for the second test).
>
Updated.
>

[0001-Add-tests-for-buffer-base-buffer-function.patch (text/x-patch, attachment)]

Message #19 received at 30905 <at> debbugs.gnu.org (full text, mbox):

From: Shanavas M <snavas <at> disroot.org>
To: 30905 <at> debbugs.gnu.org
Subject: Re: bug#30905: Add tests for buffer-base-buffer function
Date: Wed, 11 Apr 2018 10:17:25 +0300

[Message part 1 (text/plain, inline)]

I have completed the copyright assignment.

Hope this patch is ready to go.
-- 
Shanavas M

[Message part 2 (text/html, inline)]

Message #22 received at 30905 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Shanavas M <shanavas <at> disroot.org>
Cc: 30905 <at> debbugs.gnu.org
Subject: Re: bug#30905: Add tests for buffer-base-buffer function
Date: Wed, 11 Apr 2018 21:19:03 -0400

tags 30905 fixed
close 30905 27.1
quit

Shanavas M <shanavas <at> disroot.org> writes:

>>From c1627cb453a6aceba36305417d5ac6b1e63e7021 Mon Sep 17 00:00:00 2001
> From: Shanavas M <shanavas <at> disroot.org>
> Date: Thu, 22 Mar 2018 12:20:22 +0300
> Subject: [PATCH] Add tests for buffer-base-buffer function

Pushed to master.

[1: 10f5f4361b]: 2018-04-11 21:16:49 -0400
  Add tests for buffer-base-buffer function (Bug#30905)
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=10f5f4361b9783f1cc4a683cca31ab3192fe179d

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.