GNU bug report logs - #30819
[Bug #19655] Patches for GNU Emacs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30819 in the body.
You can then email your comments to 30819 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simona Arizanova <simonikane <at> hotmail.fr>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: [Bug  #19655] Patches for GNU Emacs
Date: Wed, 14 Mar 2018 14:07:55 +0000

[Message part 1 (text/plain, inline)]

<mailto:bug-gnu-emacs <at> gnu.org>

Hello,


As I was using the last version of Emacs (27.0.50) , I noticed something that could be improved. I’m explaining :

First type C – h ? to open the Metahelp window.

Then write C – s to enable searching.

Instead of searching in the Metahelp window, the Metahelp window closes.

This is an actual bug registered as #19655 in the https://debbugs.gnu.org<https://debbugs.gnu.org/>.


Therefore I’ve decided that I could help to fix that issue.

Look forward for the patch of the corrected bug.


The function search-forward-help-for-help in the help.el allows to reasearch in the * Metahelp * window.


I look forward for your response from you soon.


Thanks.





- Arizanova Simona -

[Message part 2 (text/html, inline)]

[Actual-help.el (text/x-emacs-lisp, attachment)]

[diffActualAndNewhelp.txt (text/plain, attachment)]

[help.el (text/x-emacs-lisp, attachment)]

Message #10 received at 30819 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Simona Arizanova <simonikane <at> hotmail.fr>, 30819 <at> debbugs.gnu.org
Subject: Re: bug#30819: [Bug  #19655] Patches for GNU Emacs
Date: Thu, 15 Mar 2018 09:21:12 +0100

> The function search-forward-help-for-help in the help.el allows to
> reasearch in the * Metahelp * window.

Thank you for the patch.  I think it fixes bug 19655 so it should be
applied.

martin

PS: Please provide diffs in a way so we don't have to apply them in
reverse.  That is, when invoking diff the old file should be the first
and the new file the second argument.

Message #13 received at 30819 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Simona Arizanova <simonikane <at> hotmail.fr>, 30819 <at> debbugs.gnu.org
Subject: Re: bug#30819: [Bug  #19655] Patches for GNU Emacs
Date: Mon, 26 Mar 2018 11:01:42 +0200

Please always make sure to send a copy to the bug address too.

> I'm sorry for the delay.

My apologies.  I was delayed as well.

> Here I joined a text file that contains the diffs in the correct order.

Thank you.  But we now lost the identification of the file to be
patched.  Please try to make sure that the beginning of such a patch
appears like

--- a/lisp/help.el	2018-03-03 15:09:47.652000000 +0100
+++ b/lisp/help.el	2018-03-09 20:14:31.492000000 +0100


A few minor comments below:


-(defun search-forward-help-for-help()

Please always leave one space between function name and arguments as
in:

-(defun search-forward-help-for-help ()


-  "Allows to research forward a string into the *Metahelp* window"

Please always use active voice for doc-strings and terminate them with
a period as:

-  "Search forward *Metahelp* window."

(I think you really mean search and not "re"search forward here.)
Maybe we also should simply say "help window" instead of " *Metahelp*
window".  There is no well established nomenclature for this object
and few people have an idea what *Metahelp* stands for (and whether it
contains a leading space).


-  (interactive)
-  ;;Moves the cursor to the *Metahelp* window

Please always leave a space after a comment delimiter and use active
voice for comments as well and terminate them with a period as:

-  ;; Move cursor to the *Metahelp* window.

The

-  ;; Do incremental search forward.

below is well written in this regard.



-  (switch-to-buffer-other-window " *Metahelp*")

Can you add a comment that explains why you use
'switch-to-buffer-other-window' (and not, for example,
'pop-to-buffer') here?


-  (isearch-forward nil 1))

Please always use nil or t for inherently boolean arguments like
NO-RECURSIVE-EDIT, so

-  (isearch-forward nil t))

is preferable here.


Also, I assume that you have not signed legal papers for Emacs so we
have to mark this as a tiny change.  Correct?

Thanks again for working on this, martin

Message #18 received at 30819-done <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Simona Arizanova <simonikane <at> hotmail.fr>, 30819-done <at> debbugs.gnu.org
Subject: Re: bug#30819: [Bug  #19655] Patches for GNU Emacs
Date: Mon, 02 Apr 2018 10:53:54 +0200

Version: 27.1

>> Also, I assume that you have not signed legal papers for Emacs so we
> have to mark this as a tiny change.  Correct?
>
>
> We had no acknowledge of such papers so yes, mark it as a tiny change.

Installed as commit 956c39d11d871d1b6cdf4bc13217e9678d12fd76 on
master.  Please have a look, for example, at

https://git.savannah.gnu.org/cgit/emacs.git/log/

Thank you, martin (trying to close bugs #19655 and #30819 now)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.