GNU bug report logs - #30698
[PATCH 0/2] Add Emacs packages for HCL and Terraform.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Christopher Baines <mail <at> cbaines.net>
Subject: bug#30698: closed (Re: [bug#30698] [PATCH 1/2] gnu: Add
 emacs-hcl-mode.)
Date: Mon, 05 Mar 2018 07:51:01 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#30698: [PATCH 0/2] Add Emacs packages for HCL and Terraform.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 30698 <at> debbugs.gnu.org.

-- 
30698: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30698
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: Alex Kost <alezost <at> gmail.com>
Cc: 30698-done <at> debbugs.gnu.org
Subject: Re: [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode.
Date: Mon, 05 Mar 2018 07:50:23 +0000

[Message part 3 (text/plain, inline)]

Alex Kost <alezost <at> gmail.com> writes:

> Christopher Baines (2018-03-04 16:50 +0000) wrote:
>
>> * gnu/packages/emacs.scm (emacs-hcl-mode): New variable.
>> ---
>>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 69950cc6d..0e46c71f1 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -7313,3 +7313,26 @@ Features:
>>      (description "@code{epipe} provides an utility to use your editor in
>>  the pipeline, featuring the support for running @code{emacsclient}.")
>>      (license license:gpl3+)))
>> +
>> +(define-public emacs-hcl-mode
>> +  (package
>> +    (name "emacs-hcl-mode")
>> +    (version "0.03")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://github.com/syohex/emacs-hcl-mode/archive/"
>> +             version ".tar.gz"))
>> +       (file-name (string-append name "-" version ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "0pvw74qpwh0znqzp6syp4wxjqs7dp1hbn5h7xfk97mff9l5d8k6x"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://github.com/syohex/emacs-hcl-mode")
>> +    (synopsis "Major mode for the Hashicorp Configuration Language")
>> +    (description
>> +     "@code{emacs-hcl-mode} provides an Emacs major mode for working with
>> +@acronym{HCL, Hashicorp Configuration Language}.  It provides syntax
>> +highlighting and indentation support. ")
>                                         ^ extra space
> otherwise, looks good to me, thank you!

Great, I've removed the space, and pushed both of these patches. Thanks
for your review :)

[signature.asc (application/pgp-signature, inline)]

[Message part 5 (message/rfc822, inline)]

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Add Emacs packages for HCL and Terraform.
Date: Sun, 04 Mar 2018 16:46:49 +0000

[Message part 6 (text/plain, inline)]

Christopher Baines (2):
  gnu: Add emacs-hcl-mode.
  gnu: Add emacs-terraform-mode.

 gnu/packages/emacs.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.