GNU bug report logs - #30698
[PATCH 0/2] Add Emacs packages for HCL and Terraform.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30698 in the body.
You can then email your comments to 30698 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH 0/2] Add Emacs packages for HCL and Terraform.
Date: Sun, 04 Mar 2018 16:46:49 +0000

[Message part 1 (text/plain, inline)]

Christopher Baines (2):
  gnu: Add emacs-hcl-mode.
  gnu: Add emacs-terraform-mode.

 gnu/packages/emacs.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 47 insertions(+)

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 30698 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 30698 <at> debbugs.gnu.org
Subject: [PATCH 2/2] gnu: Add emacs-terraform-mode.
Date: Sun,  4 Mar 2018 16:50:51 +0000

---
 gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
 1 file changed, 24 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 0e46c71f1..da31f7a13 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7336,3 +7336,27 @@ the pipeline, featuring the support for running @code{emacsclient}.")
 @acronym{HCL, Hashicorp Configuration Language}.  It provides syntax
 highlighting and indentation support. ")
     (license license:gpl3+)))
+
+(define-public emacs-terraform-mode
+  (package
+    (name "emacs-terraform-mode")
+    (version "0.06")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/syohex/emacs-terraform-mode/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0h9267ifdjmcin4sj8slxydbacx4bqicbvg8pa1qq2l72h9m5381"))))
+    (build-system emacs-build-system)
+    (propagated-inputs
+     `(("emacs-hcl-mode" ,emacs-hcl-mode)))
+    (home-page "https://github.com/syohex/emacs-terraform-mode")
+    (synopsis "Major mode for Terraform")
+    (description
+     "@code{emacs-terraform-mode} provides a major mode for working with
+Terraform.  Most of the functionality is inherited from @code{hcl-mode}.")
+    (license license:gpl3+)))
-- 
2.16.1

Message #11 received at 30698 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 30698 <at> debbugs.gnu.org
Subject: [PATCH 1/2] gnu: Add emacs-hcl-mode.
Date: Sun,  4 Mar 2018 16:50:50 +0000

* gnu/packages/emacs.scm (emacs-hcl-mode): New variable.
---
 gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
index 69950cc6d..0e46c71f1 100644
--- a/gnu/packages/emacs.scm
+++ b/gnu/packages/emacs.scm
@@ -7313,3 +7313,26 @@ Features:
     (description "@code{epipe} provides an utility to use your editor in
 the pipeline, featuring the support for running @code{emacsclient}.")
     (license license:gpl3+)))
+
+(define-public emacs-hcl-mode
+  (package
+    (name "emacs-hcl-mode")
+    (version "0.03")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "https://github.com/syohex/emacs-hcl-mode/archive/"
+             version ".tar.gz"))
+       (file-name (string-append name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "0pvw74qpwh0znqzp6syp4wxjqs7dp1hbn5h7xfk97mff9l5d8k6x"))))
+    (build-system emacs-build-system)
+    (home-page "https://github.com/syohex/emacs-hcl-mode")
+    (synopsis "Major mode for the Hashicorp Configuration Language")
+    (description
+     "@code{emacs-hcl-mode} provides an Emacs major mode for working with
+@acronym{HCL, Hashicorp Configuration Language}.  It provides syntax
+highlighting and indentation support. ")
+    (license license:gpl3+)))
-- 
2.16.1

Message #14 received at 30698 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 30698 <at> debbugs.gnu.org
Subject: Re: [bug#30698] [PATCH 2/2] gnu: Add emacs-terraform-mode.
Date: Sun, 04 Mar 2018 23:21:12 +0300

Christopher Baines (2018-03-04 16:50 +0000) wrote:

> ---
>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>  1 file changed, 24 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 0e46c71f1..da31f7a13 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7336,3 +7336,27 @@ the pipeline, featuring the support for running @code{emacsclient}.")
>  @acronym{HCL, Hashicorp Configuration Language}.  It provides syntax
>  highlighting and indentation support. ")
>      (license license:gpl3+)))
> +
> +(define-public emacs-terraform-mode
> +  (package
> +    (name "emacs-terraform-mode")
> +    (version "0.06")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/syohex/emacs-terraform-mode/archive/"
> +             version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0h9267ifdjmcin4sj8slxydbacx4bqicbvg8pa1qq2l72h9m5381"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-hcl-mode" ,emacs-hcl-mode)))
> +    (home-page "https://github.com/syohex/emacs-terraform-mode")
> +    (synopsis "Major mode for Terraform")
> +    (description
> +     "@code{emacs-terraform-mode} provides a major mode for working with
> +Terraform.  Most of the functionality is inherited from @code{hcl-mode}.")

Maybe it would be good to clarify what Terraform is in the description,
for example:

"... working with @uref{https://www.terraform.io/, Terraform}
configuration files."

> +    (license license:gpl3+)))

-- 
Alex

Message #17 received at 30698 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 30698 <at> debbugs.gnu.org
Subject: Re: [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode.
Date: Sun, 04 Mar 2018 23:22:20 +0300

Christopher Baines (2018-03-04 16:50 +0000) wrote:

> * gnu/packages/emacs.scm (emacs-hcl-mode): New variable.
> ---
>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index 69950cc6d..0e46c71f1 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7313,3 +7313,26 @@ Features:
>      (description "@code{epipe} provides an utility to use your editor in
>  the pipeline, featuring the support for running @code{emacsclient}.")
>      (license license:gpl3+)))
> +
> +(define-public emacs-hcl-mode
> +  (package
> +    (name "emacs-hcl-mode")
> +    (version "0.03")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append
> +             "https://github.com/syohex/emacs-hcl-mode/archive/"
> +             version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "0pvw74qpwh0znqzp6syp4wxjqs7dp1hbn5h7xfk97mff9l5d8k6x"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/syohex/emacs-hcl-mode")
> +    (synopsis "Major mode for the Hashicorp Configuration Language")
> +    (description
> +     "@code{emacs-hcl-mode} provides an Emacs major mode for working with
> +@acronym{HCL, Hashicorp Configuration Language}.  It provides syntax
> +highlighting and indentation support. ")
                                        ^ extra space
otherwise, looks good to me, thank you!

> +    (license license:gpl3+)))

-- 
Alex

Message #20 received at 30698 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Alex Kost <alezost <at> gmail.com>
Cc: 30698 <at> debbugs.gnu.org
Subject: Re: [bug#30698] [PATCH 2/2] gnu: Add emacs-terraform-mode.
Date: Mon, 05 Mar 2018 07:44:31 +0000

[Message part 1 (text/plain, inline)]

Alex Kost <alezost <at> gmail.com> writes:

> Christopher Baines (2018-03-04 16:50 +0000) wrote:
>
>> ---
>>  gnu/packages/emacs.scm | 24 ++++++++++++++++++++++++
>>  1 file changed, 24 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 0e46c71f1..da31f7a13 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -7336,3 +7336,27 @@ the pipeline, featuring the support for running @code{emacsclient}.")
>>  @acronym{HCL, Hashicorp Configuration Language}.  It provides syntax
>>  highlighting and indentation support. ")
>>      (license license:gpl3+)))
>> +
>> +(define-public emacs-terraform-mode
>> +  (package
>> +    (name "emacs-terraform-mode")
>> +    (version "0.06")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://github.com/syohex/emacs-terraform-mode/archive/"
>> +             version ".tar.gz"))
>> +       (file-name (string-append name "-" version ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "0h9267ifdjmcin4sj8slxydbacx4bqicbvg8pa1qq2l72h9m5381"))))
>> +    (build-system emacs-build-system)
>> +    (propagated-inputs
>> +     `(("emacs-hcl-mode" ,emacs-hcl-mode)))
>> +    (home-page "https://github.com/syohex/emacs-terraform-mode")
>> +    (synopsis "Major mode for Terraform")
>> +    (description
>> +     "@code{emacs-terraform-mode} provides a major mode for working with
>> +Terraform.  Most of the functionality is inherited from @code{hcl-mode}.")
>
> Maybe it would be good to clarify what Terraform is in the description,
> for example:
>
> "... working with @uref{https://www.terraform.io/, Terraform}
> configuration files."

Sure, that sounds good, thanks for taking a look :)

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 30698-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Alex Kost <alezost <at> gmail.com>
Cc: 30698-done <at> debbugs.gnu.org
Subject: Re: [bug#30698] [PATCH 1/2] gnu: Add emacs-hcl-mode.
Date: Mon, 05 Mar 2018 07:50:23 +0000

[Message part 1 (text/plain, inline)]

Alex Kost <alezost <at> gmail.com> writes:

> Christopher Baines (2018-03-04 16:50 +0000) wrote:
>
>> * gnu/packages/emacs.scm (emacs-hcl-mode): New variable.
>> ---
>>  gnu/packages/emacs.scm | 23 +++++++++++++++++++++++
>>  1 file changed, 23 insertions(+)
>>
>> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
>> index 69950cc6d..0e46c71f1 100644
>> --- a/gnu/packages/emacs.scm
>> +++ b/gnu/packages/emacs.scm
>> @@ -7313,3 +7313,26 @@ Features:
>>      (description "@code{epipe} provides an utility to use your editor in
>>  the pipeline, featuring the support for running @code{emacsclient}.")
>>      (license license:gpl3+)))
>> +
>> +(define-public emacs-hcl-mode
>> +  (package
>> +    (name "emacs-hcl-mode")
>> +    (version "0.03")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append
>> +             "https://github.com/syohex/emacs-hcl-mode/archive/"
>> +             version ".tar.gz"))
>> +       (file-name (string-append name "-" version ".tar.gz"))
>> +       (sha256
>> +        (base32
>> +         "0pvw74qpwh0znqzp6syp4wxjqs7dp1hbn5h7xfk97mff9l5d8k6x"))))
>> +    (build-system emacs-build-system)
>> +    (home-page "https://github.com/syohex/emacs-hcl-mode")
>> +    (synopsis "Major mode for the Hashicorp Configuration Language")
>> +    (description
>> +     "@code{emacs-hcl-mode} provides an Emacs major mode for working with
>> +@acronym{HCL, Hashicorp Configuration Language}.  It provides syntax
>> +highlighting and indentation support. ")
>                                         ^ extra space
> otherwise, looks good to me, thank you!

Great, I've removed the space, and pushed both of these patches. Thanks
for your review :)

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.