GNU bug report logs - #30588
26.0.90; Documentation error in docstring of `input-method-function'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#30588: closed (26.0.90; Documentation error in docstring of
 `input-method-function')
Date: Sat, 24 Feb 2018 09:31:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 24 Feb 2018 11:31:05 +0200
with message-id <83po4u4tuu.fsf <at> gnu.org>
and subject line Re: bug#30588: 26.0.90; Documentation error in docstring of `input-method-function'
has caused the debbugs.gnu.org bug report #30588,
regarding 26.0.90; Documentation error in docstring of `input-method-function'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
30588: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30588
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Adam Tack <adam.tack.513 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.90; Documentation error in docstring of `input-method-function'
Date: Fri, 23 Feb 2018 20:43:43 +0000

The listed range of "printing characters" appears to be out of date.

Currently the docstring of `input-method-function'

(src/keyboard.c:11739
http://git.savannah.gnu.org/cgit/emacs.git/tree/src/keyboard.c?id=15863145cb8468b18b620d9dd82f90eaf4775d25#n11736
)

says that:

It’s called with one argument, a printing character that was just read.
(That means a character with code 040...0176.)

As can be seen at src/keyboard.c:2977 (with context:
http://git.savannah.gnu.org/cgit/emacs.git/tree/src/keyboard.c?id=15863145cb8468b18b620d9dd82f90eaf4775d25#n2969
) this is no longer the case (since
8d76911517ef7cefc7939845e920145ef89282f7) — the character can also be
in the range 0200...0377, so the docstring should probably say:

It’s called with one argument, a printing character that was just read.
(That means a character with code 040...0176 or 0200...0377.)

Thanks!
Adam

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Adam Tack <adam.tack.513 <at> gmail.com>
Cc: 30588-done <at> debbugs.gnu.org
Subject: Re: bug#30588: 26.0.90;
 Documentation error in docstring of `input-method-function'
Date: Sat, 24 Feb 2018 11:31:05 +0200

> From: Adam Tack <adam.tack.513 <at> gmail.com>
> Date: Fri, 23 Feb 2018 20:43:43 +0000
> 
> The listed range of "printing characters" appears to be out of date.
> 
> Currently the docstring of `input-method-function'
> 
> (src/keyboard.c:11739
> http://git.savannah.gnu.org/cgit/emacs.git/tree/src/keyboard.c?id=15863145cb8468b18b620d9dd82f90eaf4775d25#n11736
> )
> 
> says that:
> 
> It’s called with one argument, a printing character that was just read.
> (That means a character with code 040...0176.)
> 
> As can be seen at src/keyboard.c:2977 (with context:
> http://git.savannah.gnu.org/cgit/emacs.git/tree/src/keyboard.c?id=15863145cb8468b18b620d9dd82f90eaf4775d25#n2969
> ) this is no longer the case (since
> 8d76911517ef7cefc7939845e920145ef89282f7) — the character can also be
> in the range 0200...0377, so the docstring should probably say:
> 
> It’s called with one argument, a printing character that was just read.
> (That means a character with code 040...0176 or 0200...0377.)

Thanks, fixed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.