GNU bug report logs - #30588
26.0.90; Documentation error in docstring of `input-method-function'

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30588 in the body.
You can then email your comments to 30588 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Tack <adam.tack.513 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.90; Documentation error in docstring of `input-method-function'
Date: Fri, 23 Feb 2018 20:43:43 +0000

The listed range of "printing characters" appears to be out of date.

Currently the docstring of `input-method-function'

(src/keyboard.c:11739
http://git.savannah.gnu.org/cgit/emacs.git/tree/src/keyboard.c?id=15863145cb8468b18b620d9dd82f90eaf4775d25#n11736
)

says that:

It’s called with one argument, a printing character that was just read.
(That means a character with code 040...0176.)

As can be seen at src/keyboard.c:2977 (with context:
http://git.savannah.gnu.org/cgit/emacs.git/tree/src/keyboard.c?id=15863145cb8468b18b620d9dd82f90eaf4775d25#n2969
) this is no longer the case (since
8d76911517ef7cefc7939845e920145ef89282f7) — the character can also be
in the range 0200...0377, so the docstring should probably say:

It’s called with one argument, a printing character that was just read.
(That means a character with code 040...0176 or 0200...0377.)

Thanks!
Adam

Message #10 received at 30588-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Adam Tack <adam.tack.513 <at> gmail.com>
Cc: 30588-done <at> debbugs.gnu.org
Subject: Re: bug#30588: 26.0.90;
 Documentation error in docstring of `input-method-function'
Date: Sat, 24 Feb 2018 11:31:05 +0200

> From: Adam Tack <adam.tack.513 <at> gmail.com>
> Date: Fri, 23 Feb 2018 20:43:43 +0000
> 
> The listed range of "printing characters" appears to be out of date.
> 
> Currently the docstring of `input-method-function'
> 
> (src/keyboard.c:11739
> http://git.savannah.gnu.org/cgit/emacs.git/tree/src/keyboard.c?id=15863145cb8468b18b620d9dd82f90eaf4775d25#n11736
> )
> 
> says that:
> 
> It’s called with one argument, a printing character that was just read.
> (That means a character with code 040...0176.)
> 
> As can be seen at src/keyboard.c:2977 (with context:
> http://git.savannah.gnu.org/cgit/emacs.git/tree/src/keyboard.c?id=15863145cb8468b18b620d9dd82f90eaf4775d25#n2969
> ) this is no longer the case (since
> 8d76911517ef7cefc7939845e920145ef89282f7) — the character can also be
> in the range 0200...0377, so the docstring should probably say:
> 
> It’s called with one argument, a printing character that was just read.
> (That means a character with code 040...0176 or 0200...0377.)

Thanks, fixed.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.