GNU bug report logs - #30439
[PATCH] gnu: Add qqc2-desktop-style.

Previous Next

Full log

Message #11 received at 30439 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>, 30439 <at> debbugs.gnu.org
Subject: Re: [bug#30439] [PATCH] gnu: Add qqc2-desktop-style.
Date: Tue, 13 Feb 2018 23:11:05 +0100

[Message part 1 (text/plain, inline)]

Hartmut Goebel <h.goebel <at> crazy-compilers.com> writes:

> * gnu/packages/kde-frameworks.scm (qqc2-desktop-style): New
>   variable.

[...]
  
> +(define-public qqc2-desktop-style
> +  (package
> +    (name "qqc2-desktop-style")
> +    (version "5.42.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://kde/stable/frameworks/"
> +                    (version-major+minor version) "/"
> +                    name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "1arlfhcshfs11pgf87jzjgln1p711zlx0v0q014740mbzb9g5wnk"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("kauth" ,kauth)
> +       ("kconfigwidgets" ,kconfigwidgets) ;; optional
> +       ("kcoreaddons" ,kcoreaddons)
> +       ("kiconthemes" ,kiconthemes) ;; optional

Nit-pick: only a single semicolon for inline comments.

> +       ("kirigami" ,kirigami)
> +       ("qtbase" ,qtbase)
> +       ("qtdeclarative" ,qtdeclarative)))
> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "QtQuickControls2 style that integrates with the desktop")
> +    (description "This is a style for QtQuicControls2 which is using QWidget's
                                             ^^^ missing 'k'
> +QStyle to paint the controls in order to give it a native look and feel.
> +")

This can be moved to the end of the previous line.

> +    (license (list license:gpl3+ license:lgpl2.1+))))

I'm not familiar with KDE, is everything dual licensed as
GPL3+/LGPL2.1+?  If not, please add a comment explaining what is covered
by which license (or clarify whether it's dual-licensed).

Otherwise LGTM.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.