GNU bug report logs - #30439
[PATCH] gnu: Add qqc2-desktop-style.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30439 in the body.
You can then email your comments to 30439 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add qqc2-desktop-style.
Date: Mon, 12 Feb 2018 23:55:11 +0100

* gnu/packages/kde-frameworks.scm (qqc2-desktop-style): New
  variable.
---
 gnu/packages/kde-frameworks.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/kde-frameworks.scm b/gnu/packages/kde-frameworks.scm
index d5e3c796e..1b43b66ae 100644
--- a/gnu/packages/kde-frameworks.scm
+++ b/gnu/packages/kde-frameworks.scm
@@ -1275,6 +1275,38 @@ which are used in DBus communication.")
 provides uniform access to generation of barcodes with data.")
     (license license:lgpl2.1+)))
 
+(define-public qqc2-desktop-style
+  (package
+    (name "qqc2-desktop-style")
+    (version "5.42.0")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "mirror://kde/stable/frameworks/"
+                    (version-major+minor version) "/"
+                    name "-" version ".tar.xz"))
+              (sha256
+               (base32
+                "1arlfhcshfs11pgf87jzjgln1p711zlx0v0q014740mbzb9g5wnk"))))
+    (build-system cmake-build-system)
+    (native-inputs
+     `(("extra-cmake-modules" ,extra-cmake-modules)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("kauth" ,kauth)
+       ("kconfigwidgets" ,kconfigwidgets) ;; optional
+       ("kcoreaddons" ,kcoreaddons)
+       ("kiconthemes" ,kiconthemes) ;; optional
+       ("kirigami" ,kirigami)
+       ("qtbase" ,qtbase)
+       ("qtdeclarative" ,qtdeclarative)))
+    (home-page "https://community.kde.org/Frameworks")
+    (synopsis "QtQuickControls2 style that integrates with the desktop")
+    (description "This is a style for QtQuicControls2 which is using QWidget's
+QStyle to paint the controls in order to give it a native look and feel.
+")
+    (license (list license:gpl3+ license:lgpl2.1+))))
+
 (define-public solid
   (package
     (name "solid")
-- 
2.13.6

Message #8 received at 30439 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 30439 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add qqc2-desktop-style.
Date: Mon, 12 Feb 2018 23:59:35 +0100

I missed adding this in [#30398] (Update KDE Frameworks to 5.42.0 and
other KDE stuff respectively)

[#30398] http://debbugs.gnu.org/cgi/bugreport.cgi?bug=30398

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Message #11 received at 30439 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Hartmut Goebel <h.goebel <at> crazy-compilers.com>, 30439 <at> debbugs.gnu.org
Subject: Re: [bug#30439] [PATCH] gnu: Add qqc2-desktop-style.
Date: Tue, 13 Feb 2018 23:11:05 +0100

[Message part 1 (text/plain, inline)]

Hartmut Goebel <h.goebel <at> crazy-compilers.com> writes:

> * gnu/packages/kde-frameworks.scm (qqc2-desktop-style): New
>   variable.

[...]
  
> +(define-public qqc2-desktop-style
> +  (package
> +    (name "qqc2-desktop-style")
> +    (version "5.42.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append
> +                    "mirror://kde/stable/frameworks/"
> +                    (version-major+minor version) "/"
> +                    name "-" version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "1arlfhcshfs11pgf87jzjgln1p711zlx0v0q014740mbzb9g5wnk"))))
> +    (build-system cmake-build-system)
> +    (native-inputs
> +     `(("extra-cmake-modules" ,extra-cmake-modules)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("kauth" ,kauth)
> +       ("kconfigwidgets" ,kconfigwidgets) ;; optional
> +       ("kcoreaddons" ,kcoreaddons)
> +       ("kiconthemes" ,kiconthemes) ;; optional

Nit-pick: only a single semicolon for inline comments.

> +       ("kirigami" ,kirigami)
> +       ("qtbase" ,qtbase)
> +       ("qtdeclarative" ,qtdeclarative)))
> +    (home-page "https://community.kde.org/Frameworks")
> +    (synopsis "QtQuickControls2 style that integrates with the desktop")
> +    (description "This is a style for QtQuicControls2 which is using QWidget's
                                             ^^^ missing 'k'
> +QStyle to paint the controls in order to give it a native look and feel.
> +")

This can be moved to the end of the previous line.

> +    (license (list license:gpl3+ license:lgpl2.1+))))

I'm not familiar with KDE, is everything dual licensed as
GPL3+/LGPL2.1+?  If not, please add a comment explaining what is covered
by which license (or clarify whether it's dual-licensed).

Otherwise LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 30439-close <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Marius Bakke <mbakke <at> fastmail.com>, 30439-close <at> debbugs.gnu.org
Subject: Re: [bug#30439] [PATCH] gnu: Add qqc2-desktop-style.
Date: Thu, 15 Feb 2018 22:15:26 +0100

Thanks for the review. I addressed your remarks and will push it later
together with [#30398] (Update KDE Frameworks to 5.42.0 and other KDE
stuff respectively)

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.