GNU bug report logs - #30400
[PATCH] gnu: clementine: Remove Spotify downloader.

Previous Next

Full log

View this message in rfc822 format

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: 30400 <at> debbugs.gnu.org
Subject: [bug#30400] [PATCH] gnu: clementine: Remove Spotify downloader.
Date: Thu, 08 Feb 2018 23:09:19 +0000

[Message part 1 (text/plain, inline)]

Hi Guix!

I realized today that a new version of crypto++ was out so I set out to
update it but Clementine failed to compile. There's a patch on master [0]
that fixes the issue so I was going to apply it when I realized the bit
of code in question downloads a binary blob to support Spotify.  It
turns out there's a button in the preference menu that allows users to
download this proprietary blob, and crypto++ appears to be used to check
it.

So I thought that rather than apply the patch, we should probably remove
support for this download button all together. There is a flag that
allows not compiling "spotifyblobdownloader.cpp".

Also, this was also the only place in the codebase that used crypto++ so
we can drop this input.

What do you think?

[0]: https://github.com/clementine-player/Clementine/commit/38c1f8777cecc7b2f91fecbcc48c41479839304b.patch

[0001-gnu-clementine-Remove-Spotify-downloader.patch (text/x-patch, attachment)]

[0002-gnu-crypto-Update-to-6.0.0.patch (text/x-patch, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.