GNU bug report logs - #30400
[PATCH] gnu: clementine: Remove Spotify downloader.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 30400 in the body.
You can then email your comments to 30400 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Pierre Langlois <pierre.langlois <at> gmx.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: clementine: Remove Spotify downloader.
Date: Thu, 08 Feb 2018 23:09:19 +0000

[Message part 1 (text/plain, inline)]

Hi Guix!

I realized today that a new version of crypto++ was out so I set out to
update it but Clementine failed to compile. There's a patch on master [0]
that fixes the issue so I was going to apply it when I realized the bit
of code in question downloads a binary blob to support Spotify.  It
turns out there's a button in the preference menu that allows users to
download this proprietary blob, and crypto++ appears to be used to check
it.

So I thought that rather than apply the patch, we should probably remove
support for this download button all together. There is a flag that
allows not compiling "spotifyblobdownloader.cpp".

Also, this was also the only place in the codebase that used crypto++ so
we can drop this input.

What do you think?

[0]: https://github.com/clementine-player/Clementine/commit/38c1f8777cecc7b2f91fecbcc48c41479839304b.patch

[0001-gnu-clementine-Remove-Spotify-downloader.patch (text/x-patch, attachment)]

[0002-gnu-crypto-Update-to-6.0.0.patch (text/x-patch, attachment)]

Message #8 received at 30400 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Cc: 30400 <at> debbugs.gnu.org
Subject: Re: [bug#30400] [PATCH] gnu: clementine: Remove Spotify downloader.
Date: Fri, 9 Feb 2018 13:36:35 -0500

[Message part 1 (text/plain, inline)]

On Thu, Feb 08, 2018 at 11:09:19PM +0000, Pierre Langlois wrote:
> Hi Guix!
> 
> I realized today that a new version of crypto++ was out so I set out to
> update it but Clementine failed to compile. There's a patch on master [0]
> that fixes the issue so I was going to apply it when I realized the bit
> of code in question downloads a binary blob to support Spotify.  It
> turns out there's a button in the preference menu that allows users to
> download this proprietary blob, and crypto++ appears to be used to check
> it.

Thanks for pointing this out! I reindented the #:configure-flags and
added some comments to the first patch, and pushed as
af414f34fb6e3609e572880f3b0b3bbcb1b3bfc6

My understanding of the FSDG [0] makes me think that we'll need to go
further and, in an origin snippet, remove the code performs the download
of the non-free component. This would mean that `guix build --source
clementine` would return something that follows the FSDG. CC-ing Ludo
for clarification.

[0]
https://www.gnu.org/distros/free-system-distribution-guidelines.en.html

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 30400 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Cc: 30400 <at> debbugs.gnu.org
Subject: Re: [bug#30400] [PATCH] gnu: clementine: Remove Spotify downloader.
Date: Fri, 9 Feb 2018 13:37:54 -0500

[Message part 1 (text/plain, inline)]

On Thu, Feb 08, 2018 at 11:09:19PM +0000, Pierre Langlois wrote:
> From 9d9b90882491ff2ebf6f3a3580d4d7dbcdf57c72 Mon Sep 17 00:00:00 2001
> From: Pierre Langlois <pierre.langlois <at> gmx.com>
> Date: Thu, 8 Feb 2018 09:57:41 +0000
> Subject: [PATCH 2/2] gnu: crypto++: Update to 6.0.0.
> 
> * gnu/packages/crypto.scm (crypto++): Update to 6.0.0.
> * gnu/packages/patches/crypto++-fix-dos-in-asn.1-decoders.patch: Delete
> file.
> * gnu/local.mk (dist_patch_DATA): Remove it.

I didn't push this patch yet because 1) it doesn't apply and 2) I have
to go AFK now and don't have time to make it apply. I'll do it later
today unless somebody does it first.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 30400 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 30400 <at> debbugs.gnu.org, Pierre Langlois <pierre.langlois <at> gmx.com>
Subject: Re: [bug#30400] [PATCH] gnu: clementine: Remove Spotify downloader.
Date: Fri, 09 Feb 2018 23:12:03 +0100

Hello,

Leo Famulari <leo <at> famulari.name> skribis:

> On Thu, Feb 08, 2018 at 11:09:19PM +0000, Pierre Langlois wrote:
>> Hi Guix!
>> 
>> I realized today that a new version of crypto++ was out so I set out to
>> update it but Clementine failed to compile. There's a patch on master [0]
>> that fixes the issue so I was going to apply it when I realized the bit
>> of code in question downloads a binary blob to support Spotify.  It
>> turns out there's a button in the preference menu that allows users to
>> download this proprietary blob, and crypto++ appears to be used to check
>> it.
>
> Thanks for pointing this out! I reindented the #:configure-flags and
> added some comments to the first patch, and pushed as
> af414f34fb6e3609e572880f3b0b3bbcb1b3bfc6
>
> My understanding of the FSDG [0] makes me think that we'll need to go
> further and, in an origin snippet, remove the code performs the download
> of the non-free component. This would mean that `guix build --source
> clementine` would return something that follows the FSDG. CC-ing Ludo
> for clarification.

Correct, removal of non-free code should go in ‘snippet’ for the reason
you gave.

Thanks for looking into it,
Ludo’.

Message #19 received at 30400-done <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Leo Famulari <leo <at> famulari.name>
Cc: 30400-done <at> debbugs.gnu.org, Pierre Langlois <pierre.langlois <at> gmx.com>
Subject: Re: [bug#30400] [PATCH] gnu: clementine: Remove Spotify downloader.
Date: Thu, 15 Feb 2018 10:33:24 +0100

Leo Famulari <leo <at> famulari.name> skribis:

> On Thu, Feb 08, 2018 at 11:09:19PM +0000, Pierre Langlois wrote:
>> From 9d9b90882491ff2ebf6f3a3580d4d7dbcdf57c72 Mon Sep 17 00:00:00 2001
>> From: Pierre Langlois <pierre.langlois <at> gmx.com>
>> Date: Thu, 8 Feb 2018 09:57:41 +0000
>> Subject: [PATCH 2/2] gnu: crypto++: Update to 6.0.0.
>> 
>> * gnu/packages/crypto.scm (crypto++): Update to 6.0.0.
>> * gnu/packages/patches/crypto++-fix-dos-in-asn.1-decoders.patch: Delete
>> file.
>> * gnu/local.mk (dist_patch_DATA): Remove it.
>
> I didn't push this patch yet because 1) it doesn't apply and 2) I have
> to go AFK now and don't have time to make it apply. I'll do it later
> today unless somebody does it first.

Pushed as 6ca15c9ef615979862a07c02bd316e7f12a0c7ca.

Thanks!

Ludo'.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.