GNU bug report logs - #3037
23.0.92; rcirc picks incorrect connection settings

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Yann Hodique <yann.hodique <at> gmail.com>
Subject: bug#3037 closed by Chong Yidong <cyd <at> stupidchicken.com> (Re: 
 23.0.92; rcirc picks incorrect connection settings)
Date: Sat, 18 Apr 2009 03:50:03 +0000

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#3037: 23.0.92; rcirc picks incorrect connection settings

It has been closed by Chong Yidong <cyd <at> stupidchicken.com>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Chong Yidong <cyd <at> stupidchicken.com> by
replying to this email.


-- 
3037: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3037
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Yann Hodique <yann.hodique <at> gmail.com>
Cc: Ryan Yeske <rcyeske <at> gmail.com>, 3037-done <at> debbugs.gnu.org
Subject: Re: 23.0.92; rcirc picks incorrect connection settings
Date: Fri, 17 Apr 2009 23:47:07 -0400

> When using `rcirc' with argument (prompt for connection parameters), the
> global default values for :port, :nick and :channels are proposed
> instead of the server-specific ones. 
>
> Reason is that current code tries to get properties 'port, 'nick
> and 'channels, which is not correct.
> Following patch fixes this issue.

I've checked in your patch.  Thanks.

[Message part 3 (message/rfc822, inline)]

From: Yann Hodique <yann.hodique <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.92; rcirc picks incorrect connection settings
Date: Fri, 17 Apr 2009 17:48:19 +0200

When using `rcirc' with argument (prompt for connection parameters), the
global default values for :port, :nick and :channels are proposed
instead of the server-specific ones. 

Reason is that current code tries to get properties 'port, 'nick
and 'channels, which is not correct.
Following patch fixes this issue.

Yann.

diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index f63237f..1f31284 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -375,16 +375,16 @@ If ARG is non-nil, instead prompt for connection parameters."
             (server-plist (cdr (assoc-string server rcirc-server-alist)))
             (port (read-string "IRC Port: "
                                (number-to-string
-                                (or (plist-get server-plist 'port)
+                                (or (plist-get server-plist :port)
                                     rcirc-default-port))))
             (nick (read-string "IRC Nick: "
-                               (or (plist-get server-plist 'nick)
+                               (or (plist-get server-plist :nick)
                                    rcirc-default-nick)))
             (channels (split-string
                        (read-string "IRC Channels: "
                                     (mapconcat 'identity
                                                (plist-get server-plist
-                                                          'channels)
+                                                          :channels)
                                                " "))
                        "[, ]+" t)))
        (rcirc-connect server port nick rcirc-default-user-name

-- 
"Once more the drama begins."

-The Emperor Paul Muad'dib on his ascension to the Lion Throne

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.