GNU bug report logs - #3037
23.0.92; rcirc picks incorrect connection settings

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 3037 in the body.
You can then email your comments to 3037 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Yann Hodique <yann.hodique <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.92; rcirc picks incorrect connection settings
Date: Fri, 17 Apr 2009 17:48:19 +0200

When using `rcirc' with argument (prompt for connection parameters), the
global default values for :port, :nick and :channels are proposed
instead of the server-specific ones. 

Reason is that current code tries to get properties 'port, 'nick
and 'channels, which is not correct.
Following patch fixes this issue.

Yann.

diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index f63237f..1f31284 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -375,16 +375,16 @@ If ARG is non-nil, instead prompt for connection parameters."
             (server-plist (cdr (assoc-string server rcirc-server-alist)))
             (port (read-string "IRC Port: "
                                (number-to-string
-                                (or (plist-get server-plist 'port)
+                                (or (plist-get server-plist :port)
                                     rcirc-default-port))))
             (nick (read-string "IRC Nick: "
-                               (or (plist-get server-plist 'nick)
+                               (or (plist-get server-plist :nick)
                                    rcirc-default-nick)))
             (channels (split-string
                        (read-string "IRC Channels: "
                                     (mapconcat 'identity
                                                (plist-get server-plist
-                                                          'channels)
+                                                          :channels)
                                                " "))
                        "[, ]+" t)))
        (rcirc-connect server port nick rcirc-default-user-name

-- 
"Once more the drama begins."

-The Emperor Paul Muad'dib on his ascension to the Lion Throne

Message #10 received at 3037 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Ryan Yeske <rcyeske <at> gmail.com>
Cc: 3037 <at> debbugs.gnu.org
Subject: Re: 23.0.92; rcirc picks incorrect connection settings
Date: Fri, 17 Apr 2009 21:52:00 -0400

Hi Ryan,

Could you evaluate the bug report for RCIRC at the following URL?  Is
the patch attached in the report OK to commit?

http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3037

Message #15 received at 3037 <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Ryan Yeske <rcyeske <at> gmail.com>
To: Chong Yidong <cyd <at> stupidchicken.com>
Cc: 3037 <at> debbugs.gnu.org
Subject: Re: 23.0.92; rcirc picks incorrect connection settings
Date: Fri, 17 Apr 2009 19:30:28 -0700

Chong Yidong <cyd <at> stupidchicken.com> writes:

> Hi Ryan,
>
> Could you evaluate the bug report for RCIRC at the following URL?  Is
> the patch attached in the report OK to commit?
>
> http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3037

Yes, that is exactly the fix for that issue.

Message #20 received at 3037-done <at> emacsbugs.donarmstrong.com (full text, mbox):

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Yann Hodique <yann.hodique <at> gmail.com>
Cc: Ryan Yeske <rcyeske <at> gmail.com>, 3037-done <at> debbugs.gnu.org
Subject: Re: 23.0.92; rcirc picks incorrect connection settings
Date: Fri, 17 Apr 2009 23:47:07 -0400

> When using `rcirc' with argument (prompt for connection parameters), the
> global default values for :port, :nick and :channels are proposed
> instead of the server-specific ones. 
>
> Reason is that current code tries to get properties 'port, 'nick
> and 'channels, which is not correct.
> Following patch fixes this issue.

I've checked in your patch.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.