GNU bug report logs - #3037
23.0.92; rcirc picks incorrect connection settings

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Chong Yidong <cyd <at> stupidchicken.com>
Subject: bug#3037: marked as done (23.0.92; rcirc picks incorrect 
 connection settings)
Date: Sat, 18 Apr 2009 03:50:03 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 17 Apr 2009 23:47:07 -0400
with message-id <87eivqipxg.fsf <at> cyd.mit.edu>
and subject line Re: 23.0.92; rcirc picks incorrect connection settings
has caused the Emacs bug report #3037,
regarding 23.0.92; rcirc picks incorrect connection settings
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact help-debbugs <at> gnu.org
immediately.)


-- 
3037: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3037
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Yann Hodique <yann.hodique <at> gmail.com>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.92; rcirc picks incorrect connection settings
Date: Fri, 17 Apr 2009 17:48:19 +0200

When using `rcirc' with argument (prompt for connection parameters), the
global default values for :port, :nick and :channels are proposed
instead of the server-specific ones. 

Reason is that current code tries to get properties 'port, 'nick
and 'channels, which is not correct.
Following patch fixes this issue.

Yann.

diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
index f63237f..1f31284 100644
--- a/lisp/net/rcirc.el
+++ b/lisp/net/rcirc.el
@@ -375,16 +375,16 @@ If ARG is non-nil, instead prompt for connection parameters."
             (server-plist (cdr (assoc-string server rcirc-server-alist)))
             (port (read-string "IRC Port: "
                                (number-to-string
-                                (or (plist-get server-plist 'port)
+                                (or (plist-get server-plist :port)
                                     rcirc-default-port))))
             (nick (read-string "IRC Nick: "
-                               (or (plist-get server-plist 'nick)
+                               (or (plist-get server-plist :nick)
                                    rcirc-default-nick)))
             (channels (split-string
                        (read-string "IRC Channels: "
                                     (mapconcat 'identity
                                                (plist-get server-plist
-                                                          'channels)
+                                                          :channels)
                                                " "))
                        "[, ]+" t)))
        (rcirc-connect server port nick rcirc-default-user-name

-- 
"Once more the drama begins."

-The Emperor Paul Muad'dib on his ascension to the Lion Throne

[Message part 3 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Yann Hodique <yann.hodique <at> gmail.com>
Cc: Ryan Yeske <rcyeske <at> gmail.com>, 3037-done <at> debbugs.gnu.org
Subject: Re: 23.0.92; rcirc picks incorrect connection settings
Date: Fri, 17 Apr 2009 23:47:07 -0400

> When using `rcirc' with argument (prompt for connection parameters), the
> global default values for :port, :nick and :channels are proposed
> instead of the server-specific ones. 
>
> Reason is that current code tries to get properties 'port, 'nick
> and 'channels, which is not correct.
> Following patch fixes this issue.

I've checked in your patch.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.