GNU bug report logs - #29729
[PATCH] Support French password prompts in shell

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#29729: closed ([PATCH] Support French password prompts in shell)
Date: Fri, 22 Dec 2017 14:14:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 22 Dec 2017 16:13:09 +0200
with message-id <83zi6alukq.fsf <at> gnu.org>
and subject line Re: bug#29729: [PATCH] Support French password prompts in shell
has caused the debbugs.gnu.org bug report #29729,
regarding [PATCH] Support French password prompts in shell
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
29729: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29729
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ian Johnson <ianprime0509 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Support French password prompts in shell
Date: Fri, 15 Dec 2017 21:19:10 -0500

[Message part 3 (text/plain, inline)]

I noticed that French password prompts in `shell-mode' weren't detected
as such by `comint-watch-for-password-prompt' due to a space between the
password prompt and the colon (as in `Mot de passe :'), so I modified
`comint-password-prompt-regexp' to detect this space (as well as
non-breaking spaces before and after the colon, which is used by sudo).

Please let me know if I missed anything, as this is my first patch.
Thank you!

[0001-Support-French-password-prompts-in-shell.patch (text/x-patch, inline)]

From 0d6d4e79e8fe94ae2f7424c2fac1b50b49d891d6 Mon Sep 17 00:00:00 2001
From: Ian Johnson <ianprime0509 <at> gmail.com>
Date: Fri, 15 Dec 2017 21:03:22 -0500
Subject: [PATCH] Support French password prompts in shell

French punctuation rules require a space (preferably non-breaking)
before the colon, but password prompts following this rule were not
identified properly by `comint-watch-for-password-prompt'.

 * lisp/comint.el (comint-password-prompt-regexp): support
   spaces (including non-breaking spaces) before and after password
   prompt colon.
---
 lisp/comint.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/comint.el b/lisp/comint.el
index aa7dab28f3..414ffd0f49 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -363,7 +363,7 @@ comint-password-prompt-regexp
    "\\(?:" (regexp-opt password-word-equivalents) "\\|Response\\)"
    "\\(?:\\(?:, try\\)? *again\\| (empty for no passphrase)\\| (again)\\)?"
    ;; "[[:alpha:]]" used to be "for", which fails to match non-English.
-   "\\(?: [[:alpha:]]+ .+\\)?[:：៖]\\s *\\'")
+   "\\(?: [[:alpha:]]+ .+\\)?[\\s  ]*[:：៖][\\s  ]*\\'")
   "Regexp matching prompts for passwords in the inferior process.
 This is used by `comint-watch-for-password-prompt'."
   :version "26.1"
-- 
2.15.1

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ian Johnson <ianprime0509 <at> gmail.com>
Cc: 29729-done <at> debbugs.gnu.org
Subject: Re: bug#29729: [PATCH] Support French password prompts in shell
Date: Fri, 22 Dec 2017 16:13:09 +0200

> From: Ian Johnson <ianprime0509 <at> gmail.com>
> Date: Fri, 15 Dec 2017 21:19:10 -0500
> 
> I noticed that French password prompts in `shell-mode' weren't detected
> as such by `comint-watch-for-password-prompt' due to a space between the
> password prompt and the colon (as in `Mot de passe :'), so I modified
> `comint-password-prompt-regexp' to detect this space (as well as
> non-breaking spaces before and after the colon, which is used by sudo).

Thanks, pushed to the master branch.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.