GNU bug report logs - #29729
[PATCH] Support French password prompts in shell

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29729 in the body.
You can then email your comments to 29729 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ian Johnson <ianprime0509 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Support French password prompts in shell
Date: Fri, 15 Dec 2017 21:19:10 -0500

[Message part 1 (text/plain, inline)]

I noticed that French password prompts in `shell-mode' weren't detected
as such by `comint-watch-for-password-prompt' due to a space between the
password prompt and the colon (as in `Mot de passe :'), so I modified
`comint-password-prompt-regexp' to detect this space (as well as
non-breaking spaces before and after the colon, which is used by sudo).

Please let me know if I missed anything, as this is my first patch.
Thank you!

[0001-Support-French-password-prompts-in-shell.patch (text/x-patch, inline)]

From 0d6d4e79e8fe94ae2f7424c2fac1b50b49d891d6 Mon Sep 17 00:00:00 2001
From: Ian Johnson <ianprime0509 <at> gmail.com>
Date: Fri, 15 Dec 2017 21:03:22 -0500
Subject: [PATCH] Support French password prompts in shell

French punctuation rules require a space (preferably non-breaking)
before the colon, but password prompts following this rule were not
identified properly by `comint-watch-for-password-prompt'.

 * lisp/comint.el (comint-password-prompt-regexp): support
   spaces (including non-breaking spaces) before and after password
   prompt colon.
---
 lisp/comint.el | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lisp/comint.el b/lisp/comint.el
index aa7dab28f3..414ffd0f49 100644
--- a/lisp/comint.el
+++ b/lisp/comint.el
@@ -363,7 +363,7 @@ comint-password-prompt-regexp
    "\\(?:" (regexp-opt password-word-equivalents) "\\|Response\\)"
    "\\(?:\\(?:, try\\)? *again\\| (empty for no passphrase)\\| (again)\\)?"
    ;; "[[:alpha:]]" used to be "for", which fails to match non-English.
-   "\\(?: [[:alpha:]]+ .+\\)?[:：៖]\\s *\\'")
+   "\\(?: [[:alpha:]]+ .+\\)?[\\s  ]*[:：៖][\\s  ]*\\'")
   "Regexp matching prompts for passwords in the inferior process.
 This is used by `comint-watch-for-password-prompt'."
   :version "26.1"
-- 
2.15.1

Message #10 received at 29729-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Ian Johnson <ianprime0509 <at> gmail.com>
Cc: 29729-done <at> debbugs.gnu.org
Subject: Re: bug#29729: [PATCH] Support French password prompts in shell
Date: Fri, 22 Dec 2017 16:13:09 +0200

> From: Ian Johnson <ianprime0509 <at> gmail.com>
> Date: Fri, 15 Dec 2017 21:19:10 -0500
> 
> I noticed that French password prompts in `shell-mode' weren't detected
> as such by `comint-watch-for-password-prompt' due to a space between the
> password prompt and the colon (as in `Mot de passe :'), so I modified
> `comint-password-prompt-regexp' to detect this space (as well as
> non-breaking spaces before and after the colon, which is used by sudo).

Thanks, pushed to the master branch.

Message #19 received at 29729 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Ian Johnson <ianprime0509 <at> gmail.com>
Cc: 29729 <at> debbugs.gnu.org
Subject: Re: bug#29729: [PATCH] Support French password prompts in shell
Date: Wed, 15 Aug 2018 20:30:43 -0400

Ian Johnson <ianprime0509 <at> gmail.com> writes:

> +   "\\(?: [[:alpha:]]+ .+\\)?[\\s  ]*[:：៖][\\s  ]*\\'")

Actually, shouldn't that [\\s  ] be [[:whitespace:] ] (and perhaps
better written [[:whitespace:]\u00A0])?  [\\s ] matches backslash, "s",
and space, not whitespace syntax characters.

Or maybe it should rather be [[:blank:]].

Message #22 received at 29729 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Noam Postavsky <npostavs <at> gmail.com>
Cc: 29729 <at> debbugs.gnu.org, ianprime0509 <at> gmail.com
Subject: Re: bug#29729: [PATCH] Support French password prompts in shell
Date: Thu, 16 Aug 2018 16:27:07 +0300

> From: Noam Postavsky <npostavs <at> gmail.com>
> Date: Wed, 15 Aug 2018 20:30:43 -0400
> Cc: 29729 <at> debbugs.gnu.org
> 
> Ian Johnson <ianprime0509 <at> gmail.com> writes:
> 
> > +   "\\(?: [[:alpha:]]+ .+\\)?[\\s  ]*[:：៖][\\s  ]*\\'")
> 
> Actually, shouldn't that [\\s  ] be [[:whitespace:] ] (and perhaps
> better written [[:whitespace:]\u00A0])?  [\\s ] matches backslash, "s",
> and space, not whitespace syntax characters.
> 
> Or maybe it should rather be [[:blank:]].

I think [:blank:] is indeed what is needed here.

Message #25 received at 29729 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 29729 <at> debbugs.gnu.org, ianprime0509 <at> gmail.com
Subject: Re: bug#29729: [PATCH] Support French password prompts in shell
Date: Fri, 24 Aug 2018 07:49:45 -0400

tags 29729 fixed
quit

Eli Zaretskii <eliz <at> gnu.org> writes:

>> > +   "\\(?: [[:alpha:]]+ .+\\)?[\\s  ]*[:：៖][\\s  ]*\\'")
>> 
>> Actually, shouldn't that [\\s  ] be [[:whitespace:] ] (and perhaps
>> better written [[:whitespace:]\u00A0])?  [\\s ] matches backslash, "s",
>> and space, not whitespace syntax characters.
>> 
>> Or maybe it should rather be [[:blank:]].
>
> I think [:blank:] is indeed what is needed here.

Done in master.

[1: 74277b0e88]: 2018-08-23 22:49:04 -0400
  Fix comint-password-prompt-regexp
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=74277b0e88197c169acfc16025e0e116230c021e

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.