GNU bug report logs - #29583
25.2.50; Allow setting a custom TERM for comint

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29583 in the body.
You can then email your comments to 29583 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Allen Li <vianchielfaura <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 25.2.50; Allow setting a custom TERM for comint
Date: Tue, 5 Dec 2017 12:40:42 -0800

comint hard codes TERM=dumb  The user can ship their own terminfo
configuration for Emacs/comint to enable color, but comint does not
currently expose a way to use such a custom terminfo entry.

In GNU Emacs 25.2.50.1 (x86_64-pc-linux-gnu, GTK+ Version 3.22.11),
modified by Debian
Windowing system distributor 'The X.Org Foundation', version 11.0.11903000

Message #8 received at 29583 <at> debbugs.gnu.org (full text, mbox):

From: Allen Li <vianchielfaura <at> gmail.com>
To: 29583 <at> debbugs.gnu.org
Subject: [PATCH] 25.2.50; Allow setting a custom TERM for comint
Date: Tue, 5 Dec 2017 14:08:08 -0800

[Message part 1 (text/plain, inline)]

I have attached a patch for this.

[0001-Add-option-to-configure-comint-TERM.patch (text/x-patch, attachment)]

Message #11 received at 29583 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Allen Li <vianchielfaura <at> gmail.com>
Cc: 29583 <at> debbugs.gnu.org
Subject: Re: bug#29583: [PATCH] 25.2.50; Allow setting a custom TERM for comint
Date: Tue, 12 Dec 2017 10:16:10 +0100

Allen Li <vianchielfaura <at> gmail.com> writes:

Hi Allen,

> +@vindex comint-terminfo-terminal
> +Emacs sets the @code{TERM} environment variable to a safe value, but
> +this value may not reflect the full features of comint.  For example,
> +color is disabled for some applications that use @code{TERM} to
> +determine if color is supported.  On systems that use terminfo, you
> +can configure @code{comint-terminfo-terminal} to a terminal that is
> +present in your system's terminfo database.

You might mention that some applications will override this. For
example, Tramp will always use `tramp-terminal-type' (which is
"dumb"). This is because Tramp will run into problems if color is enabled.

Btw, environment variables in the Emacs manual are emphazised as @env{TERM}.

Best regards, Michael.

Message #14 received at 29583 <at> debbugs.gnu.org (full text, mbox):

From: Allen Li <vianchielfaura <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 29583 <at> debbugs.gnu.org
Subject: Re: bug#29583: [PATCH] 25.2.50; Allow setting a custom TERM for comint
Date: Tue, 12 Dec 2017 19:35:47 -0800

[Message part 1 (text/plain, inline)]

On Tue, Dec 12, 2017 at 1:16 AM, Michael Albinus <michael.albinus <at> gmx.de> wrote:
> Allen Li <vianchielfaura <at> gmail.com> writes:
>
> Hi Allen,
>
>> +@vindex comint-terminfo-terminal
>> +Emacs sets the @code{TERM} environment variable to a safe value, but
>> +this value may not reflect the full features of comint.  For example,
>> +color is disabled for some applications that use @code{TERM} to
>> +determine if color is supported.  On systems that use terminfo, you
>> +can configure @code{comint-terminfo-terminal} to a terminal that is
>> +present in your system's terminfo database.
>
> You might mention that some applications will override this. For
> example, Tramp will always use `tramp-terminal-type' (which is
> "dumb"). This is because Tramp will run into problems if color is enabled.
>
> Btw, environment variables in the Emacs manual are emphazised as @env{TERM}.
>
> Best regards, Michael.

Thanks, fixed to use @env.  I've changed it to say that Comint uses
this, rather than Emacs.  Naturally, derived modes may override this
behavior; I don't think it's necessary to point that out unless it
turns out to be a common misconception.

[0001-Add-option-to-configure-comint-TERM.patch (text/x-patch, attachment)]

Message #17 received at 29583 <at> debbugs.gnu.org (full text, mbox):

From: Noam Postavsky <npostavs <at> gmail.com>
To: Allen Li <vianchielfaura <at> gmail.com>
Cc: 29583 <at> debbugs.gnu.org, Michael Albinus <michael.albinus <at> gmx.de>
Subject: Re: bug#29583: [PATCH] 25.2.50; Allow setting a custom TERM for comint
Date: Tue, 05 Jun 2018 20:22:56 -0400

tags 29583 fixed
close 29583 26.1
quit

Allen Li <vianchielfaura <at> gmail.com> writes:

> Subject: [PATCH] Add option to configure comint TERM

It was pushed.

[1: 8ed529f0f3]: 2017-12-15 11:30:25 +0200
  Add option to configure comint TERM
  https://git.savannah.gnu.org/cgit/emacs.git/commit/?id=8ed529f0f300487600ac49cff22cce09c45db94b

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.