GNU bug report logs - #29582
[PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29582 in the body.
You can then email your comments to 29582 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.
Date: Tue, 05 Dec 2017 23:31:30 +0300

[Message part 1 (text/plain, inline)]

Hello, what about renaming 'git-modes' to 'emacs-git-modes' (similarly
to 'emacs-paredit')?

[0001-gnu-git-modes-Rename-to-emacs-git-modes.patch (text/x-patch, attachment)]

Message #8 received at 29582 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Alex Kost <alezost <at> gmail.com>, 29582 <at> debbugs.gnu.org
Subject: Re: [bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.
Date: Tue, 05 Dec 2017 16:23:56 -0500

Alex Kost <alezost <at> gmail.com> writes:

> Hello, what about renaming 'git-modes' to 'emacs-git-modes' (similarly
> to 'emacs-paredit')?

I'd like that.  Should magit and magit-svn also be converted to the
"emacs-" prefix?

-- 
Kyle

Message #11 received at 29582 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Kyle Meyer <kyle <at> kyleam.com>
Cc: 29582 <at> debbugs.gnu.org
Subject: Re: [bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.
Date: Wed, 06 Dec 2017 22:16:12 +0300

Kyle Meyer (2017-12-05 16:23 -0500) wrote:

> Alex Kost <alezost <at> gmail.com> writes:
>
>> Hello, what about renaming 'git-modes' to 'emacs-git-modes' (similarly
>> to 'emacs-paredit')?
>
> I'd like that.  Should magit and magit-svn also be converted to the
> "emacs-" prefix?

I don't know whether there is a strict policy to prefix all emacs
packages.  But I would prefer to leave "magit" ("magit-svn" therefore)
and "geiser" as they are now (without "emacs-" prefix).  For some reason
it looks more natural to me :-)

-- 
Alex

Message #14 received at 29582 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Alex Kost <alezost <at> gmail.com>
Cc: Kyle Meyer <kyle <at> kyleam.com>, 29582 <at> debbugs.gnu.org
Subject: Re: [bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.
Date: Wed, 6 Dec 2017 14:51:30 -0500

[Message part 1 (text/plain, inline)]

On Wed, Dec 06, 2017 at 10:16:12PM +0300, Alex Kost wrote:
> Kyle Meyer (2017-12-05 16:23 -0500) wrote:
> 
> > Alex Kost <alezost <at> gmail.com> writes:
> >
> >> Hello, what about renaming 'git-modes' to 'emacs-git-modes' (similarly
> >> to 'emacs-paredit')?
> >
> > I'd like that.  Should magit and magit-svn also be converted to the
> > "emacs-" prefix?
> 
> I don't know whether there is a strict policy to prefix all emacs
> packages.  But I would prefer to leave "magit" ("magit-svn" therefore)
> and "geiser" as they are now (without "emacs-" prefix).  For some reason
> it looks more natural to me :-)

Usually when we prefix package names, we only do it for libraries, but
not for end-user applications.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 29582 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: Kyle Meyer <kyle <at> kyleam.com>, 29582 <at> debbugs.gnu.org
Subject: Re: [bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.
Date: Thu, 07 Dec 2017 23:26:07 +0300

Leo Famulari (2017-12-06 14:51 -0500) wrote:

> On Wed, Dec 06, 2017 at 10:16:12PM +0300, Alex Kost wrote:
>> Kyle Meyer (2017-12-05 16:23 -0500) wrote:
>> 
>> > Alex Kost <alezost <at> gmail.com> writes:
>> >
>> >> Hello, what about renaming 'git-modes' to 'emacs-git-modes' (similarly
>> >> to 'emacs-paredit')?
>> >
>> > I'd like that.  Should magit and magit-svn also be converted to the
>> > "emacs-" prefix?
>> 
>> I don't know whether there is a strict policy to prefix all emacs
>> packages.  But I would prefer to leave "magit" ("magit-svn" therefore)
>> and "geiser" as they are now (without "emacs-" prefix).  For some reason
>> it looks more natural to me :-)
>
> Usually when we prefix package names, we only do it for libraries, but
> not for end-user applications.

Then I'm lost here: it is absolutely not clear for me where the border
between libraries and end-user applications lies in the Emacs world.
Such things as "emacs-dash" or "emacs-s" are definitely libraries but
most of the other Emacs packages are intended for users but we still
prefix them ("emacs-auctex", "emacs-pdf-tools", etc.)

-- 
Alex

Message #20 received at 29582 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Alex Kost <alezost <at> gmail.com>
Cc: Kyle Meyer <kyle <at> kyleam.com>, 29582 <at> debbugs.gnu.org
Subject: Re: [bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.
Date: Thu, 7 Dec 2017 15:53:48 -0500

[Message part 1 (text/plain, inline)]

On Thu, Dec 07, 2017 at 11:26:07PM +0300, Alex Kost wrote:
> Leo Famulari (2017-12-06 14:51 -0500) wrote:
> > Usually when we prefix package names, we only do it for libraries, but
> > not for end-user applications.
> 
> Then I'm lost here: it is absolutely not clear for me where the border
> between libraries and end-user applications lies in the Emacs world.
> Such things as "emacs-dash" or "emacs-s" are definitely libraries but
> most of the other Emacs packages are intended for users but we still
> prefix them ("emacs-auctex", "emacs-pdf-tools", etc.)

I was giving some background on how we handle this for other packages,
but not giving specific instructions for Emacs packages, which I have no
experience with.

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 29582 <at> debbugs.gnu.org (full text, mbox):

From: ludo <at> gnu.org (Ludovic Courtès)
To: Alex Kost <alezost <at> gmail.com>
Cc: 29582 <at> debbugs.gnu.org, Leo Famulari <leo <at> famulari.name>
Subject: Re: [bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.
Date: Fri, 08 Dec 2017 10:44:26 +0100

Hi,

Alex Kost <alezost <at> gmail.com> skribis:

> Then I'm lost here: it is absolutely not clear for me where the border
> between libraries and end-user applications lies in the Emacs world.
> Such things as "emacs-dash" or "emacs-s" are definitely libraries but
> most of the other Emacs packages are intended for users but we still
> prefix them ("emacs-auctex", "emacs-pdf-tools", etc.)

“emacs-git-modes” looks appropriate to me here and consistent with the
choices we’ve made so far.

Thanks Alex,
Ludo’.

Message #26 received at 29582 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Alex Kost <alezost <at> gmail.com>
Cc: 29582 <at> debbugs.gnu.org
Subject: Re: [bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.
Date: Sat, 09 Dec 2017 10:51:24 -0500

Alex Kost <alezost <at> gmail.com> writes:

> Kyle Meyer (2017-12-05 16:23 -0500) wrote:
>
>> Alex Kost <alezost <at> gmail.com> writes:
>>
>>> Hello, what about renaming 'git-modes' to 'emacs-git-modes' (similarly
>>> to 'emacs-paredit')?
>>
>> I'd like that.  Should magit and magit-svn also be converted to the
>> "emacs-" prefix?
>
> I don't know whether there is a strict policy to prefix all emacs
> packages.  But I would prefer to leave "magit" ("magit-svn" therefore)
> and "geiser" as they are now (without "emacs-" prefix).  For some reason
> it looks more natural to me :-)

Well, can't argue with looks :)

I prefer "emacs-" for consistency, but the practical reason I want it is
so that emacs-packages? recognizes magit.  That way, if I package some
magit extensions, I don't need to manually tweak the load path in their
package definitions (I think, at least; was looking at the issue a while
back).

Anyway, that's of course a minor "issue" and not necessarily a good
reason to prefix magit.  Your patch just reminded me.

-- 
Kyle

Message #29 received at 29582 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Kyle Meyer <kyle <at> kyleam.com>
Cc: 29582 <at> debbugs.gnu.org
Subject: Re: [bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.
Date: Sun, 10 Dec 2017 22:41:19 +0300

Kyle Meyer (2017-12-09 10:51 -0500) wrote:

> Alex Kost <alezost <at> gmail.com> writes:
>
>> Kyle Meyer (2017-12-05 16:23 -0500) wrote:
>>
>>> Alex Kost <alezost <at> gmail.com> writes:
>>>
>>>> Hello, what about renaming 'git-modes' to 'emacs-git-modes' (similarly
>>>> to 'emacs-paredit')?
>>>
>>> I'd like that.  Should magit and magit-svn also be converted to the
>>> "emacs-" prefix?
>>
>> I don't know whether there is a strict policy to prefix all emacs
>> packages.  But I would prefer to leave "magit" ("magit-svn" therefore)
>> and "geiser" as they are now (without "emacs-" prefix).  For some reason
>> it looks more natural to me :-)
>
> Well, can't argue with looks :)
>
> I prefer "emacs-" for consistency, but the practical reason I want it is
> so that emacs-packages? recognizes magit.  That way, if I package some
> magit extensions, I don't need to manually tweak the load path in their
> package definitions (I think, at least; was looking at the issue a while
> back).

I'm not sure what you mean by this manual tweak, why do you need it?
Doesn't a package work without it?

Anyway, I don't mind if all Emacs packages would be prefixed with
"emacs-".  At least, it would be consistent: no need to think if this or
that package is just a library or an end-user application.

-- 
Alex

Message #34 received at 29582-done <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: Leo Famulari <leo <at> famulari.name>, 29582-done <at> debbugs.gnu.org
Subject: Re: [bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.
Date: Sun, 10 Dec 2017 22:41:35 +0300

Ludovic Courtès (2017-12-08 10:44 +0100) wrote:

> Hi,
>
> Alex Kost <alezost <at> gmail.com> skribis:
>
>> Then I'm lost here: it is absolutely not clear for me where the border
>> between libraries and end-user applications lies in the Emacs world.
>> Such things as "emacs-dash" or "emacs-s" are definitely libraries but
>> most of the other Emacs packages are intended for users but we still
>> prefix them ("emacs-auctex", "emacs-pdf-tools", etc.)
>
> “emacs-git-modes” looks appropriate to me here and consistent with the
> choices we’ve made so far.

Committed as 6d21272b2, thanks all for the comments!

-- 
Alex

Message #37 received at 29582 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Alex Kost <alezost <at> gmail.com>
Cc: 29582 <at> debbugs.gnu.org
Subject: Re: [bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.
Date: Sun, 24 Dec 2017 10:44:11 -0500

Alex Kost <alezost <at> gmail.com> writes:

> Kyle Meyer (2017-12-09 10:51 -0500) wrote:

[...]

>> I prefer "emacs-" for consistency, but the practical reason I want it is
>> so that emacs-packages? recognizes magit.  That way, if I package some
>> magit extensions, I don't need to manually tweak the load path in their
>> package definitions (I think, at least; was looking at the issue a while
>> back).
>
> I'm not sure what you mean by this manual tweak, why do you need it?

When I'm defining a new emacs package, emacs-build-system:build takes
care of updating the load path to include directories for emacs packages
in the inputs, but it relies on emacs-packages?, which relies on the
"emacs-" prefix, to do this.  So, if I'm defining a package that depends
on Magit, I need to manually set load-path in the build phase.

-- 
Kyle

Message #40 received at 29582 <at> debbugs.gnu.org (full text, mbox):

From: Alex Kost <alezost <at> gmail.com>
To: Kyle Meyer <kyle <at> kyleam.com>
Cc: 29582 <at> debbugs.gnu.org
Subject: Re: [bug#29582] [PATCH] gnu: git-modes: Rename to 'emacs-git-modes'.
Date: Sun, 24 Dec 2017 23:45:10 +0300

Kyle Meyer (2017-12-24 10:44 -0500) wrote:

> Alex Kost <alezost <at> gmail.com> writes:
>
>> Kyle Meyer (2017-12-09 10:51 -0500) wrote:
>
> [...]
>
>>> I prefer "emacs-" for consistency, but the practical reason I want it is
>>> so that emacs-packages? recognizes magit.  That way, if I package some
>>> magit extensions, I don't need to manually tweak the load path in their
>>> package definitions (I think, at least; was looking at the issue a while
>>> back).
>>
>> I'm not sure what you mean by this manual tweak, why do you need it?
>
> When I'm defining a new emacs package, emacs-build-system:build takes
> care of updating the load path to include directories for emacs packages
> in the inputs, but it relies on emacs-packages?, which relies on the
> "emacs-" prefix, to do this.  So, if I'm defining a package that depends
> on Magit, I need to manually set load-path in the build phase.

Yeah, this is a problem, I don't like relying on "emacs-" prefix, but it
is probably the only reasonable way we have to determine emacs packages.
So prefixing all emacs packges with "emacs-" would be a good Guix
policy, I think.

BTW, there is another discussion related to this problem.  See the
bottom of <https://debbugs.gnu.org/cgi/bugreport.cgi?bug=28832#71>.

I think all this stuff should be discussed in a separate thread (on
guix-devel mailing list).

-- 
Alex

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.