GNU bug report logs - #29557
lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID?

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#29557: closed (lookup_basic_face:  Should we add
 VERTICAL_BORDER_FACE_ID?)
Date: Mon, 04 Dec 2017 15:46:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 04 Dec 2017 17:45:26 +0200
with message-id <83y3mixzs9.fsf <at> gnu.org>
and subject line Re: bug#29557: lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID?
has caused the debbugs.gnu.org bug report #29557,
regarding lookup_basic_face:  Should we add VERTICAL_BORDER_FACE_ID?
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
29557: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=29557
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Keith David Bershatsky <esq <at> lawlist.com>
To: Emacs Bug Reports <bug-gnu-emacs <at> gnu.org>
Subject: lookup_basic_face:  Should we add VERTICAL_BORDER_FACE_ID?
Date: Sun, 03 Dec 2017 17:59:34 -0800

I had assumed that VERTICAL_BORDER_FACE_ID was a basic face (see dispextern.h at line 1750).  However, it is not identified as such within lookup_basic_face.  Is this something that should be added?  Without it, Emacs will throw an error if someone tries to look it up and its not there.

case VERTICAL_BORDER_FACE_ID: name = Qvertical_border; break;

Thanks,

Keith

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Keith David Bershatsky <esq <at> lawlist.com>
Cc: 29557-done <at> debbugs.gnu.org
Subject: Re: bug#29557: lookup_basic_face: Should we add
 VERTICAL_BORDER_FACE_ID?
Date: Mon, 04 Dec 2017 17:45:26 +0200

> Date: Sun, 03 Dec 2017 17:59:34 -0800
> From: Keith David Bershatsky <esq <at> lawlist.com>
> 
> I had assumed that VERTICAL_BORDER_FACE_ID was a basic face (see dispextern.h at line 1750).  However, it is not identified as such within lookup_basic_face.  Is this something that should be added?  Without it, Emacs will throw an error if someone tries to look it up and its not there.

Yes, it's an omission (and a very old one).

Fixed on the master branch.  Thanks for reporting this.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.