GNU bug report logs - #29557
lookup_basic_face: Should we add VERTICAL_BORDER_FACE_ID?

Previous Next

Package: emacs;

Reported by: Keith David Bershatsky <esq <at> lawlist.com>

Date: Mon, 4 Dec 2017 02:00:02 UTC

Severity: wishlist

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 29557 in the body.
You can then email your comments to 29557 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#29557; Package emacs. (Mon, 04 Dec 2017 02:00:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Keith David Bershatsky <esq <at> lawlist.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Mon, 04 Dec 2017 02:00:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Keith David Bershatsky <esq <at> lawlist.com>
To: Emacs Bug Reports <bug-gnu-emacs <at> gnu.org>
Subject: lookup_basic_face:  Should we add VERTICAL_BORDER_FACE_ID?
Date: Sun, 03 Dec 2017 17:59:34 -0800

I had assumed that VERTICAL_BORDER_FACE_ID was a basic face (see dispextern.h at line 1750).  However, it is not identified as such within lookup_basic_face.  Is this something that should be added?  Without it, Emacs will throw an error if someone tries to look it up and its not there.

case VERTICAL_BORDER_FACE_ID: name = Qvertical_border; break;

Thanks,

Keith
Reply sent to Eli Zaretskii <eliz <at> gnu.org>:
You have taken responsibility. (Mon, 04 Dec 2017 15:46:01 GMT) Full text and rfc822 format available.
Notification sent to Keith David Bershatsky <esq <at> lawlist.com>:
bug acknowledged by developer. (Mon, 04 Dec 2017 15:46:03 GMT) Full text and rfc822 format available.

Message #10 received at 29557-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Keith David Bershatsky <esq <at> lawlist.com>
Cc: 29557-done <at> debbugs.gnu.org
Subject: Re: bug#29557: lookup_basic_face: Should we add
 VERTICAL_BORDER_FACE_ID?
Date: Mon, 04 Dec 2017 17:45:26 +0200

> Date: Sun, 03 Dec 2017 17:59:34 -0800
> From: Keith David Bershatsky <esq <at> lawlist.com>
> 
> I had assumed that VERTICAL_BORDER_FACE_ID was a basic face (see dispextern.h at line 1750).  However, it is not identified as such within lookup_basic_face.  Is this something that should be added?  Without it, Emacs will throw an error if someone tries to look it up and its not there.

Yes, it's an omission (and a very old one).

Fixed on the master branch.  Thanks for reporting this.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 02 Jan 2018 12:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 7 years and 166 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.