GNU bug report logs - #29536
[PATCH] gnu: Add cava.

Previous Next

Full log

Message #14 received at 29536 <at> debbugs.gnu.org (full text, mbox):

From: Oleg Pykhalov <go.wigust <at> gmail.com>
To: ng0 <ng0 <at> n0.is>
Cc: 29536 <at> debbugs.gnu.org
Subject: Re: [bug#29536] [PATCH] gnu: Add cava.
Date: Sun, 03 Dec 2017 10:16:18 +0300

[Message part 1 (text/plain, inline)]

Hello ng0,

ng0 <ng0 <at> n0.is> writes:

> which patch would someone review? Aren't they supposed to be one patch?
> We don't have cava (as you are obviously adding it) and the 2nd patch
> makes a change to cava.
> We try to logically group patches, and this is a case where having it
> in one patch makes sense, when a new package is getting added.

[...]

Sorry for that.  The second patch are just minor things (indent and
remove missleading comment).  It expected to be squashed as patch's
message says.


I also think about adding an example of configuration from origin
tarball as I did https://debbugs.gnu.org/cgi/bugreport.cgi?bug=29535

cava unlike cli-visualizer creates a configuration file for the first
time, but it's empty and useless without example or documentation.


Oleg.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.